Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

UI Issue: Path should be lowercase #173

Closed
tallpauley opened this issue Aug 24, 2017 · 6 comments
Closed

UI Issue: Path should be lowercase #173

tallpauley opened this issue Aug 24, 2017 · 6 comments

Comments

@tallpauley
Copy link
Collaborator

tallpauley commented Aug 24, 2017

The path that is shown when browsing the secret backend shouldn't be normalized to uppercase. I consider this a bug, since the displayed breadcrumb isn't technically correct.

In addition, if someone wants to fix this it would be nice if that path could be easily copied too, for CLI usage. This could either be accomplished by the breadcrumb being copyable text, or a "copy path" button. I lumped this in since it could be part of fixing the UI bug.

@tallpauley tallpauley changed the title UX Issue: Path should be lowercase UI Issue: Path should be lowercase Aug 24, 2017
@djenriquez
Copy link
Owner

@tallpauley This is covered in this image: djenriquez/vault-ui:550de88. PTAL.

@tallpauley
Copy link
Collaborator Author

LGTM. Font could be slightly larger?

@rosspeoples
Copy link
Contributor

It looks a little weird now. Before, it was clear that was a path/breadcrumbs list, now it's just kind of a link lost in a large gray box. It could use a slightly bigger font, and maybe a darker or lighter background to make it stick out a little better.

@rosspeoples
Copy link
Contributor

What do you guys think about this?
screen shot 2017-08-30 at 11 28 09 am

@rosspeoples
Copy link
Contributor

That was done by changing the style on that <div> that contains the list and the New Secret button to remove the padding and align-items styles, then setting its background color to #dedcdc. Then I just made a new CSS rule for the links (which could be more strict):

a {
    color: rgb(0, 147, 167);
    font-size: 1.2em;
}

@tallpauley
Copy link
Collaborator Author

@deejross I agree, that is definitely an improvement. Also, the padding to the left of the secret path looks too wide, probably residual from the previous layout?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants