-
Notifications
You must be signed in to change notification settings - Fork 149
Performance issues when working with large number of users/policies #174
Comments
Thanks for reporting this @aramhovsepyan and appreciate the kudos. Pagination should definitely be everywhere. Its easy enough to add it in to each module, but I think it would benefit the project greater to design this properly to have it be its own default module thats implemented for every list. We'll look into getting this in. In the meanwhile, can you confirm that listing is not a problem for you using the Vault CLI? Our bottleneck on performance will be Vault's API, which at this point, I don't believe has the ability to partition results. |
Hey @djenriquez, |
@aramhovsepyan If you can, please test out the image |
Hi @djenriquez |
Don't get used to it @aramhovsepyan! I work on this project in waves, when time between life and my main job allows 😝. I'll think about the policies some more, the problem with policies is that vault-ui must store them all in memory in the browser because of the nature of the call. It may the a browser limit that's being hit. What operating system are you using? I can give you a build for the desktop client that may handle things better. Open for other suggestions also. |
Thanks @djenriquez . We very much appreciate it even if it's in waves :). |
Sorry @aramhovsepyan, a little confused. When you say right now, do you mean with the change or without? Is the issue resolved for you with this change? |
My bad, sorry. With the changes the issues for the users are indeed resolved! Vault UI still crashes when I try to list ~50k policies (each user has a policy). If you have time for a similar fix there as well we would highly appreciate it. |
Hi @djenriquez, |
Hi @aramhovsepyan. The refactor actually did include pagination at the policy level. By default, the UI will only show 7 policies. I think, however, it may be having issues loading all 50K+ policies into the UI's memory on API call, causing the UI to be unresponsive. I'm not really quite sure how to handle this since we're limited by Vault's API. We could possible truncate the results, but that doesn't do you any good if what you need was cut off... Hmm. |
Hi @djenriquez |
Hi @djenriquez |
aha! it looks like i missed that one!!! Great catch @aramhovsepyan, i'll get that in soon. |
@aramhovsepyan apologies for the major delay. The fix is included in #187 and deployed to image |
Hi @djenriquez , |
Awesome! Glad it is working. Merged in. About donations, I suppose I could try it out! http://ko-fi.com/djenriquez Many thanks, @aramhovsepyan. Feel free to close this issue if you believe it to be resolved. |
Hi DJ Enriques,
First of all, kudos on the Vault UI. Great work.
We are currently somewhat struggling with Vault UI crashing when there are 50000 users/policies in the vault. What's the complexity of creating a pagination feature on that one?
Thanks a lot.
Regards,
Aram.
PS: I've looked through the list of issues and couldn't find this of being a duplicate.
The text was updated successfully, but these errors were encountered: