Reset view and pagination

[Garath620]

Hello @djenriquez,

I think I have found a bug with pagination:
After viewing or editing a secret, pressing Cancel or Save will reset the filter and pagination.
The current page will be lost and the interface will show a another random(?) page

[djenriquez]

Thanks @Garath620, looking into this now.

[djenriquez]

@Garath620 This fix is on :latest and :2.2.0, please verify and close this issue once you're confirmed the fix.

[Garath620]

Hi @djenriquez,
I have tested 2.2.0. Filter stay applied after viewing secret. Thanks
But without filter, I have the same behavior, the current page is lost and the interface show a another random.

[djenriquez]

Interesting, I thought I had tested that out. I'll take a look at it later tonight again.

[djenriquez]

@Garath620 I'm trying to duplicate the issue that you're describing but cannot. On 2.2.0, if I add a filter to the secrets list with multiple pages, verify it still has multiple pages, go to a random page, click out of the secret either with cancel or save, it brings me back to the correct page with the secret I just viewed/updated.

Without a filter, the behavior is exactly the same.

Can you provide any more clues to help me replicate the issue so that it can be fixed?

[Garath620]

Hi @djenriquez,
You do not need to add a filter. Just select a secret name to view it. Press Cancel and the current page is changed.

[djenriquez]

I'll take another look. 👍

[Garath620]

Hi @djenriquez
To help you duplicate the issue, I make a screencast
I have a generic backend test => for i in {1..100} \ ; do vault write test/test$i key=value; done
Look the current page number

[djenriquez]

@Garath620 PTAL at image djenriquez/vault-ui:550de88 which has the changes needed to fix this issue. I'll merge this in as soon as I get a few eyes on #175.

[Garath620]

Hi @djenriquez,
I confirm, this problem is solved
Thank you very much!