Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Upgrade base image to node:8.1.4-alpine #148

Merged
merged 2 commits into from
Jul 27, 2017
Merged

Upgrade base image to node:8.1.4-alpine #148

merged 2 commits into from
Jul 27, 2017

Conversation

lcgkm
Copy link
Contributor

@lcgkm lcgkm commented Jul 19, 2017

yarn global add nodemon

can avoid this issue yarnpkg/yarn#3531

But I found another issue:

yarn run v0.24.6
$ nodemon ./server.js start_app
[nodemon] 1.11.0
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: *.*
[nodemon] starting `node ./server.js start_app`
module.js:487
    throw err;
    ^

Error: Cannot find module 'express'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/app/server.js:3:15)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)

so, all commands should be:

yarn install --silent --production
yarn check --verify-tree --production
yarn global add nodemon

@djenriquez
Copy link
Owner

@lcgkm Sounds like yarn install --silent --production yarn check --verify-tree --production yarn global add nodemon fixes the issue you found after globally adding nodemon? Can you confirm?

@lcgkm
Copy link
Contributor Author

lcgkm commented Jul 20, 2017

@djenriquez Yes, I confirmed. It worked well now.

@djenriquez
Copy link
Owner

Hey @lcgkm sorry for being so late on this. Tested this out and LGTM, really appreciate the work! That yarn nodemon thing was getting annoying =P.

@djenriquez djenriquez merged commit dfed36a into djenriquez:master Jul 27, 2017
conor-mullen added a commit to Financial-Times/vault-ui that referenced this pull request Jan 31, 2018
* ENTRYPOINT with CUSTOM_CA_CERT env var

* Replace HCL parsing library

* Helm chart for vault-ui (djenriquez#149)

* chart import

* README added

* added directory for better clarity

* fix chart description

* Upgrade base image to node:8.1.4-alpine (djenriquez#148)

* Upgrade base image to node:8.1.4-alpine

* fix invalid github endpoint var name

* fix invalid github endpoint var name (djenriquez#155)

* Upgrade base image to node:8.1.4-alpine

* fix invalid github endpoint var name

* Update Github.jsx

* Okta Authentication Backend (djenriquez#156)

* Add Okta resources

* Remove comments

* Add check for required org name

* allows for server port to be configured via env var PORT (djenriquez#162)

* Update PolicyPicker.jsx (djenriquez#169)

* Add login button (djenriquez#172)

* Add login button

* Improve validation

* AppRole Authentication Backend (djenriquez#171)

* Initial commit for approle auth

* Place role name field in new render

* Add property fields + fix create/update

* Complete base functionality

* Update README.md

* Fix README, clarify NODE_TLS_REJECT_UNAUTHORIZED

* Fix typo (djenriquez#176)

* Add ItemList Class (djenriquez#175)

* Introduce ItemList obj

* Upgrade base node image

* Add ItemList to AWS, clean up

* Add ItemList to AWSEc2, clean up

* Fix deleteobject logic

* Fix delete for AWS

* Fix delete for awsec2

* Add max items per page option

* Fix bug that randomly sets page

* Bug fixes + itemlist progress

* More bug fixes

* Cleanup and rename policypicker to itempicker

* Add ItemList to Radius

* Add ItemList to UserPass

* Refactor Secrets to use ItemList

* Fix styling

* Remove case insensitivity

* Clean up directory separator

* Fix delete regression

* Cleanup itemUri

* Breadcrumb Styles Improvement & "copy path" icon button (djenriquez#180)

* improving breadcrumb styles, adding copy path button

* improve spacing

* fix dash issue w/ breadcrumb

* Fix favicon (djenriquez#188)

* Update README.md

Add gitter badge

* Add itemlist to policy management (djenriquez#187)

* Update README.md

* Update LICENSE

* fixing behavior for ALL breaking characters

* Upgrade node to 8.5, remove deprecated MAINTAINER (djenriquez#193)

* clarifies expected value for VAULT_URL_DEFAULT (djenriquez#194)

Adds a notice to the description of the VAULT_URL_DEFAULT parameter explaining that the protocol part of the url is mandatory. This is a workaround for the unclear error message an user gets if it is missing

* Correct the dist reference for the electron app (djenriquez#199)

* Add KV compatibility (djenriquez#198)

* Maintenance: Upgrade packages (djenriquez#200)

* Upgrade dependencies

* Upgrade base node image

* Add stop propogation fix for upgrade bug

* Fix paging bug

* Upgrade react, react-dom, pagination

* Upgrade babel, webpack, extract-text-webpack-plugin; add prop-types in prep for React 16

* Update CHANGELOG

* Update version

* Squash big but easy bug for userpass (djenriquez#201)

* v2.4.0-rc2

* Fix secrets list reset (djenriquez#202)

* Fix navigation bug when access is denied (djenriquez#203)

* Fix path navigation when access is denied

* Cleanup fix

* Improve Vault endpoint check (djenriquez#204)

* empty catch statements don't resolve, breaking behavior if can't create orphan

* Improve styling (djenriquez#207)

* Improve real-estate

* Fix z-index for content container

* Fix scrolling (djenriquez#208)

* Improve real-estate

* Fix z-index for content container

* Fix styling /w @Lucretius help

* Fix right border with overflow enabled

* Reduce right margin

* v2.4.0-rc3

* Upgrade to node alpine-8.8 (djenriquez#218)

* Add logic to handle supplied auth token header (djenriquez#220)

* Fix policy schema (djenriquez#228)

* Add new vault properties

* Update policy schema

* Remove nodemon from default run (djenriquez#227)

* Updated yarn.lock after yarn build

* Updated packagaes

* Specify electron-builder version

* Updated electron to resolve critical vulnerability
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants