-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tasks to block dispatch #14056
Comments
Replaced by #14661 |
#14661 is just the tech spec. This ticket exists to implement solutions that fall out of the tech spec |
1 |
2 |
3 | |||||
5 | |||||||
8 | Multiple PRs probably AC
Why 3?
Why 5?
|
…egin (#15022) Connects #14056 ### Description Teaches Appeal (& LegacyAppeal) how to know if an appeal is ready for BVA Dispatch in preparation for allowing tasks to block bva dispatch ### Acceptance Criteria - [ ] Tests pass - [ ] AMA Appeals can correct state if a BvaDispatchTask should be opened - [ ] Legacy Appeals should never be in a state to recieve a BvaDispatchTask ### Testing Plan 1. Review the test cases - double check any you are suspicious of? Run any additional tests? Am I missing any scenarios? ### User Facing Changes None
Placing back into Team queue - work is engineered & reveiwed, but awaiting gov partner feedback & implementation of the case of post-decision appeals handling. Slack thread |
@lomky Per the Board: "None of the tasks below should block a motion to vacate and they can move simultaneously: CongressionalInterestMailTask |
Additional AC:
The Reporting Team (TIB) has a report showing cases that are ready for distribution, which uses the blocking-task logic discussed in Case Distribution Blocking Tasks #75. If we change this logic, we need to notify the Reporting Team so they can update their queries. Slack convo |
Connects #14055 and #14661
Following discussions on various implementations on blocking dispatch tasks, echo engineers have chosen a solution which we feel will cover the desired blocking scenarios and be the least likely to cause disruption to other areas of the codebase.
The solution revolves around determining the status of a blocking task's appeal prior to its creation, which in return will determine whether the task is created on the
BvaDispatchTask
or theRootTask
.BvaDispatchTask
BvaDispatchTask
assigned to a user, the blocking task should be created as a child to this task. In this instance, the dispatch task shall be placed on hold which prevents the user from completing it and places it into the users on hold tab.RootTask
BvaDispatchTask
, the blocking task should be created directly on theRootTask
.Other necessary steps
Additionally, in the locations (here and here) where we are creating
BvaDispatchTask
, we need to do a check for the existence of any of the blocking tasks and prevent the creation of the dispatch task if they do exist (e.g.tasks.open.blocks_dispatch.any?
).Finally, when the blocking task has been completed we need to proceed with the creation of the
BvaDispatchTask
. If the logic for not creating a dispatch task is captured increate_from_root_task
then we do not need to check for open blocking tasks anywhere else.The text was updated successfully, but these errors were encountered: