Teaches BVA Dispatching Tasks to actually block

[lomky]

Connects #14056

Part 2 of the stack:

Part 1: #15040
Part 2: this PR
Part 3: #15042

Description

When a task is created that blocks_dispatch, we will check whether we need to override
the parent of this task.

• If the parent task is already a child of the active BVA Dispatch task, don't override
• If the appeal doesn't have any BVA Dispatch Tasks yet, don't override
• If the appeal has open BVA Dispatch Task(s), set it to be the parent, preferring open User task then falling back to open Organization Task

Acceptance Criteria

• Code compiles correctly
• (Stack 1) Certain tasks will have the ability to block dispatch
• These task should be created under RootTask* or BvaDispatchTask (Stack 2)
• (Stack 3) BvaDispatch tasks are not created when tasks that block dispatch are still open (Stack 3)
• (Stack 3) BvaDispatchTask is created when all tasks that block dispatch are closed (Stack 3)

Testing Plan

Test creating these blocking tasks at various appeal points. You should be able to use the Realistic task tree Appeal Factory to get to JudgeDecisionReview, but beyond that cases will need to be manupulated via UI or manual task creation.

1. An appeal at Ready for Distribution
   • parent should be the passed in task (root task)
2. An appeal at Attorney Drafting
   • parent should be the passed in task (root task)
3. An appeal at BvaDispatch (org & user tasks exist)
   • parent should be the BvaDispatch user task!
4. An appeal at BvaDispatch (org & user tasks exist, user task cancelled or deleted, org task assigned)
   • parent should be the BvaDispatch org task!
5. An appeal Returned from BvaDispatch, pass in Root Task
   • parent should be the BvaDispatch user task!
6. An appeal Returned from BvaDispatch, pass in Judge Decision Review Task
   • parent should be the Judge Decision Review Task
7. An appeal past BvaDispatch (org & user tasks exist and are completed)
   • parent should be the passed in task (root task)

[yoomlam]

Some preliminary suggestions and questions.

[yoomlam]

Nitpicks for consistency and clarity.

[yoomlam]

Suggestions to make the tests easier to understand.

[yoomlam]

Testing notes:

FeatureToggle.enable!(:block_at_dispatch) 

# Testing Plan item 1
appeal=FactoryBot.create(:appeal, :ready_for_distribution)
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: appeal.root_task, assigned_by: User.last, assigned_to: Colocated.singleton)

# Testing Plan item 2
# Logged in as atty CASPER and picked an appeal
appeal=appeal_("f68df7d3-0068-46fe-8d88-cb9158c515d6")
appeal.reload.treee
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: appeal.root_task, assigned_by: User.last, assigned_to: Colocated.singleton)
appeal.reload.treee

# Testing Plan item 3
# Logged in as Dispatch user BVAGWHITE 
appeal=appeal_("375291f3-6626-4fed-a59e-7bbf2440f707")
appeal.reload.treee
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: appeal.root_task, assigned_by: User.last, assigned_to: Colocated.singleton)
appeal.reload.treee

# Testing Plan item 4.a
# Logged in as Dispatch user BVAGWHITE 
appeal=appeal_("8786cac4-6cc0-4938-bc20-f3490f0e6f2e")
appeal.reload.treee
Task.find(990).cancelled!
Task.find(989).on_hold!
appeal.reload.treee
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: appeal.root_task, assigned_by: User.last, assigned_to: Colocated.singleton)
appeal.reload.treee

# Testing Plan item 4.b
# Logged in as Dispatch user BVAGWHITE 
appeal=appeal_("34c455d7-e6bc-455c-8634-61a39f15567f")
appeal.reload.treee
Task.find(979).delete
appeal.reload.treee
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: appeal.root_task, assigned_by: User.last, assigned_to: Colocated.singleton)
appeal.reload.treee

# Testing Plan item 5
# Logged in as Dispatch user BVAGWHITE 
appeal=appeal_("1beaa592-ec65-4b49-bc9d-ad0c8a4c2149")
# Return to judge
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: appeal.root_task, assigned_by: User.last, assigned_to: Colocated.singleton)

# Testing Plan item 6
# Logged in as Dispatch user BVAGWHITE 
# Choose an appeal or delete tasks
Task.where(id: [2734,2735,2736,2737,2738]).map(&:delete)
# Return to judge
appeal.reload.treee
jdrt=JudgeDispatchReturnTask.find(2728)
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: jdrt, assigned_by: User.last, assigned_to: Colocated.singleton)
appeal.reload.treee

# Testing Plan item 7
appeal.reload.treee
# Mark user-assignee DispatchTask complete
Task.find(1001).completed!
parent_task=FoiaColocatedTask.create!(appeal: appeal, parent: appeal.root_task, assigned_by: User.last, assigned_to: Colocated.singleton)
appeal.reload.treee

[yoomlam]

🚀 👍

[hschallhorn]

Found 2 issues when testing part 3
#15042 (review)
#15042 (review)

[lomky]

Thanks @hschallhorn!

I think I've fixed it:
AMA:

                                                     ┌─────────────────────────────────────────────────────────────────────────────┐
Appeal 32 (direct_review) ────────────────────────── │ ID   │ STATUS   │ ASGN_BY           │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                                         │ 1938 │ on_hold  │                   │ Bva         │ 2020-08-26 14:11:04 UTC │
    ├── JudgeDecisionReviewTask                      │ 1939 │ on_hold  │ CSS_ID585         │ BVAAABSHIRE │ 2020-08-26 14:11:04 UTC │
    │   └── AttorneyTask                             │ 1940 │ on_hold  │ BVAAABSHIRE       │ BVASCASPER1 │ 2020-08-26 14:11:04 UTC │
    │       └── AddressVerificationColocatedTask     │ 1941 │ on_hold  │ BVASCASPER1       │ Colocated   │ 2020-08-26 14:11:04 UTC │
    │           └── AddressVerificationColocatedTask │ 1942 │ assigned │ BVASCASPER1       │ CSS_ID1     │ 2020-08-26 14:11:04 UTC │
    └── PrivacyActTask                               │ 2674 │ assigned │ VLJ_SUPPORT_ADMIN │ PrivacyTeam │ 2020-08-26 14:17:37 UTC │
                                                     └─────────────────────────────────────────────────────────────────────────────┘

And Foia:
AMA:

                                ┌──────────────────────────────────────────────────────────────────────────┐
Appeal 24 (direct_review) ───── │ ID   │ STATUS      │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                    │ 1932 │ on_hold     │             │ Bva         │ 2020-08-26 14:11:04 UTC │
    ├── JudgeDecisionReviewTask │ 1933 │ in_progress │ CSS_ID579   │ BVAAABSHIRE │ 2020-08-26 14:27:50 UTC │
    │   └── AttorneyTask        │ 1934 │ completed   │ BVAAABSHIRE │ BVASCASPER1 │ 2020-08-26 14:11:04 UTC │
    └── FoiaColocatedTask       │ 2675 │ on_hold     │ BVAAABSHIRE │ PrivacyTeam │ 2020-08-26 14:28:47 UTC │
        └── FoiaTask            │ 2676 │ assigned    │ BVAAABSHIRE │ PrivacyTeam │ 2020-08-26 14:28:47 UTC │
                                └──────────────────────────────────────────────────────────────────────────┘

and now the messaging for Judges is wrong though - moving that fix back to PR 3

[yoomlam]

Wording suggestions.

[va-bot]

	1 Warning
⚠️	This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger