Teaches BVA Dispatch blocking tasks to invoke Dispatch on close #15042

lomky · 2020-08-21T20:55:14Z

Connects #14056

Part 3 of the stack:

Part 1: #15040
Part 2: #15041
Part 3: this PR

Description

When a task that blocks BVA Dispatch is closed, it evaluates the state of the appeal and attempts to create a BVA Dispatch Task if the appeal is otherwise ready

Teaches BvaDispatchTask to refuse to create if there open dispatch_blocking? tasks

Acceptance Criteria

Code compiles correctly
(Stack 1) Certain tasks will have the ability to block dispatch
(Stack 2) These task should be created under RootTask* or BvaDispatchTask (Stack 2)
BvaDispatch tasks are not created when tasks that block dispatch are still open (Stack 3)
BvaDispatchTask is created when all tasks that block dispatch are closed (Stack 3)

Testing Plan

UI Change

Privacy

Sign in as a VLJ Support admin or user, navigate to your queue and assign an appeal to the privacy team - confirm the success message has detailed information about next steps.

FOIA

Sign in as a Judge or Attorney, navigate to your queue and assign a FOIA admin action on an AMA appeal.

Confirm the message explains the case stays active with the user
Confirm the task is still in the users queue
Assign a FOIA admin action on a legacy appeal.
Confirm the message is the default "team queue" message
Confirm the case is not still in the users queue
Assign a non-FOIA admin action on an ama appeal.
Confirm the message is the default "team queue" message
Confirm the case is not still in the users queue

Test closing these blocking tasks at various appeal points.

You should be able to use the Realistic task tree Appeal Factory to get to JudgeDecisionReview, but beyond that cases will need to be manipulated via UI or manual task creation.

For all these cases create a Blocking Dispatch task off of the Root Task, unless otherwise specified

An appeal at Ready for Distribution
- blocking task closes without any other effect
An appeal at JudgeAssign
- blocking task closes without any other effect
An appeal at Quality Review
- blocking task closes without any other effect
An appeal at BVA Dispatch
- blocking task closes without any other effect

Test we block normal BVA Dispatch Flow

When the appeal would normally go to BVA Dispatch but is blocked - test we properly block

An appeal is at Judge Decision Review, create a blocking task on the root task
- completing the Judge DR does not create the BVA Dispatch Task
- then completing the blocking task does create the BVA Dispatch Task
An appeal is at Judge Decision Review, create two distinct blocking tasks on the root task
- completing the Judge DR does not create the BVA Dispatch Task
- then completing the first blocking task does not create the BVA Dispatch Task
- then completing the remaining blocking task does create the BVA Dispatch Task
An appeal is at Quality Review, create a blocking task on the root task
- completing the Quality Review does not create the BVA Dispatch Task
- then completing the blocking task does create the BVA Dispatch Task

When a task that blocks BVA Dispatch is closed, it evaluates the state of the appeal and attempts to create a BVA Dispatch Task if the appeal is otherwise ready Teaches BvaDispatchTask to refuse to create if there open dispatch_blocking? tasks

…cking_dispatch_stack_3

hschallhorn

Log in as Mail team member
Go to appeal from uuid below
Create a blocking mail task
An appeal at Ready for Distribution
- blocking task closes without any other effect

appeal = DistributionTask.on_hold.last.appeal

appeal.reload.treee
Appeal 708 (hearing)                          ID   STATUS   ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                                  2160 on_hold                Bva               2020-08-21 15:18:54 UTC
    ├── DistributionTask                      2161 on_hold                Bva               2020-08-21 15:18:54 UTC
    │   ├── HearingTask                       2162 on_hold                Bva               2020-08-21 15:18:54 UTC
    │   │   └── ScheduleHearingTask           2163 assigned               Bva               2020-08-21 15:18:54 UTC
    │   └── DeathCertificateMailTask          2164 on_hold                MailTeam          2020-08-21 15:18:54 UTC
    │       └── DeathCertificateMailTask      2165 on_hold                Colocated         2020-08-21 15:18:54 UTC
    │           └── DeathCertificateMailTask  2166 assigned               BVALSPORER        2020-08-21 15:18:54 UTC
    ├── AodMotionMailTask                     2167 assigned               MailTeam          2020-08-21 15:18:54 UTC
    └── CongressionalInterestMailTask         2182 on_hold                MailTeam          2020-08-25 19:20:39 UTC
        └── CongressionalInterestMailTask     2183 assigned JOLLY_POSTMAN LitigationSupport 2020-08-25 19:20:39 UTC

Task.find(2183).completed!
appeal.reload.treee

Appeal 708 (hearing)                          ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                                  2160 on_hold                 Bva               2020-08-21 15:18:54 UTC
    ├── DistributionTask                      2161 on_hold                 Bva               2020-08-21 15:18:54 UTC
    │   ├── HearingTask                       2162 on_hold                 Bva               2020-08-21 15:18:54 UTC
    │   │   └── ScheduleHearingTask           2163 assigned                Bva               2020-08-21 15:18:54 UTC
    │   └── DeathCertificateMailTask          2164 on_hold                 MailTeam          2020-08-21 15:18:54 UTC
    │       └── DeathCertificateMailTask      2165 on_hold                 Colocated         2020-08-21 15:18:54 UTC
    │           └── DeathCertificateMailTask  2166 assigned                BVALSPORER        2020-08-21 15:18:54 UTC
    ├── AodMotionMailTask                     2167 assigned                MailTeam          2020-08-21 15:18:54 UTC
    └── CongressionalInterestMailTask         2182 completed               MailTeam          2020-08-25 19:21:25 UTC
        └── CongressionalInterestMailTask     2183 completed JOLLY_POSTMAN LitigationSupport 2020-08-25 19:21:25 UTC

An appeal at JudgeAssign
- blocking task closes without any other effect

appeal = JudgeAssignTask.assigned.last.appeal
appeal.uuid
appeal.reload.treee
Appeal 709 (hearing)                          ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                                  2168 on_hold                 Bva               2020-08-21 15:19:33 UTC
    ├── DistributionTask                      2169 completed               Bva               2020-08-21 17:05:44 UTC
    │   ├── HearingTask                       2170 cancelled               Bva               2020-08-21 17:05:44 UTC
    │   │   └── ScheduleHearingTask           2171 cancelled               Bva               2020-08-21 17:05:44 UTC
    │   ├── DeathCertificateMailTask          2172 cancelled               MailTeam          2020-08-21 17:05:44 UTC
    │   │   └── DeathCertificateMailTask      2173 cancelled               Colocated         2020-08-21 17:05:44 UTC
    │   │       └── DeathCertificateMailTask  2174 cancelled               CSS_ID1           2020-08-21 17:05:44 UTC
    │   └── BlockedSpecialCaseMovementTask    2176 completed BVARDUNKLE    BVARDUNKLE        2020-08-21 17:05:44 UTC
    ├── AodMotionMailTask                     2175 assigned                MailTeam          2020-08-21 15:19:34 UTC
    ├── JudgeAssignTask                       2177 assigned  BVARDUNKLE    BVAAABSHIRE       2020-08-21 17:05:44 UTC
    └── CongressionalInterestMailTask         2184 on_hold                 MailTeam          2020-08-25 19:23:31 UTC
        └── CongressionalInterestMailTask     2185 assigned  JOLLY_POSTMAN LitigationSupport 2020-08-25 19:23:31 UTC

Task.find(2185).completed!
appeal.reload.treee
Appeal 709 (hearing)                          ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                                  2168 on_hold                 Bva               2020-08-21 15:19:33 UTC
    ├── DistributionTask                      2169 completed               Bva               2020-08-21 17:05:44 UTC
    │   ├── HearingTask                       2170 cancelled               Bva               2020-08-21 17:05:44 UTC
    │   │   └── ScheduleHearingTask           2171 cancelled               Bva               2020-08-21 17:05:44 UTC
    │   ├── DeathCertificateMailTask          2172 cancelled               MailTeam          2020-08-21 17:05:44 UTC
    │   │   └── DeathCertificateMailTask      2173 cancelled               Colocated         2020-08-21 17:05:44 UTC
    │   │       └── DeathCertificateMailTask  2174 cancelled               CSS_ID1           2020-08-21 17:05:44 UTC
    │   └── BlockedSpecialCaseMovementTask    2176 completed BVARDUNKLE    BVARDUNKLE        2020-08-21 17:05:44 UTC
    ├── AodMotionMailTask                     2175 assigned                MailTeam          2020-08-21 15:19:34 UTC
    ├── JudgeAssignTask                       2177 assigned  BVARDUNKLE    BVAAABSHIRE       2020-08-21 17:05:44 UTC
    └── CongressionalInterestMailTask         2184 completed               MailTeam          2020-08-25 19:23:49 UTC
        └── CongressionalInterestMailTask     2185 completed JOLLY_POSTMAN LitigationSupport 2020-08-25 19:23:49 UTC

An appeal at Quality Review
- blocking task closes without any other effect

appeal = QualityReviewTask.assigned.last.appeal
appeal.uuid
appeal.reload.treee
Appeal 180 (direct_review)                 ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               490  on_hold                 Bva               2020-08-20 21:22:32 UTC
    ├── DistributionTask                   491  assigned                Bva               2020-08-20 21:22:32 UTC
    ├── JudgeDecisionReviewTask            492  completed               CSS_ID44          2020-08-20 21:22:32 UTC
    │   └── AttorneyTask                   493  completed CSS_ID44      CSS_ID45          2020-08-20 21:22:32 UTC
    ├── QualityReviewTask                  494  assigned                QualityReview     2020-08-20 21:22:32 UTC
    └── CongressionalInterestMailTask      2186 on_hold                 MailTeam          2020-08-25 19:28:57 UTC
        └── CongressionalInterestMailTask  2187 assigned  JOLLY_POSTMAN LitigationSupport 2020-08-25 19:28:57 UTC

Task.find(2187).completed!
appeal.reload.treee
Appeal 180 (direct_review)                 ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               490  on_hold                 Bva               2020-08-20 21:22:32 UTC
    ├── DistributionTask                   491  assigned                Bva               2020-08-20 21:22:32 UTC
    ├── JudgeDecisionReviewTask            492  completed               CSS_ID44          2020-08-20 21:22:32 UTC
    │   └── AttorneyTask                   493  completed CSS_ID44      CSS_ID45          2020-08-20 21:22:32 UTC
    ├── QualityReviewTask                  494  assigned                QualityReview     2020-08-20 21:22:32 UTC
    └── CongressionalInterestMailTask      2186 completed               MailTeam          2020-08-25 19:29:26 UTC
        └── CongressionalInterestMailTask  2187 completed JOLLY_POSTMAN LitigationSupport 2020-08-25 19:29:26 UTC

An appeal at BVA Dispatch
- blocking task closes without any other effect

appeal = BvaDispatchTask.assigned.last.appeal
appeal.uuid
appeal.reload.treee
Appeal 172 (hearing)                               ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                                       454  on_hold                 Bva               2020-08-20 21:22:29 UTC
    ├── DistributionTask                           455  on_hold                 Bva               2020-08-20 21:22:29 UTC
    │   └── HearingTask                            456  on_hold                 Bva               2020-08-20 21:22:29 UTC
    │       └── ScheduleHearingTask                457  assigned                Bva               2020-08-20 21:22:29 UTC
    ├── JudgeDecisionReviewTask                    458  completed CSS_ID36      CSS_ID35          2020-08-20 21:22:30 UTC
    │   └── AttorneyTask                           459  completed CSS_ID35      CSS_ID37          2020-08-20 21:22:30 UTC
    └── BvaDispatchTask                            460  on_hold                 BvaDispatch       2020-08-20 21:22:30 UTC
        └── BvaDispatchTask                        461  on_hold                 BVAGWHITE         2020-08-25 19:30:17 UTC
            └── CongressionalInterestMailTask      2188 on_hold                 MailTeam          2020-08-25 19:30:17 UTC
                └── CongressionalInterestMailTask  2189 assigned  JOLLY_POSTMAN LitigationSupport 2020-08-25 19:30:17 UTC

Task.find(2189).completed!
appeal.reload.treee
Appeal 172 (hearing)                               ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                                       454  on_hold                 Bva               2020-08-20 21:22:29 UTC
    ├── DistributionTask                           455  on_hold                 Bva               2020-08-20 21:22:29 UTC
    │   └── HearingTask                            456  on_hold                 Bva               2020-08-20 21:22:29 UTC
    │       └── ScheduleHearingTask                457  assigned                Bva               2020-08-20 21:22:29 UTC
    ├── JudgeDecisionReviewTask                    458  completed CSS_ID36      CSS_ID35          2020-08-20 21:22:30 UTC
    │   └── AttorneyTask                           459  completed CSS_ID35      CSS_ID37          2020-08-20 21:22:30 UTC
    └── BvaDispatchTask                            460  on_hold                 BvaDispatch       2020-08-20 21:22:30 UTC
        └── BvaDispatchTask                        461  assigned                BVAGWHITE         2020-08-25 19:30:35 UTC
            └── CongressionalInterestMailTask      2188 completed               MailTeam          2020-08-25 19:30:35 UTC
                └── CongressionalInterestMailTask  2189 completed JOLLY_POSTMAN LitigationSupport 2020-08-25 19:30:35 UTC

Added test with attorney creating a foiacolocated task
⛔ FoiaColoctedTask is created as a child of the root task

Appeal 595 (evidence_submission)   ID   STATUS   ASGN_BY     ASGN_TO     UPDATED_AT
└── RootTask                       1596 on_hold              Bva         2020-08-20 21:23:56 UTC
    └── JudgeDecisionReviewTask    1597 on_hold  CSS_ID619   BVAACTING   2020-08-20 21:23:56 UTC
        └── AttorneyTask           1598 on_hold  BVAACTING   BVASCASPER1 2020-08-25 19:32:00 UTC
            └── FoiaColocatedTask  2190 on_hold  BVASCASPER1 PrivacyTeam 2020-08-25 19:32:00 UTC
                └── FoiaTask       2191 assigned BVASCASPER1 PrivacyTeam 2020-08-25 19:32:00 UTC

hschallhorn

Same steps as above with mail user creating tasks.

An appeal is at Judge Decision Review, create a blocking task on the root task
- completing the Judge DR does not create the BVA Dispatch Task
- then completing the blocking task does create the BVA Dispatch Task

appeal = JudgeDecisionReviewTask.assigned.last.appeal
appeal.uuid
appeal.reload.treee
Appeal 597 (evidence_submission)           ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               1602 on_hold                 Bva               2020-08-20 21:23:56 UTC
    ├── JudgeDecisionReviewTask            1603 assigned  CSS_ID623     BVAACTING         2020-08-20 21:23:56 UTC
    │   └── AttorneyTask                   1604 completed BVAACTING     BVASCASPER1       2020-08-20 21:23:56 UTC
    └── CongressionalInterestMailTask      2192 on_hold                 MailTeam          2020-08-25 19:35:21 UTC
        └── CongressionalInterestMailTask  2193 assigned  JOLLY_POSTMAN LitigationSupport 2020-08-25 19:35:21 UTC

# Complete JDRT
appeal.reload.treee
Appeal 597 (evidence_submission)           ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               1602 on_hold                 Bva               2020-08-20 21:23:56 UTC
    ├── JudgeDecisionReviewTask            1603 completed CSS_ID623     BVAACTING         2020-08-25 19:38:28 UTC
    │   └── AttorneyTask                   1604 completed BVAACTING     BVASCASPER1       2020-08-20 21:23:56 UTC
    └── CongressionalInterestMailTask      2192 on_hold                 MailTeam          2020-08-25 19:35:21 UTC
        └── CongressionalInterestMailTask  2193 assigned  JOLLY_POSTMAN LitigationSupport 2020-08-25 19:35:21 UTC

# Complete blocking task
appeal.reload.treee
Appeal 597 (evidence_submission)           ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               1602 on_hold                 Bva               2020-08-20 21:23:56 UTC
    ├── JudgeDecisionReviewTask            1603 completed CSS_ID623     BVAACTING         2020-08-25 19:38:28 UTC
    │   └── AttorneyTask                   1604 completed BVAACTING     BVASCASPER1       2020-08-20 21:23:56 UTC
    ├── CongressionalInterestMailTask      2192 completed               MailTeam          2020-08-25 19:39:43 UTC
    │   └── CongressionalInterestMailTask  2193 completed JOLLY_POSTMAN LitigationSupport 2020-08-25 19:39:43 UTC
    └── BvaDispatchTask                    2194 on_hold                 BvaDispatch       2020-08-25 19:39:43 UTC
        └── BvaDispatchTask                2195 assigned                BVAGWHITE         2020-08-25 19:39:43 UTC

An appeal is at Judge Decision Review, create two distinct blocking tasks on the root task
- completing the Judge DR does not create the BVA Dispatch Task
- then completing the first blocking task does not create the BVA Dispatch Task
- then completing the remaining blocking task does create the BVA Dispatch Task

appeal = JudgeDecisionReviewTask.assigned.last.appeal
appeal.uuid
appeal.reload.treee
Appeal 596 (evidence_submission)           ID   STATUS      ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               1599 on_hold                   Bva               2020-08-20 21:23:56 UTC
    ├── JudgeDecisionReviewTask            1600 in_progress CSS_ID620     BVAAABSHIRE       2020-08-25 19:42:02 UTC
    │   └── AttorneyTask                   1601 completed   BVAAABSHIRE   BVAACTING         2020-08-20 21:23:56 UTC
    ├── CongressionalInterestMailTask      2196 on_hold                   MailTeam          2020-08-25 19:41:07 UTC
    │   └── CongressionalInterestMailTask  2197 assigned    JOLLY_POSTMAN LitigationSupport 2020-08-25 19:41:07 UTC
    └── FoiaRequestMailTask                2198 on_hold                   MailTeam          2020-08-25 19:41:42 UTC
        └── FoiaRequestMailTask            2199 assigned    JOLLY_POSTMAN PrivacyTeam       2020-08-25 19:41:42 UTC

# Complete JDRT
appeal.reload.treee
Appeal 596 (evidence_submission)           ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               1599 on_hold                 Bva               2020-08-20 21:23:56 UTC
    ├── JudgeDecisionReviewTask            1600 completed CSS_ID620     BVAAABSHIRE       2020-08-25 19:43:12 UTC
    │   └── AttorneyTask                   1601 completed BVAAABSHIRE   BVAACTING         2020-08-20 21:23:56 UTC
    ├── CongressionalInterestMailTask      2196 on_hold                 MailTeam          2020-08-25 19:41:07 UTC
    │   └── CongressionalInterestMailTask  2197 assigned  JOLLY_POSTMAN LitigationSupport 2020-08-25 19:41:07 UTC
    └── FoiaRequestMailTask                2198 on_hold                 MailTeam          2020-08-25 19:41:42 UTC
        └── FoiaRequestMailTask            2199 assigned  JOLLY_POSTMAN PrivacyTeam       2020-08-25 19:41:42 UTC

# Complete blocking task 1
appeal.reload.treee
Appeal 596 (evidence_submission)           ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               1599 on_hold                 Bva               2020-08-20 21:23:56 UTC
    ├── JudgeDecisionReviewTask            1600 completed CSS_ID620     BVAAABSHIRE       2020-08-25 19:43:12 UTC
    │   └── AttorneyTask                   1601 completed BVAAABSHIRE   BVAACTING         2020-08-20 21:23:56 UTC
    ├── CongressionalInterestMailTask      2196 on_hold                 MailTeam          2020-08-25 19:41:07 UTC
    │   └── CongressionalInterestMailTask  2197 assigned  JOLLY_POSTMAN LitigationSupport 2020-08-25 19:41:07 UTC
    └── FoiaRequestMailTask                2198 completed               MailTeam          2020-08-25 19:43:53 UTC
        └── FoiaRequestMailTask            2199 completed JOLLY_POSTMAN PrivacyTeam       2020-08-25 19:43:52 UTC

# Complete blocking task 2
appeal.reload.treee
Appeal 596 (evidence_submission)           ID   STATUS    ASGN_BY       ASGN_TO           UPDATED_AT
└── RootTask                               1599 on_hold                 Bva               2020-08-20 21:23:56 UTC
    ├── JudgeDecisionReviewTask            1600 completed CSS_ID620     BVAAABSHIRE       2020-08-25 19:43:12 UTC
    │   └── AttorneyTask                   1601 completed BVAAABSHIRE   BVAACTING         2020-08-20 21:23:56 UTC
    ├── CongressionalInterestMailTask      2196 completed               MailTeam          2020-08-25 19:44:37 UTC
    │   └── CongressionalInterestMailTask  2197 completed JOLLY_POSTMAN LitigationSupport 2020-08-25 19:44:37 UTC
    ├── FoiaRequestMailTask                2198 completed               MailTeam          2020-08-25 19:43:53 UTC
    │   └── FoiaRequestMailTask            2199 completed JOLLY_POSTMAN PrivacyTeam       2020-08-25 19:43:52 UTC
    └── BvaDispatchTask                    2200 on_hold                 BvaDispatch       2020-08-25 19:44:38 UTC
        └── BvaDispatchTask                2201 assigned                BVAGWHITE         2020-08-25 19:44:38 UTC

An appeal is at Quality Review, create a blocking task on the root task
- completing the Quality Review does not create the BVA Dispatch Task
- then completing the blocking task does create the BVA Dispatch Task

appeal = QualityReviewTask.assigned.last.appeal
appeal.uuid
appeal.reload.treee
Appeal 180 (direct_review)                 ID   STATUS    ASGN_BY          ASGN_TO           UPDATED_AT
└── RootTask                               490  on_hold                    Bva               2020-08-20 21:22:32 UTC
    ├── DistributionTask                   491  assigned                   Bva               2020-08-20 21:22:32 UTC
    ├── JudgeDecisionReviewTask            492  completed                  CSS_ID44          2020-08-20 21:22:32 UTC
    │   └── AttorneyTask                   493  completed CSS_ID44         CSS_ID45          2020-08-20 21:22:32 UTC
    ├── QualityReviewTask                  494  assigned                   QualityReview     2020-08-25 19:45:46 UTC
    ├── CongressionalInterestMailTask      2186 completed                  MailTeam          2020-08-25 19:29:26 UTC
    │   └── CongressionalInterestMailTask  2187 completed JOLLY_POSTMAN    LitigationSupport 2020-08-25 19:29:26 UTC
    └── CongressionalInterestMailTask      2202 on_hold                    MailTeam          2020-08-25 19:45:30 UTC
        └── CongressionalInterestMailTask  2203 assigned  LIT_SUPPORT_USER LitigationSupport 2020-08-25 19:45:30 UTC

# Complete QRT
appeal.reload.treee
Appeal 180 (direct_review)                 ID   STATUS    ASGN_BY          ASGN_TO           UPDATED_AT
└── RootTask                               490  on_hold                    Bva               2020-08-20 21:22:32 UTC
    ├── DistributionTask                   491  assigned                   Bva               2020-08-20 21:22:32 UTC
    ├── JudgeDecisionReviewTask            492  completed                  CSS_ID44          2020-08-20 21:22:32 UTC
    │   └── AttorneyTask                   493  completed CSS_ID44         CSS_ID45          2020-08-20 21:22:32 UTC
    ├── QualityReviewTask                  494  completed                  QualityReview     2020-08-25 19:45:46 UTC
    ├── CongressionalInterestMailTask      2186 completed                  MailTeam          2020-08-25 19:29:26 UTC
    │   └── CongressionalInterestMailTask  2187 completed JOLLY_POSTMAN    LitigationSupport 2020-08-25 19:29:26 UTC
    └── CongressionalInterestMailTask      2202 on_hold                    MailTeam          2020-08-25 19:45:30 UTC
        └── CongressionalInterestMailTask  2203 assigned  LIT_SUPPORT_USER LitigationSupport 2020-08-25 19:45:30 UTC

# Complete blocking task
appeal.reload.treee
Appeal 180 (direct_review)                 ID   STATUS    ASGN_BY          ASGN_TO           UPDATED_AT
└── RootTask                               490  on_hold                    Bva               2020-08-20 21:22:32 UTC
    ├── DistributionTask                   491  assigned                   Bva               2020-08-20 21:22:32 UTC
    ├── JudgeDecisionReviewTask            492  completed                  CSS_ID44          2020-08-20 21:22:32 UTC
    │   └── AttorneyTask                   493  completed CSS_ID44         CSS_ID45          2020-08-20 21:22:32 UTC
    ├── QualityReviewTask                  494  completed                  QualityReview     2020-08-25 19:45:46 UTC
    ├── CongressionalInterestMailTask      2186 completed                  MailTeam          2020-08-25 19:29:26 UTC
    │   └── CongressionalInterestMailTask  2187 completed JOLLY_POSTMAN    LitigationSupport 2020-08-25 19:29:26 UTC
    ├── CongressionalInterestMailTask      2202 completed                  MailTeam          2020-08-25 19:46:46 UTC
    │   └── CongressionalInterestMailTask  2203 completed LIT_SUPPORT_USER LitigationSupport 2020-08-25 19:46:46 UTC
    └── BvaDispatchTask                    2204 on_hold                    BvaDispatch       2020-08-25 19:46:47 UTC
        └── BvaDispatchTask                2205 assigned                   BVAGWHITE         2020-08-25 19:46:47 UTC

hschallhorn

Testing vlj support changes
⛔ Privacy act task is created as child of root task

appeal.reload.treee
Appeal 32 (direct_review)                 ID   STATUS      ASGN_BY     ASGN_TO     UPDATED_AT
└── RootTask                              1414 on_hold                 Bva         2020-08-20 21:23:43 UTC
    └── JudgeDecisionReviewTask           1415 on_hold     CSS_ID601   BVAAABSHIRE 2020-08-20 21:23:44 UTC
        └── AttorneyTask                  1416 on_hold     BVAAABSHIRE BVASCASPER1 2020-08-20 21:23:44 UTC
            └── ArnesonColocatedTask      1417 on_hold     BVASCASPER1 Colocated   2020-08-20 21:23:44 UTC
                └── ArnesonColocatedTask  1418 in_progress BVASCASPER1 CSS_ID1     2020-08-25 19:48:38 UTC

appeal.reload.treee
Appeal 32 (direct_review)                 ID   STATUS   ASGN_BY     ASGN_TO     UPDATED_AT
└── RootTask                              1414 on_hold              Bva         2020-08-20 21:23:43 UTC
    └── JudgeDecisionReviewTask           1415 on_hold  CSS_ID601   BVAAABSHIRE 2020-08-20 21:23:44 UTC
        └── AttorneyTask                  1416 on_hold  BVAAABSHIRE BVASCASPER1 2020-08-20 21:23:44 UTC
            └── ArnesonColocatedTask      1417 on_hold  BVASCASPER1 Colocated   2020-08-20 21:23:44 UTC
                └── ArnesonColocatedTask  1418 on_hold  BVASCASPER1 CSS_ID1     2020-08-25 19:51:07 UTC
                    └── PrivacyActTask    2206 assigned CSS_ID1     PrivacyTeam 2020-08-25 19:51:07 UTC

UI Change:

hschallhorn

🙆 🙆 🙆 🙆

Need to update messaging for Colocated creation too!

…cking_dispatch_stack_3

va-bot · 2020-08-27T19:56:46Z

	1 Warning
⚠️	This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

…cking_dispatch_stack_3

ajspotts

Testing plan for FOIA admin actions works as expected 🙌

* Teaches BVA Dispatching Tasks to actually block * Renames dispatch parent hook * Apply suggestions from code review Co-authored-by: Yoom Lam <[email protected]> * Missed some names * Applys code review suggestions Co-authored-by: Yoom Lam <[email protected]> * Unblocks tasks preceeding BVA Dispatch * Update spec/models/task_spec.rb Co-authored-by: Yoom Lam <[email protected]> * Update spec/models/task_spec.rb Co-authored-by: Yoom Lam <[email protected]> * Adds safe call * Teaches BVA Dispatch blocking tasks to invoke Dispatch on close (#15042) * Teaches BVA Dispatch blocking tasks to invoke Dispatch on close When a task that blocks BVA Dispatch is closed, it evaluates the state of the appeal and attempts to create a BVA Dispatch Task if the appeal is otherwise ready Teaches BvaDispatchTask to refuse to create if there open dispatch_blocking? tasks * Enables the feature * Updates Privacy Task messaging to VLJ Support * Adds messaging for FOIA ama task assignment Co-authored-by: Yoom Lam <[email protected]>

This was referenced Aug 21, 2020

Allows tasks to block dispatch #15040

Closed

Teaches BVA Dispatching Tasks to actually block #15041

Merged

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

9b0a108

…cking_dispatch_stack_3

lomky self-assigned this Aug 21, 2020

lomky added 12 commits August 24, 2020 08:40

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

9d871b8

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

60b736b

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

4598bcc

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

934a548

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

6f65fc7

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

ef58715

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

9498af8

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

4c57261

…cking_dispatch_stack_3

Enables the feature

dd6415c

Updates Privacy Task messaging to VLJ Support

b8a7530

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

21ee9cc

…cking_dispatch_stack_3

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

9b24b05

…cking_dispatch_stack_3

hschallhorn reviewed Aug 25, 2020

View reviewed changes

hschallhorn previously approved these changes Aug 25, 2020

View reviewed changes

lomky added 2 commits August 26, 2020 11:07

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

deaa617

…cking_dispatch_stack_3

Adds messaging for FOIA ama task assignment

558bd65

Merge branch 'kat/14056_blocking_dispatch_stack_2' into kat/14056_blo…

2f2b125

…cking_dispatch_stack_3

ajspotts approved these changes Aug 28, 2020

View reviewed changes

lomky merged commit 213c293 into kat/14056_blocking_dispatch_stack_2 Aug 28, 2020

lomky deleted the kat/14056_blocking_dispatch_stack_3 branch August 28, 2020 17:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Teaches BVA Dispatch blocking tasks to invoke Dispatch on close #15042

Teaches BVA Dispatch blocking tasks to invoke Dispatch on close #15042

lomky commented Aug 21, 2020 •

edited by ajspotts

Loading

hschallhorn left a comment •

edited

Loading

hschallhorn left a comment •

edited

Loading

hschallhorn left a comment •

edited

Loading

hschallhorn left a comment

va-bot commented Aug 27, 2020 •

edited

Loading

ajspotts left a comment

Teaches BVA Dispatch blocking tasks to invoke Dispatch on close #15042

Teaches BVA Dispatch blocking tasks to invoke Dispatch on close #15042

Conversation

lomky commented Aug 21, 2020 • edited by ajspotts Loading

Description

Acceptance Criteria

Testing Plan

UI Change

Privacy

FOIA

Test closing these blocking tasks at various appeal points.

Test we block normal BVA Dispatch Flow

hschallhorn left a comment • edited Loading

Choose a reason for hiding this comment

hschallhorn left a comment • edited Loading

Choose a reason for hiding this comment

hschallhorn left a comment • edited Loading

Choose a reason for hiding this comment

hschallhorn left a comment

Choose a reason for hiding this comment

va-bot commented Aug 27, 2020 • edited Loading

ajspotts left a comment

Choose a reason for hiding this comment

lomky commented Aug 21, 2020 •

edited by ajspotts

Loading

hschallhorn left a comment •

edited

Loading

hschallhorn left a comment •

edited

Loading

hschallhorn left a comment •

edited

Loading

va-bot commented Aug 27, 2020 •

edited

Loading