Allows tasks to block dispatch #15040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames 'blocking?' to 'blocking_distribution?' Implements 'blocking_dispatch' and applies it to appropriate tasks - CongressionalInterestMailTask - FoiaRequestMailTask - PrivacyActRequestMailTask - PrivacyComplaintMailTask - FoiaColocatedTask - FoiaTask - PrivacyActTask
lomky
commented
Aug 21, 2020
| it "only returns active appeals that meet both of these conditions: | ||
| it has at least one Distribution Task with status assigned | ||
| AND | ||
| it doesn't have any blocking Mail Tasks." do | ||
| it "only returns active appeals that have at least one Distribution Task with status assigned" do |
There was a problem hiding this comment.
Semi-unrelated cleanup. The behavior that considered mail tasks here was fully removed in #14939
lomky
commented
Aug 21, 2020
lomky
commented
Aug 21, 2020
spec/models/tasks/special_case_movement/blocked_special_case_movement_task_spec.rb
Show resolved
Hide resolved
|
Code Climate has analyzed commit eebdad9 and detected 0 issues on this pull request. View more on Code Climate. |
lomky
commented
Aug 21, 2020
app/models/task.rb
Outdated
Comment on lines
606
to
609
| def blocking_dispatch? | ||
| self.class.blocking_dispatch? | ||
| end | ||
|
|
There was a problem hiding this comment.
Core of the new behavior is this file and all the subclasses that define blocking_dispatch?
lomky
commented
Aug 21, 2020
This was referenced Aug 21, 2020
hschallhorn
suggested changes
Aug 25, 2020
* Teaches BVA Dispatching Tasks to actually block * Renames dispatch parent hook * Apply suggestions from code review Co-authored-by: Yoom Lam <[email protected]> * Missed some names * Applys code review suggestions Co-authored-by: Yoom Lam <[email protected]> * Unblocks tasks preceeding BVA Dispatch * Update spec/models/task_spec.rb Co-authored-by: Yoom Lam <[email protected]> * Update spec/models/task_spec.rb Co-authored-by: Yoom Lam <[email protected]> * Adds safe call * Teaches BVA Dispatch blocking tasks to invoke Dispatch on close (#15042) * Teaches BVA Dispatch blocking tasks to invoke Dispatch on close When a task that blocks BVA Dispatch is closed, it evaluates the state of the appeal and attempts to create a BVA Dispatch Task if the appeal is otherwise ready Teaches BvaDispatchTask to refuse to create if there open dispatch_blocking? tasks * Enables the feature * Updates Privacy Task messaging to VLJ Support * Adds messaging for FOIA ama task assignment Co-authored-by: Yoom Lam <[email protected]>
Generated by 🚫 Danger |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14056
Part 1 of the stack:
Part 1: this PR
Part 2: #15041
Part 3: #15042
Description
Renames 'blocking?' to 'blocking_distribution?'
Implements 'blocking_dispatch' and applies it to appropriate tasks
Acceptance Criteria
Testing Plan