Update tasks to block dispatch

[hschallhorn]

The following tasks should be updated to block dispatch:

• CongressionalInterestMailTask
• FoiaRequestMailTask
• PrivacyActRequestMailTask
• PrivacyComplaintMailTask
• FoiaColocatedTask
• PrivacyActTask

Be aware of potential race conditions in updating the current tasks and enabling the flag. Consider a transaction!

Acceptance Criteria

• Clean up of the production data based on the implementation
• The tasks above block dispatch by enabling the FeatureToggle blocks_at_dispatch
• The feature toggle is removed (see reverting commit 96aac68 and removing the enables in the task_spec)

[yoomlam]

Updating prod data: these tasks should not block distribution.

[hschallhorn]

@araposo-tistatech Can we get some clarification around how the board envisions ChangeHearingDispositionTask would not block distributino? This task allows users to mark a hearing as

1. Postponed (a new hearing will be scheduled, which also blocks distribution)
2. No show (appeal is put on hold waiting for the veteran to send in mail as to why they they did not show, also blocks distribution)
3. Cancelled (an evidence submission window is opened which also blocks distribution)
4. Held (an evidence submission window is opened which also blocks distribution)

In my mind, this task has to block distribution as the appeal cannot continue forward with distribution if this task is not completed

[araposo-tistatech]

@hschallhorn I've sent an email to the Board.

[lomky]

We have some circular dependencies in our tickets to write the FE/BE/New behavior - I've noted a place in the BE implementation that this ticket should update for the health of the test suite:

https://github.com/department-of-veterans-affairs/caseflow/pull/14957/files#diff-e266c6cdf27b55f03934aa7e12a1c35bR54-R56

[araposo-tistatech]

@hschallhorn Mike S. at the Board stated the ChangeHearingDispositionTask should block distribution.

[hschallhorn]

what is this chart?

1 | 
2 | ||
3 | |||||
5 | ||
8 | 

Will have to be careful with child tasks. (FoiaTasks are always children of FoiaColocatedTasks) Don't disrupt the task subtree!

• Tasks that should block dispatch that are currently blocking distribution tasks should be moved to blocking dispatch
  • Update distribution task if moving this task makes the appeal ready to be distributed
• Tasks that should block dispatch that are currently blocking a judge assign or decision review tree (via attorney task or possibly via a colocated task) should be moved to blocking dispatch
  • Update judge or attorney or colocated task if moving this task makes the task ready to be worked

Why 2?

• Optimism!

Why 3?

• Messing around in prod always a little iffy
• Will require a second set of eyes for prod

Why 5?

• Could run into special cases we did not consider
• Hard to fully vet in dev

[lomky]

Researching

Update process drafted for:

• MailTasks
• Foia Tasks
• Privacy Tasks

Production Appeals Updated for:

• MailTasks
• Foia Tasks
• Privacy Tasks

[lomky]

Placing back into the team queue. Discovery work is done for Mail Tasks and in-progress for Foia Tasks (see hackMD). Completion blocked by #14056 with is awaiting gov partner response