Locks Dispatch Block to a FeatureToggle

department-of-veterans-affairs · Aug 24, 2020 · 96aac68 · 96aac68
1 parent 7ac8b06
commit 96aac68
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 7 deletions.
diff --git a/app/models/tasks/congressional_interest_mail_task.rb b/app/models/tasks/congressional_interest_mail_task.rb
@@ -1,8 +1,12 @@
 # frozen_string_literal: true
 
 class CongressionalInterestMailTask < MailTask
+  def self.blocking_distribution?
+    FeatureToggle.enabled?(:block_at_dispatch) ? false : true
+  end
+
   def self.blocking_dispatch?
-    true
+    FeatureToggle.enabled?(:block_at_dispatch) ? true : false
   end
 
   def self.label

diff --git a/app/models/tasks/foia_colocated_task.rb b/app/models/tasks/foia_colocated_task.rb
@@ -12,7 +12,7 @@ def self.default_assignee
   end
 
   def self.blocking_dispatch?
-    true
+    FeatureToggle.enabled?(:block_at_dispatch) ? true : false
   end
 
   def hide_from_case_timeline

diff --git a/app/models/tasks/foia_request_mail_task.rb b/app/models/tasks/foia_request_mail_task.rb
@@ -9,7 +9,11 @@ def self.default_assignee(_parent)
     PrivacyTeam.singleton
   end
 
+  def self.blocking_distribution?
+    FeatureToggle.enabled?(:block_at_dispatch) ? false : true
+  end
+
   def self.blocking_dispatch?
-    true
+    FeatureToggle.enabled?(:block_at_dispatch) ? true : false
   end
 end
diff --git a/app/models/tasks/foia_task.rb b/app/models/tasks/foia_task.rb
@@ -5,7 +5,7 @@
 
 class FoiaTask < Task
   def self.blocking_dispatch?
-    true
+    FeatureToggle.enabled?(:block_at_dispatch) ? true : false
   end
 
   def available_actions(user)

diff --git a/app/models/tasks/privacy_act_request_mail_task.rb b/app/models/tasks/privacy_act_request_mail_task.rb
@@ -9,7 +9,11 @@ def self.default_assignee(_parent)
     PrivacyTeam.singleton
   end
 
+  def self.blocking_distribution?
+    FeatureToggle.enabled?(:block_at_dispatch) ? false : true
+  end
+
   def self.blocking_dispatch?
-    true
+    FeatureToggle.enabled?(:block_at_dispatch) ? true : false
   end
 end
diff --git a/app/models/tasks/privacy_act_task.rb b/app/models/tasks/privacy_act_task.rb
@@ -5,7 +5,7 @@
 
 class PrivacyActTask < Task
   def self.blocking_dispatch?
-    true
+    FeatureToggle.enabled?(:block_at_dispatch) ? true : false
   end
 
   def available_actions(user)

diff --git a/app/models/tasks/privacy_complaint_mail_task.rb b/app/models/tasks/privacy_complaint_mail_task.rb
@@ -9,7 +9,11 @@ def self.default_assignee(_parent)
     PrivacyTeam.singleton
   end
 
+  def self.blocking_distribution?
+    FeatureToggle.enabled?(:block_at_dispatch) ? false : true
+  end
+
   def self.blocking_dispatch?
-    true
+    FeatureToggle.enabled?(:block_at_dispatch) ? true : false
   end
 end
diff --git a/spec/models/docket_spec.rb b/spec/models/docket_spec.rb
@@ -118,6 +118,9 @@
           Colocated.singleton.add_user(user)
         end
 
+        before { FeatureToggle.enable!(:block_at_dispatch) }
+        after { FeatureToggle.disable!(:block_at_dispatch) }
+
         context "non distribution-blocking mail tasks" do
           it "includes those appeals" do
             nonblocking_appeal = create(:appeal,

diff --git a/spec/models/task_spec.rb b/spec/models/task_spec.rb
@@ -1705,6 +1705,9 @@ def next_assignee(_options = {})
     let(:appeal) { create(:appeal) }
     let(:task) { create(:task, appeal: appeal) }
 
+    before { FeatureToggle.enable!(:block_at_dispatch) }
+    after { FeatureToggle.disable!(:block_at_dispatch) }
+
     it "does not block dispatch" do
       expect(task.blocking_dispatch?).to be(false)
     end

diff --git a/spec/models/tasks/foia_task_spec.rb b/spec/models/tasks/foia_task_spec.rb
@@ -26,6 +26,9 @@
     let(:appeal) { create(:appeal) }
     let(:task) { create(:foia_task, appeal: appeal) }
 
+    before { FeatureToggle.enable!(:block_at_dispatch) }
+    after { FeatureToggle.disable!(:block_at_dispatch) }
+
     it "blocks dispatch" do
       expect(task.blocking_dispatch?).to be(true)
     end