2024-11-06 Custom DC stable release #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs the response count for autocompletion. Staging is not showing any responses. Would like to better understand where the breakdown is occurring.
…nsorg#4682) This makes startup errors in Mixer or NL servers more obvious. Bug: b/374820494 Reference: https://docs.docker.com/engine/containers/multi-service_container/#use-a-wrapper-script
goldens needed to be updated because of a bunch of recent data updates (data diffs can be seen here: datacommonsorg/mixer#1438, datacommonsorg/mixer#1439)
Also updates nl goldens
Use the `DATA_RUN_MODE` environment variable to decide what mode to pass to run_stats.sh and whether to build embeddings. The mode `schemaupdate` for run_stats.sh is added by datacommonsorg/import#344, which this PR updates the import submodule to include. A docsite page will describe how to pass in this environment variable: datacommonsorg/docsite#527
This PR modifies the scoring algorithm for place autocomplete to count a small score for non-exact matches, to account for one typo. With these changes, we will favor "San Diego" over "Dieppe" for the query "Sna Die". Prod: https://screenshot.googleplex.com/Bsx2BbyLZArbQuX Local with this change: https://screenshot.googleplex.com/9jHqKb2uHJLz37k Note that "Sne Die" will still go back to "Dieppe" because that's 2 typos, so San Diego is out even if it was returned by google Maps predictions: https://screenshot.googleplex.com/9LViJoVFni3Lui6 Typo check done as a bag of letters with at most off by one. We do this check on top of the Google Maps Predictions which already take into account typo correction. This part is just to choose the best prediction from google maps. Doing this as part of gaps identified in place autocomplete: https://docs.google.com/document/d/15RVckX9ck5eyyhBHW8Nb9lmxPBDPMIeLbax14HbN-GI/edit?tab=t.0
## Description This PR contains miscellaneous updates and improvements triggered from comments in an earlier PR: [4599](datacommonsorg#4599) It contains the following updates: * The TypeScript breakpoint object is standardized to defaults, and comments now reference the TypeScript and SCSS version so that they can be kept in sync with further changes. * The `Topics` component has been generalized into a `LinkChips` component, making it a more reusable content component. This update was triggered by the request to change the CSS class from "topics" (which was also done along with this larger change). We can generalize other content components in later PRs. * The directory for the SCSS files relating to content components is now renamed to make that structure more clear. * Updates to comments, copyright notices and the variable import file name.
## Description This PR implements improvements following an accessibility sweep of the home page, and includes the following fixes and improvements: * significant reworking of the carousel's tab handling; it now handles switching between slides by tab graciously regardless of the content. * addition of aria labels and corrections to existing aria labels. * the media text component can now take an optional alt prop in lieu of (or in addition to) the title, with at least one of them being required. * The headers in the rich menus are adjusted to better match the hierarchy. * tab outlines are fixed for the main menu. * Ids that could be duplicated have been removed. In the case of the search bar, we could not remove the id at this stage (because it is tied to downstream functionality) but we are now selectively rendering the mobile and desktop menu to prevent the duplicate id. To facilitate this selective rendering, we have added a breakpoints hook that allows us to apply Bootstrap-like media queries on the TypeScript side. This breakpoints hook may proof to be a generally useful utility. --------- Co-authored-by: Jennifer Blumberg <[email protected]> Co-authored-by: Pablo Noel <[email protected]>
Recently webdriver tests have sometimes failed due to NL server start up issues. This, I believe has to do with the fact that we use multiprocessing for webdriver tests & when we start up nl server, we only download the folder for a model if it's not already there. So one process may have started downloading the folder for a model & another process sees that the folder for the model is already there and attempts to use a file from the folder that hasn't completed downloading Here, I add another step in the webdriver cloudbuild to first download the model files before starting the webdriver tests Testing: - These changes do not trigger webdriver tests, so I added a print statement to trigger the tests on a previous commit & tests passed: https://pantheon.corp.google.com/cloud-build/builds;region=global/5ba92206-1df7-4dfc-9f79-7e7d04d595bf;step=2?e=13803378&inv=1&invt=AbgLkA&mods=-monitoring_api_staging&project=datcom-ci - This change also affects the nl_server docker image, so I tested building the image and pushing the image to dev and it seems to work.
This PR implements a hack to add autocomplete for continents. We always fake that Continents came back in the response from the Google Maps Predictions API response, and hardcode the Place ID to DCID. The Place IDs were fetched from here: https://developers.google.com/maps/documentation/places/web-service/place-id For one word continent, we just add a matching for the single word query. For two word continents (S|N America), we add matching for the single word query, and two word query if applicable. We then compute the match score, and remove all continents with positive scores (negative score means a better match). Note that we prepend the continents in order to give the continents an edge over other places that have the same score. I also added a boost to scoring if the query matches the response from the start in order to give "America" an edge over "North America" when typing "Ameri".
Identifies the environment based on the window.location.hostname parameter.
…nsorg#4694) Trigger a Google analytics Event whenever we trigger auto suggestions. This only gets triggered once per series of suggestions so as not to falsify the data. The aim of this event is to be compared with the number of times the autocomplete suggestions is accepted. That event already gets triggered.
…h' (datacommonsorg#4699) Adds World and Earth to the autocomplete. Refactors the continent hack into a "Custom places" hack where we no longer rely on the place ID intermediary.
## Description This PR completes a number of layout fixes and other improvements, mostly from the P1 (but also P2) list items: * Content aligns to the logo in small screens * Content aligns to the search bar on large screens, * Header height consistent between screen sizes * Overall spacing is consistent between screen sizes * Search bar is now fully flexible (as in the screen shots we sent), but the inside is now correctly aligned. * The inside of the mega-menu drop-down is now aligned to the logo always, and takes up the proper amount of space. * The mega-menu now correctly allows for the "secondary section" of the mega-menu if one is included (right now, none are). * Scroll bar fix * Missing rounded corners on pictures for the carousel * Clean up of the carousel section in the home screen * Overflow removed on scatter / map viz. * Page scroll not reset after window resize * Significant cleanup and improvements to the mobile menu to that it handles screen resizing more gracefully. --------- Co-authored-by: Pablo Noel <[email protected]>
datacommonsorg#4684 Changes in the PR above ended up breaking styling for autocomplete. See autopush: https://screenshot.googleplex.com/77CCATTzB2domBv I believe these 2 lines are the only ones needed to recover the autopush styling. Verified locally.
The height attribute has not been applied since datacommonsorg#4683 changed `#main-header-logo` to `.main-header-logo`.
…commonsorg#4698) Delete protection was preventing `terraform destroy` from running successfully
…tacommonsorg#4707) This came up because Kara is adding documentation about the nodejs/query endpoint & wanted clarification about some of the fields in the response. Thought this information could be useful to have here
…datacommonsorg#4708) This will be used to make sure no commits get merged into customdc_stable that aren't already in master.
hqpho
force-pushed
the
cdc
branch
3 times, most recently
from
cd6cdf6 to
6255004
Compare
As well as the the repo and branch of the PR. Third time's the charm! [Example run](https://github.com/datacommonsorg/website/actions/runs/11691607809/job/32559153338?pr=4710) successfully showing what commits were not in master on a PR opened against datacommonsorg/website/customdc_stable.
hqpho
changed the title
hqpho
changed the title
keyurva
approved these changes
Nov 6, 2024
Merged
via the queue into
datacommonsorg:customdc_stable
with commit Nov 6, 2024
8373289
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
transformersin nl_requirements.txt