Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Layout and Style fixes and cleanups #4684

Merged
merged 20 commits into from
Nov 2, 2024
Merged

Miscellaneous Layout and Style fixes and cleanups #4684

merged 20 commits into from
Nov 2, 2024

Conversation

nick-next
Copy link
Contributor

Description

This PR completes a number of layout fixes and other improvements, mostly from the P1 (but also P2) list items:

  • Content aligns to the logo in small screens
  • Content aligns to the search bar on large screens,
  • Header height consistent between screen sizes
  • Overall spacing is consistent between screen sizes
  • Search bar is now fully flexible (as in the screen shots we sent), but the inside is now correctly aligned.
  • The inside of the mega-menu drop-down is now aligned to the logo always, and takes up the proper amount of space.
  • The mega-menu now correctly allows for the "secondary section" of the mega-menu if one is included (right now, none are).
  • Scroll bar fix
  • Missing rounded corners on pictures for the carousel
  • Clean up of the carousel section in the home screen
  • Overflow removed on scatter / map viz.
  • Page scroll not reset after window resize
  • Significant cleanup and improvements to the mobile menu to that it handles screen resizing more gracefully.

@beets beets requested review from beets and dwnoble and removed request for beets October 22, 2024 04:08
dwnoble
dwnoble approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@dwnoble dwnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

As discussed offline-can you add the blank 4th column to the navbar dropdown for wide screen sizes?

@nick-next nick-next force-pushed the p1-cleanups branch 2 times, most recently from 1322c42 to 166e977 Compare October 31, 2024 05:21
pablonoel and others added 18 commits November 1, 2024 19:42
@pablonoel @nick-next
First batch
ef562ae 
- Fix Footer Alignment
- Add rounded corners to images in carousel
- Fix build your own component layout, space and font sizes
@pablonoel @nick-next
Improve how content menu should be aligned when small/medium/large br…
5cb7209 
…owser windows
@pablonoel @nick-next
Fixes Menu padding, add better column behaviour to mega-menu, and ali…
cdd551c 
…gn its content to header
@pablonoel @nick-next
Adjust responsive breakpoint for scatter / map viz so the start menu …
68d1c43 
…it doesn't overflow
@pablonoel @nick-next
Fix bug where mobile menu expand its boundaries when resized
c26fd58
@nick-next
Moved the mobile drawer scroll handling to the CSS, and applied a med…
3c8fd1d 
…ia query to selectively apply the scrollbar change to only mobile sizes.
@nick-next
We do not currently have secondary columns in the rich menu, but we d…
46f24da 
…o have the capacity to add them. This commit explicitly applies a class to the menu content in that case to provide more flexibility in styling the grid columns slightly differently in this case.
@nick-next
Fix to spacing on the visualization.scss and a minor nit fixed on the…
fd347cd 
… menu_mobile.
@nick-next
Reversion of the visualization file to the original formatting.
7888ab8
@pablonoel @nick-next
Remove scroll issue on scatter plot tool
20bacd5
@nick-next
Removed unused prop (the routes) from the footer and parent that also…
bc00e91 
… now no longer need it.
@nick-next
Resolution to Codacy analysis findings (except for the unexpected unk…
4c9da91 
…nown at-rule, which will require a Codacy plugin).
@pablonoel @nick-next
Menu: add 4 column to big screens
4acc046
@pablonoel @nick-next
refactor header, fix the max width for the menu to avoid FOUC
165b092
@pablonoel @nick-next
Remove MUI icon, replace with SVG
7e704e5
@nick-next
Minor formatting, prettification and linting in prep for merge.
ef0324f
@nick-next
Formatting page.
34ce321
@nick-next
Formatting update for Codacity.
ae6b8e1
@nick-next nick-next merged commit 6609086 into datacommonsorg:master Nov 2, 2024
8 checks passed
@gmechali gmechali mentioned this pull request Nov 4, 2024
Merged
gmechali added a commit that referenced this pull request Nov 4, 2024
@gmechali
Reintroduce css styling for search autocomplete (#4702)
8d8a700 
#4684

Changes in the PR above ended up breaking styling for autocomplete. See
autopush: https://screenshot.googleplex.com/77CCATTzB2domBv

I believe these 2 lines are the only ones needed to recover the autopush
styling. Verified locally.
@nick-next nick-next deleted the p1-cleanups branch November 14, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnoble dwnoble dwnoble approved these changes

@beets beets Awaiting requested review from beets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-next @dwnoble @pablonoel