Miscellaneous updates and improvements #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnoble
approved these changes
Oct 22, 2024
|
/gcbrun |
…onent. There was a comment that the use of a "topic" class in the CSS had potential for clashing. This is fixed, and that triggered the reworking of the component itself to make it more generic.
…ake it clear that these are specifically for components relating to content (articles, informational pages), as opposed to functional components such as topic explorer tools).
… a more thorough note.
…rce in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains miscellaneous updates and improvements triggered from comments in an earlier PR: 4599
It contains the following updates:
Topicscomponent has been generalized into aLinkChipscomponent, making it a more reusable content component. This update was triggered by the request to change the CSS class from "topics" (which was also done along with this larger change). We can generalize other content components in later PRs.