Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolution to Codacy analysis findings and fix to link source issue.
Browse files Browse the repository at this point in the history
nick-next committed Oct 24, 2024
1 parent ee9a608 commit d4cd993
Showing 3 changed files with 8 additions and 5 deletions.
2 changes: 2 additions & 0 deletions static/css/content/chips.scss
Original file line number Diff line number Diff line change
@@ -23,6 +23,7 @@
@include var.title_xs;
margin-bottom: calc(#{var.$spacing} * 3);
}

.chip-container {
margin: 0;
padding: 0;
@@ -34,6 +35,7 @@
max-width: 100%;
}
}

.chip-item {
display: block;
list-style: none;
4 changes: 2 additions & 2 deletions static/js/apps/homepage/app.tsx
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ import React, { ReactElement } from "react";

import Build from "../../components/content/build_your_own";
import HeroVideo from "../../components/content/hero_video";
import LinkChips, { LinkChip } from "../../components/content/link_chips";
import { LinkChip, LinkChips } from "../../components/content/link_chips";
import Partners from "../../components/content/partners";
import SampleQuestions from "../../components/content/sample_questions";
import Tools from "../../components/content/tools";
@@ -59,7 +59,7 @@ export function App({
const topicLinkChips: LinkChip[] = topics.map((topic) => ({
id: topic.id,
title: topic.title,
url: topic.url,
url: topic.browseUrl,
}));

return (
7 changes: 4 additions & 3 deletions static/js/components/content/link_chips.tsx
Original file line number Diff line number Diff line change
@@ -44,7 +44,10 @@ interface LinkChipsProps {
linkChips: LinkChip[];
}

const LinkChips = ({ title, linkChips }: LinkChipsProps): ReactElement => {
export const LinkChips = ({
title,
linkChips,
}: LinkChipsProps): ReactElement => {
return (
<section id="chip-section" className="chip-section">
<div className="container">
@@ -72,5 +75,3 @@ const LinkChips = ({ title, linkChips }: LinkChipsProps): ReactElement => {
</section>
);
};

export default LinkChips;

0 comments on commit d4cd993

Please sign in to comment.