Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data release #1438

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

hareesh-ms
Copy link
Contributor

No description provided.

@@ -219,11 +162,6 @@
}
},
"facets": {
"1042817753": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deletion for deprecated imports.

Copy link
Contributor

@beets beets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update. please keep an eye out on some of these changes when we do the website release @chejennifer @hareesh-ms

@@ -3049,6 +3049,9 @@
"Count_HousingUnit_2010To2014Date_OccupiedHousingUnit",
"Count_HousingUnit_2010To2014Date_OwnerOccupied",
"Count_HousingUnit_2010To2014Date_RenterOccupied",
"Count_HousingUnit_2010To2017Date_OccupiedHousingUnit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were there some census updates in this release too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was subject table(S2502) CL submission which got built in the last UScensus run.

@@ -6022,17 +6037,24 @@
"Count_Person_18OrMoreYears_Employed_InLaborForce_NoHealthInsurance",
"Count_Person_18OrMoreYears_Employed_InLaborForce_WithHealthInsurance",
"Count_Person_18OrMoreYears_Female",
"Count_Person_18OrMoreYears_FoodInsecurity_AsAFractionOf_Count_Person_18OrMoreYears",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this addition expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New variable as part of CDC500 import.

},
"metadata": {
"importName": "CDC500",
"provenanceUrl": "https://www.cdc.gov/places/index.html",
"measurementMethod": "AgeAdjustedPrevalence",
"observationPeriod": "P1Y"
"observationPeriod": "P1Y",
"scalingFactor": "100",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets verify that this results in the right chart render in the release

@chejennifer
Copy link
Contributor

thanks for the update. please keep an eye out on some of these changes when we do the website release @chejennifer @hareesh-ms

taking a look at the screenshot diffs, it looks like we've lost data for

is this expected?

@beets
Copy link
Contributor

beets commented Oct 17, 2024 via email

@chejennifer
Copy link
Contributor

chejennifer commented Oct 17, 2024

  • prod

oh, looks like the USA unemployment rate ones are also from eurostat deprecation, so probably expected then? (looks like the USA data comes from eurostat & AustraliaStatistics supplies Australia and Australian AA1 places, which do show up in prod)

@hareesh-ms hareesh-ms merged commit a5a1978 into datacommonsorg:master Oct 18, 2024
3 checks passed
chejennifer added a commit to datacommonsorg/website that referenced this pull request Oct 22, 2024
goldens needed to be updated because of a bunch of recent data updates
(data diffs can be seen here:
datacommonsorg/mixer#1438,
datacommonsorg/mixer#1439)
hqpho pushed a commit to hqpho/dc-website that referenced this pull request Oct 29, 2024
goldens needed to be updated because of a bunch of recent data updates
(data diffs can be seen here:
datacommonsorg/mixer#1438,
datacommonsorg/mixer#1439)
hqpho added a commit to hqpho/dc-website that referenced this pull request Oct 29, 2024
* update submodule for release (datacommonsorg#4681)

* update NL goldens after mixer push (datacommonsorg#4680)

* Adds logging for autocomplete responses. (datacommonsorg#4678)

Logs the response count for autocompletion. Staging is not showing any
responses. Would like to better understand where the breakdown is
occurring.

* Exit cdc_services/run.sh when any background process exits (datacommonsorg#4682)

This makes startup errors in Mixer or NL servers more obvious.

Bug: b/374820494
Reference:
https://docs.docker.com/engine/containers/multi-service_container/#use-a-wrapper-script

* update nodejs goldens (datacommonsorg#4685)

goldens needed to be updated because of a bunch of recent data updates
(data diffs can be seen here:
datacommonsorg/mixer#1438,
datacommonsorg/mixer#1439)

* Update submodules (datacommonsorg#4688)

* Pin transformers to 4.45.2 (datacommonsorg#4689)

Also updates nl goldens

* Support schema update mode for data docker (datacommonsorg#4686)

Use the `DATA_RUN_MODE` environment variable to decide what mode to pass
to run_stats.sh and whether to build embeddings. The mode `schemaupdate`
for run_stats.sh is added by
datacommonsorg/import#344, which this PR updates
the import submodule to include.

A docsite page will describe how to pass in this environment variable:
datacommonsorg/docsite#527

* Improves Typo recognition for autocomplete (datacommonsorg#4690)

This PR modifies the scoring algorithm for place autocomplete to count a
small score for non-exact matches, to account for one typo.
With these changes, we will favor "San Diego" over "Dieppe" for the
query "Sna Die".
Prod: https://screenshot.googleplex.com/Bsx2BbyLZArbQuX
Local with this change:
https://screenshot.googleplex.com/9jHqKb2uHJLz37k

Note that "Sne Die" will still go back to "Dieppe" because that's 2
typos, so San Diego is out even if it was returned by google Maps
predictions: https://screenshot.googleplex.com/9LViJoVFni3Lui6

Typo check done as a bag of letters with at most off by one. We do this
check on top of the Google Maps Predictions which already take into
account typo correction. This part is just to choose the best prediction
from google maps.

Doing this as part of gaps identified in place autocomplete:
https://docs.google.com/document/d/15RVckX9ck5eyyhBHW8Nb9lmxPBDPMIeLbax14HbN-GI/edit?tab=t.0

---------

Co-authored-by: chejennifer <[email protected]>
Co-authored-by: Gabriel Mechali <[email protected]>
Co-authored-by: natalie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants