Adds Continents to AutoComplete #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a hack to add autocomplete for continents. We always fake that Continents came back in the response from the Google Maps Predictions API response, and hardcode the Place ID to DCID.
The Place IDs were fetched from here: https://developers.google.com/maps/documentation/places/web-service/place-id
For one word continent, we just add a matching for the single word query.
For two word continents (S|N America), we add matching for the single word query, and two word query if applicable.
We then compute the match score, and remove all continents with positive scores (negative score means a better match).
Note that we prepend the continents in order to give the continents an edge over other places that have the same score.
I also added a boost to scoring if the query matches the response from the start in order to give "America" an edge over "North America" when typing "Ameri".