Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaia v6.0.0-rc2 #979

Merged
merged 24 commits into from
Nov 4, 2021
Merged

gaia v6.0.0-rc2 #979

merged 24 commits into from
Nov 4, 2021

Conversation

yaruwangway
Copy link
Contributor

@yaruwangway yaruwangway commented Sep 20, 2021

Closes: #969 #991

Description

This PR is for releasing gaia v6.0.0-rc2. The following changes are included:


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #979 (e70b55c) into main (913c020) will increase coverage by 1.63%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   10.44%   12.08%   +1.63%     
==========================================
  Files          11        9       -2     
  Lines        1082      927     -155     
==========================================
- Hits          113      112       -1     
+ Misses        964      810     -154     
  Partials        5        5              

This was linked to issues Sep 20, 2021
@yaruwangway yaruwangway requested a review from okwme September 20, 2021 14:53
@okwme
Copy link
Contributor

okwme commented Sep 27, 2021

why are all of these other replace lines necessary now?

@jaybxyz
Copy link
Contributor

jaybxyz commented Sep 30, 2021

@yaruwangway Quick question here. Is there a plan to upgrade Cosmos SDK to v0.44.1? If so, we are going to have to bump up the SDK version in liquidity module and release a new version.

@yaruwangway
Copy link
Contributor Author

@yaruwangway Quick question here. Is there a plan to upgrade Cosmos SDK to v0.44.1? If so, we are going to have to bump up the SDK version in liquidity module and release a new version.

Hi @kogisin yes, we bumped to 0.44.1 (sorry for the late reply). v0.44.0 is not safe to use when performing v0.42->v0.44 in-place store upgrades in vega upgrade.

Copy link
Contributor

@okwme okwme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving on behalf of @jackzampolin 👍

@okwme okwme merged commit f5ee472 into main Nov 4, 2021
@okwme okwme deleted the vega-rc2 branch November 4, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Legacy Migration Code support upgrade to tendermint 0.35
5 participants