Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testnet cli command update genesis supply #991

Closed
wants to merge 1 commit into from

Conversation

yaruwangway
Copy link
Contributor

Closes: #879

Description

fix the testnet cli command update genesis supply
more details: cosmos/cosmos-sdk#9497


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release/v5.0.6@8defbe0). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release/v5.0.6     #991   +/-   ##
=================================================
  Coverage                  ?   11.99%           
=================================================
  Files                     ?       10           
  Lines                     ?      934           
  Branches                  ?        0           
=================================================
  Hits                      ?      112           
  Misses                    ?      817           
  Partials                  ?        5           

@colin-axner
Copy link
Contributor

should this go in the main branch first (then be backported to release branch)?

@yaruwangway
Copy link
Contributor Author

should this go in the main branch first (then be backported to release branch)?

Hi Colin, we will do a backport for release v5.0.7 which will use cosmos-sdk 0.42.10, I will include the testnet fix there as well. So I will close this pull request.

@yaruwangway yaruwangway mentioned this pull request Oct 1, 2021
16 tasks
@yaruwangway yaruwangway deleted the fix-testnet branch November 3, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants