-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add router module to Vega upgrade #983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jack, it is great that we can include router module to gaia vega-rc2 release!
Please confirm if the following code change need to be added:
- add
routertypes.ModuleName
inapp.mm.SetOrderBeginBlockers
andapp.mm.SetOrderInitGenesis
- add
fromVM[routertypes.ModuleName] = 0
if the router module do not want to skip init genesis. like this:Line 565 in 06d6f8f
fromVM[authz.ModuleName] = 0 - add the router module store in the store upgrade. like here:
Line 579 in 06d6f8f
Added: []string{authz.ModuleName, feegrant.ModuleName},
@@ -99,6 +99,10 @@ import ( | |||
dbm "github.com/tendermint/tm-db" | |||
|
|||
gaiaappparams "github.com/cosmos/gaia/v6/app/params" | |||
router "github.com/strangelove-ventures/packet-forward-middleware/router" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to write "router" if the alias is the same name as the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to go into main
then backported into the release branch. Otherwise, LGTM.
Ok so this is good, but I just want to make sure to test the e2e with this build. Should have this done by eow |
Will rebase against |
this work was cherry-picked by @yaruwangway and added to the |
No description provided.