fix: panic on export zero-height because variable-length addresses #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1014
Description
Panic occurs when
gaia export --for-zero-height
gaia/app/export.go
Line 160 in 56db57c
because of current
prepForZeroHeightGenesis
function usingaddr := sdk.ValAddress(iter.Key()[1:])
to casting variable-length addresses,It should be
addr := sdk.ValAddress(stakingtypes.AddressFromValidatorsKey(iter.Key()))
to cover addresses of length > 20 bytes ADR-028For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)