roachtest/awsdms: add no pk full load test case #95518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremyyang920
requested review from
herkolategan and
smg260
and removed request for
a team
|
This change is |
This commit adds a new test case that will attempt a full load on a table with no primary key. We will assert that there is a table error with the full load. Fixes: cockroachdb#95328 Release note: None
Jeremyyang920
force-pushed
the
add_dms_no_pk_test
branch
from
1db8c58 to
1d59169
Compare
otan
approved these changes
Jan 19, 2023
|
bors r+ |
|
Build succeeded: |
Jeremyyang920
added a commit
to Jeremyyang920/cockroach
that referenced
this pull request
Jan 26, 2023
In cockroachdb#95518, we added a new test case to check for a table error during the DMS process. However there is a race when the check happens depending on how quickly tasks have ran and the task ReplicationTaskStats can be nil and we tried to access field on the nil object that was returned from the API call. This commit checks that the ReplicationTaskStat is not nil before accessing the TablesErrored property. Fixes: cockroachdb#93305 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
95839: colinfo: add missing type families into CanHaveCompositeKeyEncoding r=yuzefovich a=yuzefovich This commit adds several missing type families into `CanHaveCompositeKeyEncoding` method. Some of these type families are internal and, probably, don't need to be handled, but we recently introduced TSVector and TSQuery types which were incorrectly marked as being composite since they were not mentioned explicitly in the type family switch. This commit also makes it so that we panic in this method if we forget to include a newly-introduced type into this switch. Fixes: #95680. Release note: None 95900: ui: add check for cpu usage r=maryliag a=maryliag Add a check, for cases when the value might no be returned (cluster with mixed versions). Part Of #87213 Release note: None 96005: colfetcher: disable direct columnar scans for now r=yuzefovich a=yuzefovich This commit disables direct columnar scans which are now randomly enabled in tests due to this feature having a data race at the moment. Informs: #95937. Release note: None 96008: roachtest/awsdms: fix race condition that can cause panics r=otan a=Jeremyyang920 In #95518, we added a new test case to check for a table error during the DMS process. However there is a race when the check happens depending on how quickly tasks have ran and the task ReplicationTaskStats can be nil and we tried to access field on the nil object that was returned from the API call. This commit checks that the ReplicationTaskStat is not nil before accessing the TablesErrored property. Fixes: #93305 Release note: None 96009: binfetcher: fix binary downloading for arm64 MacOS r=rail a=andyyang890 This patch updates the suffix used to fetch arm64 MacOS binaries to match the naming scheme used to build releases. Epic: None Release note: None 96020: roachtest: use teardown log when creating GitHub issue r=herkolategan a=renatolabs This is a follow up of #95831. The logger passed to the `githubIssues` struct writes to the test runner logger, which is not ideal. This changes the logger passed to use the `teardown` logger, so log entries related to GitHub issue creation are in the same directory as the failing test itself. Epic: None Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: maryliag <[email protected]> Co-authored-by: Jeremy Yang <[email protected]> Co-authored-by: Andy Yang <[email protected]> Co-authored-by: Renato Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new test case that will attempt a full load on a table with no primary key. We will
assert that there is a table error with the full
load.
Fixes: #95328
Release note: None