roachtest: use teardown log when creating GitHub issue #96020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up of cockroachdb#95831. The logger passed to the `githubIssues` struct writes to the test runner logger, which is not ideal. This changes the logger passed to use the `teardown` logger, so log entries related to GitHub issue creation are in the same directory as the failing test itself. Release note: None
renatolabs
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
herkolategan
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Changes look good to me; you can add Epic: None to the commit message to silence blathers.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @srosenberg)
Ah yes, I forgot about that. Updated. TFTR! bors r=herkolategan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #95831. The logger passed to the
githubIssuesstruct writes to the test runner logger, which is not ideal. This
changes the logger passed to use the
teardownlogger, so log entriesrelated to GitHub issue creation are in the same directory as the
failing test itself.
Epic: None
Release note: None