Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #95680

Closed
cockroach-teamcity opened this issue Jan 23, 2023 · 3 comments · Fixed by #95839
Closed

roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #95680

cockroach-teamcity opened this issue Jan 23, 2023 · 3 comments · Fixed by #95839
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 23, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.unoptimized-query-oracle/disable-rules=all/rand-tables failed with artifacts on master @ b21379bb56dd206e6f63cc7d07ca72e85db7a4c4:

test artifacts and logs in: /artifacts/unoptimized-query-oracle/disable-rules=all/rand-tables/run_1
(query_comparison_util.go:251).runOneRoundQueryComparison: failed to set random seed. 3826 statements run: dial tcp 34.139.37.1:26257: connect: connection refused

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-23673
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jan 23, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jan 23, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jan 23, 2023
@msirek msirek self-assigned this Jan 24, 2023
@msirek msirek removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jan 24, 2023
msirek pushed a commit to msirek/cockroach that referenced this issue Jan 24, 2023
tests: fix fatal errors from timeout-out statements in queryCompariso…
d65c8af 
…nTests

Fixes cockroachdb#95680

Roachtests such as tlp, costfuzz or unoptimized-query-oracle may time
out helper statements such as `SET testing_optimizer_random_seed = xxx`
and misinterpret the error as a fatal error, causing an issue to be
opened.

This fixes the problem by not erroring out the test if the test or round
timeout has expired. An alternative fix could have been to avoid
throwing errors for SET statements, with the idea that such errors are
likely rare. The current fix was chosen so that we still might catch
such errors if they were to occur.

Release note: None
@msirek
Copy link
Contributor

msirek commented Jan 24, 2023

cockroach-sql-exec.log shows a SQL statement caused a panic:

E230123 15:14:00.100120 1278 9@sql/conn_executor.go:1064 â‹® [T1,n1,client=35.199.4.83:42446,user=root] 1  a SQL panic has occurred while executing the following statement:
E230123 15:14:00.100120 1278 9@sql/conn_executor.go:1064 ⋮ [T1,n1,client=35.199.4.83:42446,user=root] 1 +‹INSERT INTO defaultdb.public.table4 AS tab114(col4_0, col4_2, col4_3, col4_6, col4_7, col4_8, col4_9, col4_10, col4_11, col4_12, col4_13, col4_14) VALUES ('307a4ae7-eaa9-4ecd-81ae-19680bc17484':::UUID, 0:::OID, '-4713-11-24 00:00:00+00:00':::TIMESTAMPTZ, 0:::OID, '50 years 10 mons 73 days 13:32:16.108884':::INTERVAL, '00:01:40.01+00:00:00':::TIMETZ, '2024-10-04':::DATE, true, 1670532010431263747:::INT8, B'1110011111010010010010110011', '+Inf':::FLOAT8, e'\'FKdgjFTYs\' \'QcGQflzbz\' \'RBbcU\':224B,886C \'SZvlKr\':519B \'i\':480C,725A \'kCrLZNl\' \'sVDj\' \'yO\' \'z\':54C,440B,519C,794B':::TSVECTOR)›

@msirek
Copy link
Contributor

msirek commented Jan 24, 2023

Repro:

CREATE TABLE table4 (col4_13 FLOAT4 NOT NULL, col4_14 TSVECTOR NOT NULL, INVERTED INDEX (col4_13 ASC, col4_14 ASC));
INSERT INTO defaultdb.public.table4 AS tab114(col4_13, col4_14) VALUES ('+Inf':::FLOAT8, e'\'FKdgjFTYs\' \'QcGQflzbz\' \'RBbcU\':224B,886C \'SZvlKr\':519B \'i\':480C,725A \'kCrLZNl\' \'sVDj\' \'yO\' \'z\':54C,440B,519C,794B':::TSVECTOR);

ERROR: internal error: unexpected error from the vectorized engine: interface conversion: *tree.DTSVector is not tree.CompositeDatum: missing method IsComposite
SQLSTATE: XX000
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:89: func1()
GOROOT/src/runtime/panic.go:884: gopanic()
GOROOT/src/runtime/iface.go:92: getitab()
GOROOT/src/runtime/iface.go:429: assertI2I()
github.com/cockroachdb/cockroach/pkg/sql/rowenc/index_encoding.go:1450: writeColumnValues()
github.com/cockroachdb/cockroach/pkg/sql/rowenc/index_encoding.go:1433: encodeSecondaryIndexNoFamilies()
github.com/cockroachdb/cockroach/pkg/sql/rowenc/index_encoding.go:1253: EncodeSecondaryIndex()
github.com/cockroachdb/cockroach/pkg/sql/row/helper.go:221: encodeSecondaryIndexes()
github.com/cockroachdb/cockroach/pkg/sql/row/helper.go:166: encodeIndexes()
github.com/cockroachdb/cockroach/pkg/sql/row/inserter.go:153: InsertRow()
github.com/cockroachdb/cockroach/pkg/sql/tablewriter_insert.go:47: row()
github.com/cockroachdb/cockroach/pkg/sql/insert.go:160: processSourceRow()
github.com/cockroachdb/cockroach/pkg/sql/insert_fast_path.go:293: BatchedNext()
github.com/cockroachdb/cockroach/pkg/sql/plan_batch.go:173: startExec()
github.com/cockroachdb/cockroach/pkg/sql/plan.go:524: func2()
github.com/cockroachdb/cockroach/pkg/sql/walk.go:112: func1()
github.com/cockroachdb/cockroach/pkg/sql/walk.go:297: visitInternal()
github.com/cockroachdb/cockroach/pkg/sql/walk.go:79: visit()
github.com/cockroachdb/cockroach/pkg/sql/walk.go:43: walkPlan()
github.com/cockroachdb/cockroach/pkg/sql/plan.go:527: startExec()
github.com/cockroachdb/cockroach/pkg/sql/plan_node_to_row_source.go:173: Start()
github.com/cockroachdb/cockroach/pkg/sql/colexec/columnarizer.go:187: Init()
github.com/cockroachdb/cockroach/pkg/sql/colflow/stats.go:94: init()
github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92: CatchVectorizedRuntimeError()
github.com/cockroachdb/cockroach/pkg/sql/colflow/stats.go:103: Init()
github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:247: func1()
github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92: CatchVectorizedRuntimeError()
github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:246: init()
github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:286: Run()
github.com/cockroachdb/cockroach/pkg/sql/colflow/vectorized_flow.go:309: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:857: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1793: PlanAndRun()

@msirek msirek removed their assignment Jan 24, 2023
@msirek msirek mentioned this issue Jan 24, 2023
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.unoptimized-query-oracle/disable-rules=all/rand-tables failed with artifacts on master @ 6eabc2f348710f4146ff984bc346cd8cbe96f83b:

test artifacts and logs in: /artifacts/unoptimized-query-oracle/disable-rules=all/rand-tables/run_1
(query_comparison_util.go:251).runOneRoundQueryComparison: failed to set random seed. 1076 statements run: dial tcp 34.148.145.83:26257: connect: connection refused

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@mgartner mgartner mentioned this issue Jan 25, 2023
Closed
@yuzefovich yuzefovich self-assigned this Jan 25, 2023
@yuzefovich yuzefovich mentioned this issue Jan 25, 2023
Merged
@msirek msirek mentioned this issue Jan 25, 2023
Closed
@craig craig bot closed this as completed in 32b5345 Jan 26, 2023
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

colinfo: add missing type families into CanHaveCompositeKeyEncoding yuzefovich/cockroach
3 participants
@msirek @yuzefovich @cockroach-teamcity