Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binfetcher: fix binary downloading for arm64 MacOS #96009

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

andyyang890
Copy link
Collaborator

This patch updates the suffix used to fetch arm64 MacOS binaries
to match the naming scheme used to build releases.

Epic: None

Release note: None

This patch updates the suffix used to fetch arm64 MacOS binaries
to match the naming scheme used to build releases.

Release note: None
@andyyang890 andyyang890 requested review from rail and a team January 26, 2023 17:05
@blathers-crl
Copy link

blathers-crl bot commented Jan 26, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Jan 26, 2023

Build succeeded:

@craig craig bot merged commit 32b5345 into cockroachdb:master Jan 26, 2023
@andyyang890 andyyang890 deleted the binfetcher_arm64 branch January 26, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants