sql: data race introduced in #94438 #95937
Assignees
Labels
A-sql-execution
Relating to SQL execution.
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
regression
Regression from a release.
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
Comments
cockroach-teamcity
added
branch-master
blathers-crl
bot
added
the
T-sql-foundations
knz
added
regression
knz
added
A-telemetry
and removed
T-sql-foundations
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
knz
added
A-sql-execution
|
cc @yuzefovich there's a data race in distsql physical planning |
|
Another one here #95916 |
|
Another one here #95917 |
This was referenced Jan 26, 2023
This was referenced Jan 26, 2023
craig bot
pushed a commit
that referenced
this issue
Jan 26, 2023
95839: colinfo: add missing type families into CanHaveCompositeKeyEncoding r=yuzefovich a=yuzefovich This commit adds several missing type families into `CanHaveCompositeKeyEncoding` method. Some of these type families are internal and, probably, don't need to be handled, but we recently introduced TSVector and TSQuery types which were incorrectly marked as being composite since they were not mentioned explicitly in the type family switch. This commit also makes it so that we panic in this method if we forget to include a newly-introduced type into this switch. Fixes: #95680. Release note: None 95900: ui: add check for cpu usage r=maryliag a=maryliag Add a check, for cases when the value might no be returned (cluster with mixed versions). Part Of #87213 Release note: None 96005: colfetcher: disable direct columnar scans for now r=yuzefovich a=yuzefovich This commit disables direct columnar scans which are now randomly enabled in tests due to this feature having a data race at the moment. Informs: #95937. Release note: None 96008: roachtest/awsdms: fix race condition that can cause panics r=otan a=Jeremyyang920 In #95518, we added a new test case to check for a table error during the DMS process. However there is a race when the check happens depending on how quickly tasks have ran and the task ReplicationTaskStats can be nil and we tried to access field on the nil object that was returned from the API call. This commit checks that the ReplicationTaskStat is not nil before accessing the TablesErrored property. Fixes: #93305 Release note: None 96009: binfetcher: fix binary downloading for arm64 MacOS r=rail a=andyyang890 This patch updates the suffix used to fetch arm64 MacOS binaries to match the naming scheme used to build releases. Epic: None Release note: None 96020: roachtest: use teardown log when creating GitHub issue r=herkolategan a=renatolabs This is a follow up of #95831. The logger passed to the `githubIssues` struct writes to the test runner logger, which is not ideal. This changes the logger passed to use the `teardown` logger, so log entries related to GitHub issue creation are in the same directory as the failing test itself. Epic: None Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: maryliag <[email protected]> Co-authored-by: Jeremy Yang <[email protected]> Co-authored-by: Andy Yang <[email protected]> Co-authored-by: Renato Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cli/clisqlshell.Example_sql_config failed with artifacts on master @ 2ad8df3df3272110705984efc32f1453631ce602:
Parameters:
TAGS=bazel,gss,raceHelp
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-23834
The text was updated successfully, but these errors were encountered: