release-2.1: backport all of the acceptance -> roachtest changes #29589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust how we retrieve the gossip connectivity map to fix a corner case when crdb_internal.gossip_network is empty. Fix the gossipOK check to include the last node in the cluster. The effect is that the test could have been spuriously passing when it should have failed. Fixes cockroachdb#29326 Release note: None
Move the build-info acceptance test to a new acceptance/build-info roachtest. Move the existing cli/node-status to acceptance/cli/node-status. The acceptance roachtests are all going to share the same cluster to amortize the cluster setup/teardown time. Fun fact: the acceptance/build-info roachtest is about twice as fast as the old build-info acceptance test. See cockroachdb#29151 Release note: None
Move the event-log acceptance test to an acceptance/event-log roachtest. Release note: None
Move the cluster-recovery and node-restart acceptance tests to
acceptance/bank/{cluster-recovery,node-restart} roachtests.
See cockroachdb#29151
Release note: None
Release note: None
Create a global context that all test contexts are derived from. When an interrupt signal is received this global context is cancelled which propagates cancellation to all of the test contexts. Release note: None
For some reason I thought the local cluster size for the legacy acceptance tests was 3. It is actually 4, so we should use 4 for the roachtest-based acceptance tests. Release note: None
Move the status-server acceptance test to a new acceptance/status-server roachtest. See cockroachdb#29151 Release note: None
Move the rapid-restart acceptance test to a new acceptance/rapid-restart roachtest. See cockroachdb#29151 Release note: None
Centralize wiping of the cluster before running acceptance tests. For tests which share a cluster, we need to wipe the old state before putting new binaries. Fixes cockroachdb#29458 Release note: None
Release note: None
Move the gossip-peerings and gossip-restart acceptance tests to new
acceptance/gossip/{peerings,restart} roachtests.
See cockroachdb#29151
Release note: None
Move the gossip-restart-first-node-needs-incoming acceptance test to a new acceptance/gossip/restart-node-one roachtest. See cockroachdb#29151 Fixes cockroachdb#29115 Release note: None
Release note: None
…sters Release note: None
Release note: None
Move the version-upgrade acceptance test to a new acceptance/version-upgrade roachtest. See cockroachdb#29151 Release note: None
Use a retry loop for retrieving status details right after node startup as we might be talking to the node before it is responding to the status endpoint. Release note: None
No need to run a versionStep for the base version as we manually do that before executing the version steps. Duplicating this work was failing on the second upload because we can't overwrite the executable for a running binary. Fixes cockroachdb#29542 Release note: None
Move the decommission acceptance test to a new acceptance/decommission roachtest. Fixes cockroachdb#29151 Release note: None
When deleting a go test it was possible to add a package with an empty name. This in turn would cause CI failure as the top-level cockroach package contains no Go sources. Release note: None
Move the init-mode acceptance tests to a new acceptance/cluster-init roachtest. Fixes a TODO about sending the "init" command to nodes other than node 1. This was previously a limitation due to the --join flag settings. Fixes cockroachdb#29489 Release note: None
Reduce the max idle time to speed up evacuation of node 1 for this test. Release note: None
The test was using the local binary path for running CLI commands, which works on local clusters but not on remote ones. Fixes cockroachdb#29570 Release note: None
|
This change is |
|
LGTM and thanks! (don't forget: green button) |
|
Hmm, another CI problem with |
benesch
approved these changes
Sep 5, 2018
|
Hmm, |
|
I lied, no it isn't. It sees |
Release note: None
|
@benesch I added another commit here which I think fixes the |
Yep, definitely fixes the problem. |
petermattis
deleted the
backport2.1-29345-29437-29449-29465-29470-29492-29544-29488-29493-29576
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release