roachtest: add acceptance/bank/{cluster-recovery,node-restart} #29449
Conversation
Move the cluster-recovery and node-restart acceptance tests to
acceptance/bank/{cluster-recovery,node-restart} roachtests.
See cockroachdb#29151
Release note: None
Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/cmd/roachtest/bank.go, line 14 at r3 (raw file):
// implied. See the License for the specific language governing // permissions and limitations under the License. See the AUTHORS file // for names of contributors.
I copied pasted this from another file. We should probably remove the See the AUTHORS file line everywhere because we don't have one.
There was a problem hiding this comment.
I tried to keep the first commit minimal (though I failed slightly).
Reviewable status:
petermattis
force-pushed
the
pmattis/roachtest-bank
branch
from
e1ce113 to
0867544
Compare
Create a global context that all test contexts are derived from. When an interrupt signal is received this global context is cancelled which propagates cancellation to all of the test contexts. Release note: None
petermattis
force-pushed
the
pmattis/roachtest-bank
branch
from
0867544 to
8624547
Compare
For some reason I thought the local cluster size for the legacy acceptance tests was 3. It is actually 4, so we should use 4 for the roachtest-based acceptance tests. Release note: None
Move the status-server acceptance test to a new acceptance/status-server roachtest. See cockroachdb#29151 Release note: None
Move the rapid-restart acceptance test to a new acceptance/rapid-restart roachtest. See cockroachdb#29151 Release note: None
There was a problem hiding this comment.
This is exciting cleanup!
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 3 of 3 files at r4, 1 of 1 files at r5, 3 of 3 files at r6, 4 of 4 files at r7.
Reviewable status:
pkg/cmd/roachtest/acceptance.go, line 23 at r5 (raw file):
spec := testSpec{ Name: "acceptance", Nodes: nodes(4),
Ooh, nice catch.
pkg/cmd/roachtest/bank.go, line 14 at r3 (raw file):
Previously, petermattis (Peter Mattis) wrote…
I copied pasted this from another file. We should probably remove the
See the AUTHORS fileline everywhere because we don't have one.
Yeah, only 109 of the files have this extra sentence, out of 1870 total that use the Apache license. How odd. This is like a disease that is spreading through our license headers.
There was a problem hiding this comment.
TFTR! I should be able to finish the rest in another few hours. As predicted, this is mostly mechanical work.
Reviewable status:
pkg/cmd/roachtest/acceptance.go, line 23 at r5 (raw file):
Previously, benesch (Nikhil Benesch) wrote…
Ooh, nice catch.
Yeah, well one of the "local" acceptance tests I haven't got to requires 4 nodes which made this sort of obvious at that point.
pkg/cmd/roachtest/bank.go, line 14 at r3 (raw file):
Previously, benesch (Nikhil Benesch) wrote…
Yeah, only 109 of the files have this extra sentence, out of 1870 total that use the Apache license. How odd. This is like a disease that is spreading through our license headers.
I'll do this in a follow-on PR. Maybe further into the 2.2 cycle.
Centralize wiping of the cluster before running acceptance tests. For tests which share a cluster, we need to wipe the old state before putting new binaries. Fixes cockroachdb#29458 Release note: None
petermattis
force-pushed
the
pmattis/roachtest-bank
branch
from
16efd3e to
86ade65
Compare
|
bors r=benesch |
Build failed |
|
bors r=benesch |
29449: roachtest: add acceptance/bank/{cluster-recovery,node-restart} r=benesch a=petermattis
Move the cluster-recovery and node-restart acceptance tests to
acceptance/bank/{cluster-recovery,node-restart} roachtests.
See #29151
Release note: None
Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Move the cluster-recovery and node-restart acceptance tests to
acceptance/bank/{cluster-recovery,node-restart} roachtests.
See #29151
Release note: None