roachtest: add acceptance/gossip/* #29465
Conversation
|
This change is |
|
The first 7 commits are #29449. |
Release note: None
Move the gossip-peerings and gossip-restart acceptance tests to new
acceptance/gossip/{peerings,restart} roachtests.
See cockroachdb#29151
Release note: None
Move the gossip-restart-first-node-needs-incoming acceptance test to a new acceptance/gossip/restart-node-one roachtest. See cockroachdb#29151 Fixes cockroachdb#29115 Release note: None
Release note: None
…sters Release note: None
Release note: None
petermattis
force-pushed
the
pmattis/roachtest-gossip
branch
from
edaf2d0 to
f65fcf9
Compare
|
@benesch The last commit fixes a deterministic failure in |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
Nope, definitely don't bother pulling that out! I'll bors this right up. OOC how did you manage to land that breaking change in the first place? bors r+ |
We don't appear to run these tests in CI until after they are merged to master. Seems like the bors CI run should run them as well. |
|
Oh, that is problematic. Changed it so that they're run on everything: PRs,
bors runs, and merge to master.
…On Sat, Sep 1, 2018 at 4:52 PM, Peter Mattis ***@***.***> wrote:
Nope, definitely don't bother pulling that out! I'll bors this right up.
OOC how did you manage to land that breaking change in the first place?
We don't appear to run these tests in CI until after they are merged to
master. Seems like the bors CI run should run them as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29465 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA15ILQNAatl0Ef52Icxng9gs-R1xxY_ks5uWvOMgaJpZM4WWQKi>
.
|
29324: storage: fix a nasty merge deadlock r=tschottdorf,nvanbenschoten a=benesch Fix a nasty edge case which could cause a concurrent merge and split to deadlock. See the comment on TestStoreRangeMergeConcurrentSplit for details. Release note: None 29465: roachtest: add acceptance/gossip/* r=benesch a=petermattis Move the gossip acceptance tests to roachtests. See #29151 Fixes #29115 Co-authored-by: Nikhil Benesch <[email protected]> Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Move the gossip acceptance tests to roachtests.
See #29151
Fixes #29115