roachtest: fix acceptance/version-upgrade on remote clusters #29544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to run a versionStep for the base version as we manually do that before executing the version steps. Duplicating this work was failing on the second upload because we can't overwrite the executable for a running binary. Fixes cockroachdb#29542 Release note: None
|
This change is |
tbg
approved these changes
Sep 4, 2018
|
bors r=tschottdorf |
craig bot
pushed a commit
that referenced
this pull request
Sep 4, 2018
29520: sql: fix a panic in txn_state.go when verbose logging r=andreimatei,knz a=arjunravinarayan Fix a panic (reproducible with `make testlogic TESTFLAGS='-verbosity=2' FILES=pg_catalog` ) due to an uninitialized context. The comment on Ctx says that Ctx is uninitialized if we are in `fsm.stateNoTxn`. In that case, use the parent (session) context which is always initialized. First commit is just some type assertions that I found useful to understand what's going on. Fixes #29384. 29544: roachtest: fix acceptance/version-upgrade on remote clusters r=tschottdorf a=petermattis No need to run a versionStep for the base version as we manually do that before executing the version steps. Duplicating this work was failing on the second upload because we can't overwrite the executable for a running binary. Fixes #29542 Release note: None Co-authored-by: Arjun Narayan <[email protected]> Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to run a versionStep for the base version as we manually do that
before executing the version steps. Duplicating this work was failing on
the second upload because we can't overwrite the executable for a
running binary.
Fixes #29542
Release note: None