Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: acceptance/version-upgrade failed on release-2.1 #29542

Closed
cockroach-teamcity opened this issue Sep 4, 2018 · 1 comment
Closed

roachtest: acceptance/version-upgrade failed on release-2.1 #29542

cockroach-teamcity opened this issue Sep 4, 2018 · 1 comment
Assignees
@petermattis
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
2.1

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/def23eda0df4250b0113997bc223103a43508179

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stressrace instead of stress and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stress TESTS=acceptance/version-upgrade PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-stderr=false -maxtime 20m -timeout 10m'

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=882125&tab=buildLog

	test.go:498,cluster.go:748,upgrade.go:311,upgrade.go:343,upgrade.go:553,acceptance.go:57: /home/agent/work/.go/bin/roachprod put teamcity-882125-acceptance:1-3 /home/agent/temp/buildTmp/cockroach-v1.0.6.linux-amd64 ./cockroach-v1.0.6 returned:
		stderr:
		
		stdout:
		teamcity-882125-acceptance: putting (dist) /home/agent/temp/buildTmp/cockroach-v1.0.6.linux-amd64 ./cockroach-v1.0.6
		..
		   1: ~ scp -r -C -i /root/.ssh/google_compute_engine -o StrictHostKeyChecking=no /home/agent/temp/buildTmp/cockroach-v1.0.6.linux-amd64 [email protected]:./cockroach-v1.0.6
		scp: ./cockroach-v1.0.6: Text file busy
		: exit status 1
		   2: ~ scp -r -C -i /root/.ssh/google_compute_engine -o StrictHostKeyChecking=no /home/agent/temp/buildTmp/cockroach-v1.0.6.linux-amd64 [email protected]:./cockroach-v1.0.6
		scp: ./cockroach-v1.0.6: Text file busy
		: exit status 1
		   3: ~ scp -r -C -i /root/.ssh/google_compute_engine -o StrictHostKeyChecking=no /home/agent/temp/buildTmp/cockroach-v1.0.6.linux-amd64 [email protected]:./cockroach-v1.0.6
		scp: ./cockroach-v1.0.6: Text file busy
		: exit status 1
		2018/09/04 18:50:08 put /home/agent/temp/buildTmp/cockroach-v1.0.6.linux-amd64 failed
		: exit status 1
@cockroach-teamcity cockroach-teamcity added this to the 2.2 milestone Sep 4, 2018
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Sep 4, 2018
@petermattis petermattis modified the milestones: 2.2, 2.1 Sep 4, 2018
@petermattis
Copy link
Collaborator

Doh! I'm trying to upload the base version twice. I'll have a fix shortly.

petermattis added a commit to petermattis/cockroach that referenced this issue Sep 4, 2018
@petermattis
roachtest: fix acceptance/version-upgrade on remote clusters
bc683e5 
No need to run a versionStep for the base version as we manually do that
before executing the version steps. Duplicating this work was failing on
the second upload because we can't overwrite the executable for a
running binary.

Fixes cockroachdb#29542

Release note: None
@petermattis petermattis mentioned this issue Sep 4, 2018
Merged
craig bot pushed a commit that referenced this issue Sep 4, 2018
@petermattis
Merge #29520 #29544
2ddf654 
29520: sql: fix a panic in txn_state.go when verbose logging r=andreimatei,knz a=arjunravinarayan

Fix a panic (reproducible with 
`make testlogic TESTFLAGS='-verbosity=2' FILES=pg_catalog` ) 
due to an uninitialized
context. The comment on Ctx says that Ctx is uninitialized if we are
in `fsm.stateNoTxn`. In that case, use the parent (session) context
which is always initialized.

First commit is just some type assertions that I found useful to understand what's going on.

Fixes #29384.

29544: roachtest: fix acceptance/version-upgrade on remote clusters r=tschottdorf a=petermattis

No need to run a versionStep for the base version as we manually do that
before executing the version steps. Duplicating this work was failing on
the second upload because we can't overwrite the executable for a
running binary.

Fixes #29542

Release note: None

Co-authored-by: Arjun Narayan <[email protected]>
Co-authored-by: Peter Mattis <[email protected]>
@craig craig bot closed this as completed in #29544 Sep 4, 2018
petermattis added a commit to petermattis/cockroach that referenced this issue Sep 5, 2018
@petermattis
roachtest: fix acceptance/version-upgrade on remote clusters
2c02959 
No need to run a versionStep for the base version as we manually do that
before executing the version steps. Duplicating this work was failing on
the second upload because we can't overwrite the executable for a
running binary.

Fixes cockroachdb#29542

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@petermattis @cockroach-teamcity