Skip to content

Commit

Permalink
roachtest: fix acceptance/version-upgrade on remote clusters
Browse files Browse the repository at this point in the history
No need to run a versionStep for the base version as we manually do that
before executing the version steps. Duplicating this work was failing on
the second upload because we can't overwrite the executable for a
running binary.

Fixes #29542

Release note: None
  • Loading branch information
petermattis committed Sep 4, 2018
1 parent 23dffae commit bc683e5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/cmd/roachtest/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,6 @@ func runVersionUpgrade(ctx context.Context, t *test, c *cluster) {

const baseVersion = "v1.0.6"
steps := []versionStep{
binaryVersionUpgrade(baseVersion, nodes),
// v1.1.0 is the first binary version that knows about cluster versions,
// but thinks it can only support up to 1.0-3.
binaryVersionUpgrade("v1.1.0", nodes),
Expand Down

0 comments on commit bc683e5

Please sign in to comment.