Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: ignore upstream flakes in activerecord and sequelize #108939

Merged

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 17, 2023

Both of these tests are being worked on upstream to resolve the flakiness. Since CockroachDB itself is not the cause of the flakes, we ignore them so that these tests don't create unnecessary issues.

informs #108938
informs #108937
fixes #97283, #99620, #108654, #87580
fixes #98144, #99258, #108662, #98139

Release note: None

Both of these tests are being worked on upstream to resolve the
flakiness. Since CockroachDB itself is not the cause of the flakes, we
ignore them so that these tests don't create unnecessary issues.

Release note: None
@rafiss rafiss added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Aug 17, 2023
@rafiss rafiss requested review from rimadeodhar and a team August 17, 2023 20:48
@rafiss rafiss requested a review from a team as a code owner August 17, 2023 20:48
@rafiss rafiss requested review from herkolategan and DarrylWong and removed request for a team August 17, 2023 20:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 18, 2023

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 18, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: sequelize failed (waiting for sequelize updates) roachtest: activerecord failed
3 participants