Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: update to stable activerecord test suite when available #108938

Closed
rafiss opened this issue Aug 17, 2023 · 0 comments · Fixed by #118581
Closed

roachtest: update to stable activerecord test suite when available #108938

rafiss opened this issue Aug 17, 2023 · 0 comments · Fixed by #118581
Assignees
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Aug 17, 2023

The activerecord nightly tests are unstable. There is work being done upstream (here) to make the tests work.

Once that is complete, we should update the nightly roachtest to use the new version.

Jira issue: CRDB-30709

@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 17, 2023
craig bot pushed a commit that referenced this issue Aug 18, 2023
108939: roachtest: ignore upstream flakes in activerecord and sequelize r=rafiss a=rafiss

Both of these tests are being worked on upstream to resolve the flakiness. Since CockroachDB itself is not the cause of the flakes, we ignore them so that these tests don't create unnecessary issues.

informs #108938
informs #108937
fixes #97283, #99620, #108654, #87580
fixes #98144, #99258, #108662, #98139

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Feb 1, 2024
craig bot pushed a commit that referenced this issue Feb 3, 2024
116958: rpc: move system ranges to system RPC class r=lunevalex a=lunevalex

Move all the ranges between /Min and /System/tsd to use the default RPC class. This will allow for
isolation from network congestion for all system
ranges, which crucial for the stability of the system.

Fixes: #111239

Release note: None

118555: workflows: run UI lint and test in experimental github actions build r=rail a=rickystewart

Epic: [CRDB-8308](https://cockroachlabs.atlassian.net/browse/CRDB-8308)
Release note: None

118581: roachtest: stop ignoring activerecord failures r=rafiss a=rafiss

The adapter has been stabilized, so we should enable this test again.

fixes #108938
Release note: None

118659: tests: use `test.Pool` instead of `Pool` r=rail a=rickystewart

This tells Bazel to use the pool only for test actions instead of the compile action associated with each test.

Epic: CRDB-8308
Release note: None

118673: kv: mark kvnemesis tests as "large" sized r=nvanbenschoten a=arulajmani

We've recently seen these time out exclusively on eng flow. In all those instances, we can see the test is making some progress from the stack traces -- it's slow though. We mark KVNemesis tests as large, which in turn bumps their timeout in CI.

Closes #118624
Closes #118005

Release note: None

118675: ui: remove warning when auto refresh enable r=maryliag a=maryliag

The warning being displayed about old active executions was not bein properly removed when the auto refresh was turned back on.
This commit fixes this for both Statements and Transactions pages, on Active Executions.

Fixes CRDB-35837

https://www.loom.com/share/76b57eba17ab44758fe81f178f07fecd

Release note (ui change): Properly remove warning of old date on Active Executions when auto refresh is enabled.

Co-authored-by: Alex Lunev <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Arul Ajmani <[email protected]>
Co-authored-by: maryliag <[email protected]>
@craig craig bot closed this as completed in #118581 Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant