Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: update to stable sequelize test suite when available #108937

Open
rafiss opened this issue Aug 17, 2023 · 0 comments
Open

roachtest: update to stable sequelize test suite when available #108937

rafiss opened this issue Aug 17, 2023 · 0 comments
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Aug 17, 2023 •
edited by cockroach-jira-scripts
Loading

The sequelize nightly tests are unstable. There is work being done upstream (sequelize/sequelize#15569) to add better CockroachDB support and make the tests work.

Once that is complete, we should update the nightly roachtest to use it.

Jira issue: CRDB-30708
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 17, 2023
@rafiss rafiss mentioned this issue Aug 17, 2023
Merged
craig bot pushed a commit that referenced this issue Aug 18, 2023
@rafiss
Merge #108939
72e2510 
108939: roachtest: ignore upstream flakes in activerecord and sequelize r=rafiss a=rafiss

Both of these tests are being worked on upstream to resolve the flakiness. Since CockroachDB itself is not the cause of the flakes, we ignore them so that these tests don't create unnecessary issues.

informs #108938
informs #108937
fixes #97283, #99620, #108654, #87580
fixes #98144, #99258, #108662, #98139

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
This was referenced Aug 18, 2023
Merged
Merged
Merged
@exalate-issue-sync exalate-issue-sync bot added P-2 Issues/test failures with a fix SLA of 3 months and removed P-2 Issues/test failures with a fix SLA of 3 months labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafiss