Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: activerecord failed (waiting for upstream updates) #108654

Closed
cockroach-teamcity opened this issue Aug 12, 2023 · 1 comment
Closed
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 12, 2023

roachtest.activerecord failed with artifacts on release-23.1.9-rc @ d417968cd3eb53414a97b29692ba61cf1466276d:

--- FAIL: HasManyAssociationsTest#test_get_ids (unexpected)
--- FAIL: HasManyAssociationsTest#test_adding (unexpected)
--- FAIL: ReadOnlyTest#test_has_many_find_readonly (unexpected)
--- FAIL: HasManyAssociationsTest#test_select_with_block (unexpected)
--- FAIL: HasManyAssociationsTest#test_prevent_double_insertion_of_new_object_when_the_parent_association_loaded_in_the_after_save_callback (unexpected)
--- FAIL: HasManyAssociationsTest#test_transactions_when_adding_to_new_record (unexpected)
--- FAIL: PostgresqlTimestampTest#test_timestamp_with_zone_values_with_rails_time_zone_support (unexpected)
--- FAIL: HasAndBelongsToManyAssociationsTest#test_marshal_dump (unexpected)
--- FAIL: HasManyAssociationsTest#test_add_record_to_collection_should_change_its_updated_at (unexpected)
--- FAIL: BelongsToAssociationsTest#test_building_the_belonging_object_with_an_unrelated_type (unexpected)
--- FAIL: HasManyAssociationsTest#test_transactions_when_replacing_on_persisted (unexpected)
--- FAIL: ActiveRecord::CockroachDB::Migration::ForeignKeyTest#test_foreign_key_exists_by_column (unexpected)
--- FAIL: HasManyAssociationsTest#test_clearing_an_association_collection (unexpected)
--- FAIL: HasManyAssociationsTest#test_destroy_all_on_desynced_counter_cache_association (unexpected)
--- FAIL: ActiveRecord::CockroachDB::Migration::ForeignKeyTest#test_add_invalid_foreign_key (unexpected)
--- FAIL: HasAndBelongsToManyAssociationsTest#test_singular_ids_are_reloaded_after_collection_concat (unexpected)
--- FAIL: LegacyPolymorphicReferenceIndexTest::V4_2#test_create_join_table_with_polymorphic_reference_uses_all_column_names_in_index (unexpected)
--- FAIL: BelongsToAssociationsTest#test_belongs_to_counter_with_reassigning (unexpected)
--- FAIL: BelongsToAssociationsTest#test_assignment_before_child_saved_with_primary_key (unexpected)
--- FAIL: HasManyAssociationsTest#test_calling_update_changing_ids_changes_the_counter_cache (unexpected)
--- FAIL: InheritanceTest#test_compute_type_on_undefined_method (unexpected)
--- FAIL: BelongsToAssociationsTest#test_polymorphic_setting_foreign_key_after_nil_target_loaded (unexpected)
--- FAIL: FoxyFixturesTest#test_identifies_symbols (unexpected)
--- FAIL: BelongsToAssociationsTest#test_with_condition (unexpected)
--- FAIL: ActiveRecord::CockroachDB::Migration::ForeignKeyTest#test_remove_foreign_key_with_if_exists_set (unexpected)
--- FAIL: CockroachDB::FixturesTest#test_multiple_clean_fixtures (unexpected)
--- FAIL: PreloaderTest#test_some_already_loaded_associations (unexpected)
--- FAIL: HasManyAssociationsTest#test_finding_with_condition_hash (unexpected)
--- FAIL: HasManyAssociationsTest#test_create_the_association_with_an_array (unexpected)
--- FAIL: TestDefaultAutosaveAssociationOnAHasManyAssociationWithAcceptsNestedAttributes#test_errors_should_be_indexed_when_passed_as_array (unexpected)
--- FAIL: HasManyAssociationsTest#test_passes_custom_context_validation_to_validate_children (unexpected)
--- FAIL: HasAndBelongsToManyAssociationsTest#test_adding_multiple (unexpected)
--- FAIL: HasAndBelongsToManyAssociationsTest#test_has_and_belongs_to_many_in_a_namespaced_model_pointing_to_a_non_namespaced_model (unexpected)
--- FAIL: BelongsToAssociationsTest#test_raises_type_mismatch_with_namespaced_class (unexpected)
--- FAIL: FoxyFixturesTest#test_only_populates_columns_that_exist (unexpected)
--- FAIL: EagerSingularizationTest#test_eager_no_extra_singularization_belongs_to (unexpected)
--- FAIL: BelongsToAssociationsTest#test_belongs_to_with_touch_option_on_touch_without_updated_at_attributes (unexpected)
--- FAIL: BelongsToAssociationsTest#test_belongs_to_invalid_dependent_option_raises_exception (unexpected)
--- FAIL: BelongsToAssociationsTest#test_tracking_polymorphic_changes (unexpected)
--- FAIL: ActiveRecord::CockroachDB::Migration::ForeignKeyTest#test_remove_foreign_key_by_column (unexpected)
--- FAIL: TestDefaultAutosaveAssociationOnABelongsToAssociation#test_store_association_in_two_relations_with_one_save_in_existing_object (unexpected)
--- FAIL: InverseBelongsToTests#test_recursive_model_has_many_inversing (unexpected)
--- FAIL: BelongsToAssociationsTest#test_eager_loading_with_primary_key (unexpected)
--- FAIL: HasAndBelongsToManyAssociationsTest#test_removing_associations_on_destroy (unexpected)
--- FAIL: BelongsToAssociationsTest#test_dont_find_target_when_foreign_key_is_null (unexpected)
--- FAIL: HasManyAssociationsTest#test_association_enum_works_properly (unexpected)
--- FAIL: HasManyAssociationsTest#test_calling_none_should_return_true_if_none (unexpected)
For a full summary look at the activerecord artifacts
An updated blocklist (activeRecordBlocklist) is available in the artifacts' activerecord log
test artifacts and logs in: /artifacts/activerecord/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-30567

@cockroach-teamcity cockroach-teamcity added branch-release-23.1.9-rc C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 12, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Aug 12, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on release-23.1.9-rc @ 4eaa6718d63576fe7d63293c030df70ccd9ed0d2:

--- FAIL: BasicsTest#test_column_name_properly_quoted (unexpected)
--- FAIL: FoxyFixturesTest#test_supports_sti (unexpected)
--- FAIL: TransactionTest#test_callback_rollback_in_create (unexpected)
--- FAIL: FinderTest#test_find_by_one_attribute_bang (unexpected)
--- FAIL: BooleanTest#test_boolean_without_questionmark (unexpected)
--- FAIL: BasicsTest#test_table_name_guesses (unexpected)
--- FAIL: IntegrationTest#test_cache_key_format_for_existing_record_with_nil_updated_timestamps (unexpected)
--- FAIL: RelationTest#test_respond_to_class_methods_and_scopes (unexpected)
--- FAIL: BasicsTest#test_#connected_to_many_cannot_be_called_with_classes_that_include_ActiveRecord::Base (unexpected)
--- FAIL: AutomaticInverseFindingTests#test_has_many_with_scoped_belongs_to_does_not_find_inverse_automatically (unexpected)
--- FAIL: BelongsToAssociationsTest#test_belongs_to_counter (unexpected)
--- FAIL: DelegatedTypeTest#test_association_uuid (unexpected)
--- FAIL: ActiveRecord::ConnectionAdapters::LegacyConnectionHandlersMultiDbTest#test_switching_connections_with_database_config_hash (unexpected)
--- FAIL: InnerJoinAssociationTest#test_join_conditions_added_to_join_clause (unexpected)
--- FAIL: TransactionTest#test_mark_transaction_state_as_committed (unexpected)
--- FAIL: AssociationsJoinModelTest#test_has_many_through_uses_conditions_specified_on_the_has_many_association (unexpected)
--- FAIL: TransactionTest#test_persisted_in_a_model_with_custom_primary_key_after_failed_save (unexpected)
--- FAIL: ReflectionTest#test_human_name_for_column (unexpected)
--- FAIL: TimestampTest#test_touching_updates_timestamp_with_given_time (unexpected)
--- FAIL: AssociationsJoinModelTest#test_include_polymorphic_has_one_defined_in_abstract_parent (unexpected)
--- FAIL: DelegatedTypeTest#test_delegated_class (unexpected)
--- FAIL: AggregationsTest#test_nil_raises_error_when_allow_nil_is_false (unexpected)
--- FAIL: CascadedEagerLoadingTest#test_preloading_across_has_one_through_constrains_loaded_records (unexpected)
--- FAIL: TransactionTest#test_double_nested_transaction_applies_parent_state_on_rollback (unexpected)
--- FAIL: MigratorTest#test_migrations_status_with_schema_define_in_subdirectories (unexpected)
--- FAIL: RelationTest#test_find_by_requires_at_least_one_argument (unexpected)
--- FAIL: RelationTest#test_having_with_binds_for_both_where_and_having (unexpected)
--- FAIL: HasOneAssociationsTest#test_association_change_calls_destroy (unexpected)
--- FAIL: CalculationsTest#test_should_group_by_summed_field_with_conditions (unexpected)
--- FAIL: TransactionTest#test_read_attribute_after_rollback (unexpected)
--- FAIL: OptimisticLockingTest#test_destroy_with_lock_version_without_default_should_work_on_dirty_value_before_type_cast (unexpected)
--- FAIL: CalculationsTest#test_should_count_selected_field_with_include (unexpected)
--- FAIL: BooleanTest#test_find_by_falsy_boolean_symbol (unexpected)
--- FAIL: PersistenceTest#test_update_column_with_model_having_primary_key_other_than_id (unexpected)
--- FAIL: RelationTest#test_using_a_custom_table_affects_the_wheres (unexpected)
--- FAIL: RelationTest#test_finding_with_order (unexpected)
--- FAIL: InheritanceTest#test_alt_find_first_within_inheritance (unexpected)
--- FAIL: EagerAssociationTest#test_eager_with_default_scope_as_class_method (unexpected)
--- FAIL: BasicsTest#test_table_name_guesses_with_prefixes_and_suffixes (unexpected)
--- FAIL: BelongsToAssociationsTest#test_tracking_change_from_persisted_record_to_new_record (unexpected)
--- FAIL: FinderTest#test_find_by!_with_non-hash_conditions_returns_the_first_matching_record (unexpected)
--- FAIL: EagerAssociationTest#test_finding_with_includes_on_has_many_association_with_same_include_includes_only_once (unexpected)
--- FAIL: PersistenceTest#test_returns_object_even_if_validations_failed (unexpected)
--- FAIL: RelationTest#test_find_all_with_multiple_should_use_and (unexpected)
--- FAIL: ActiveRecord::ConnectionAdapters::LegacyConnectionHandlersMultiDbTest#test_establish_connection_using_3_levels_config_with_non_default_handlers (unexpected)
--- FAIL: CalculationsTest#test_count_with_eager_loading_and_custom_order_and_distinct (unexpected)
--- FAIL: JsonAttributeTest#test_pretty_print (unexpected)
For a full summary look at the activerecord artifacts
An updated blocklist (activeRecordBlocklist) is available in the artifacts' activerecord log
test artifacts and logs in: /artifacts/activerecord/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

This test on roachdash | Improve this report!

@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Aug 15, 2023
@rafiss rafiss changed the title roachtest: activerecord failed roachtest: activerecord failed (waiting for upstream updates) Aug 15, 2023
craig bot pushed a commit that referenced this issue Aug 18, 2023
108939: roachtest: ignore upstream flakes in activerecord and sequelize r=rafiss a=rafiss

Both of these tests are being worked on upstream to resolve the flakiness. Since CockroachDB itself is not the cause of the flakes, we ignore them so that these tests don't create unnecessary issues.

informs #108938
informs #108937
fixes #97283, #99620, #108654, #87580
fixes #98144, #99258, #108662, #98139

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
@rafiss rafiss closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

2 participants