Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: ignore upstream flakes in activerecord and sequelize #108939

Merged
merged 1 commit into from
Aug 18, 2023
Merged

roachtest: ignore upstream flakes in activerecord and sequelize #108939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkg/cmd/roachtest/tests/activerecord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,14 @@ func registerActiveRecord(r registry.Registry) {
results.failExpectedCount++
results.currentFailures = append(results.currentFailures, test)
case !pass && !expectedFailure:
results.results[test] = fmt.Sprintf("--- FAIL: %s (unexpected)", test)
results.failUnexpectedCount++
results.currentFailures = append(results.currentFailures, test)
// The test suite is flaky and work is being done upstream to stabilize
// it (https://github.com/cockroachdb/cockroach/issues/108938). Until
// that's done, we ignore all failures from this test.
// results.results[test] = fmt.Sprintf("--- FAIL: %s (unexpected)", test)
// results.failUnexpectedCount++
// results.currentFailures = append(results.currentFailures, test)
results.results[test] = fmt.Sprintf("--- SKIP: %s due to upstream flakes (https://github.com/cockroachdb/cockroach/issues/108938)", test)
results.ignoredCount++
}
results.runTests[test] = struct{}{}
}
Expand Down
6 changes: 5 additions & 1 deletion pkg/cmd/roachtest/tests/sequelize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,11 @@ func registerSequelize(r registry.Registry) {
rawResultsStr := result.Stdout + result.Stderr
t.L().Printf("Test Results: %s", rawResultsStr)
if err != nil {
t.Fatal(err)
// The test suite is flaky and work is being done upstream to stabilize
// it (https://github.com/sequelize/sequelize/pull/15569). Until that's
// done, we ignore all failures from this test.
// t.Fatal(err)
t.L().Printf("ignoring failure (https://github.com/cockroachdb/cockroach/issues/108937): %s", err)
}
}

Expand Down