-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql/tests: TestRandomSyntaxGeneration failed #99185
Comments
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 5493fdfec4e1762c4502fb2f5d42fd28292c9c9d:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 19a6b804d3aff74d74619a75cac3b52338c7aa02:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 0fcc33bc2870961b9387999d8a9fed97fccbb2ae: Random syntax error:
Query:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ d107217dac5d817cc115bc0e97b7e53c0f2878bf: Random syntax error:
Query:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 2bd2c806ab3044569b09e0a205b5bc0452ad4e2b: Random syntax error:
Query:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 143b63a6a27aeb286637dd2e5abddafdf0c51874:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ bb5c97b5d2073a27e7ec88654b05ac913112f610: Random syntax error:
Query:
Same failure on other branches
|
99174: sql: fix circular dependencies in views r=rharding6373 a=rharding6373 This change fixes node crashes that could happen due to stack overflow if views were created with circular dependencies. Fixes: #98999 Epic: none Co-authored-by: [email protected] Release note (bug fix): If views are created with circular dependencies, CRDB returns the error "cyclic view dependency for relation" instead of crashing the node. This bug is present since at least 21.1. 99624: testutils: add infrastructure for reusable test fixtures r=RaduBerinde a=RaduBerinde Certain storage-related tests/benchmarks generate fixtures and attempt to reuse them across invocations. This is important because fixtures can be large and slow to generate; but more importantly the generation is non-deterministic and we want to use the exact same fixture when comparing benchmark data. Currently the tests achieve this by using a `.gitignore`d subdirectory inside the source tree. This does not work with bazel (which executes the test in a sandbox). This commit addresses the issue by adding new test infrastructure for reusable fixtures. We use the user's `.cache` directory instead of the source tree (specifically $HOME/.cache/crdb-test-fixtures/...). For bazel, we make sure the path is available (and writable) in the sandbox and we pass the path to the test through an env var. Fixes #83599. Release note: None Epic: none 99699: spanconfig: integrate SpanConfigBounds with the Store and KVSubscriber r=ajwerner a=arulajmani This patch integrates `SpanConfigBounds` with the `KVSubscriber` and `spanconfig.Store`. The `spanconfig.Store` used by the `KVSubscriber` now has a handle to the global tenant capability state. It uses this to clamp any secondary tenant span configs that are not in conformance before returning them. By default, clamping of secondary tenant span configurations is turned off. It can be enabled using the `spanconfig.bounds.enabled` cluster setting. The setting is hidden. Fixes: #99689 Informs #99911 Release note: None 99759: roachtest: set lower min range_max_bytes in multitenant_distsql test r=rharding6373 a=rharding6373 The multitenant_distsql roachtest relies on a smaller range size than the new default min of range_max_bytes (64MiB) due to performance and resource limitations. We set the COCKROACH_MIN_RANGE_MAX_BYTES to allow the test to use the smaller range. Fixes: #99626 Epic: None Release note: None 99813: spanconfig: do not fatal in NeedsSplit and ComputeSplitKey r=irfansharif a=arulajmani See individual commits for details. Fixes #97336. 99839: schemachanger: Annotate all tables if ALTER TABLE IF EXISTS on non-existent table r=Xiang-Gu a=Xiang-Gu Previously, if table `t` does not exist, `ALTER TABLE IF EXISTS t` will only mark `t` as non-existent. This is inadequate because for stmt like `ALTER TABLE IF EXISTS t ADD FOREIGN KEY REFERENCES t_other` we will not touch `t_other` and the validation logic will later complain that `t_other` is not fully resolved nor marked as non-existent. This commit fixes it by marking all tables in this ALTER TABLE stmt as non-existent if the `t` is non-existent, so we can pass the validation. Fixes issues discovered in #99185 Epic: None 99865: roachtest: fix query used to get job status in backup/mixed-version r=srosenberg a=renatolabs At the moment, we only query job status in mixed-version state (so we should always use `system.jobs`). However, the code added in this commit should continue to work once we start developing 23.2, as we're checking that the cluster version is at least 23.1 before using `crdb_internal.system_jobs`. Epic: none Release note: None 99878: jobs: change job_info.info_key to string r=dt a=dt Release note: none. Epic: none. Hopefully we get this one in now before it is released and harder to change later. I think if we go with bytes, we'll spend the next several years typing convert_to over and over, or forgetting to and then typing it, when debugging. Co-authored-by: rharding6373 <[email protected]> Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Arul Ajmani <[email protected]> Co-authored-by: Xiang Gu <[email protected]> Co-authored-by: Renato Costa <[email protected]> Co-authored-by: David Taylor <[email protected]>
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 1f8024bf14433ca169e5a8c3768c5d223dc5018c:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 41581c367b3a1d7893c2945465c57ffa841035e3:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 99102ddf4b7602788b422366f1acc14b81c64d24:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 1e27c65fb5a3810a5e2285cf07b45d95d401cca6:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 1e27c65fb5a3810a5e2285cf07b45d95d401cca6:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 07c7d4b3abfa1dc79d8fda385132a27c81665fee:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ ff2c4a3454a63bd74fe9a2feed53a7bdcfaf5191:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 8d10f15db8e5efaff57ec332c438211895c6c608:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ d293bb3acd9b7f67ac793ddb6a0836e637864629:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 9d976cbcf5b0bf031a5d831daf47abeacdfd974d:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 57b6b702a0403fca0d8edce22d8758f6847d6913:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 51aa6257c063f60fb76044f9cccc47e259930d00:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ f295bd861a3a427652b19c2254d2401ebb4a3c8e: Random syntax error:
Query:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ f295bd861a3a427652b19c2254d2401ebb4a3c8e:
Same failure on other branches
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ e57e9742146b7fac7f7530fa6224e11121ada92f:
Same failure on other branches
|
Informs: cockroachdb#99185 This commit cherry-picked changes from cockroachdb#107723 and add fixes for formatting `EXPORT` options. Release note: None
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ fcfa15d9694c0b840ac0c5c1b1489fa90a62efd8:
|
Looks like we expected and caught this error. the real Failure is :
|
@chengxiong-ruan we can move this over to the Queries team so they can work on the IMPORT syntax issue. |
107279: sql: remove isInternalPlanner boolean r=yuzefovich a=yuzefovich This boolean is very confusing and can mislead people, so let's remove it. It was introduced in bf9ffe9 with one specific use case in mind: lease management for user defined types when the execution flow occurs in the context of a user transaction. In that scenario, the execution engine uses the planner's `descs.Collection` when running the local plan. However, I don't see the reason why we cannot do the same thing for queries outside of the user transaction (where we have the "internal planner" object), so this commit removes that extra conditional. That said, I don't quite understand how these things work, but we can always go back to not using the planner's collection for "internal planners" (we'd name the boolean differently though) if we see any fallout. Epic: None Release note: None 107834: roachtest: require stability in rebalance by load roachtests r=andrewbaptist a=kvoli The `rebalance/by-load` roachtests collect timeseries data from the cluster. If these tests started quickly enough, no datapoints could exist which would cause a out of bounds array exception. Handle the no datapoints case, and log a message without failing the test. Informs: #107247 ---- The `rebalance/by-load` roachtests would immediately pass once the balance target was hit. However, it was possible that the cluster was only transiently balanced. Bump the timeout of all tests to be uniformly 10 minutes, from a previous 5 minutes, require that the load remains balanced for at least 1 minute to pass. Informs: #107247 Release note: None 107892: sql: fix formatting of import, backup and create tenant r=chengxiong-ruan a=chengxiong-ruan Informs: #99185 This commit cherry-picked changes from #107723 and add fixes for formatting `EXPORT` and `CHANGEFEED` options. Release note: None 107955: roachtest: increase the concurrency for gracefuldraining r=kvoli a=andrewbaptist This set of commits changes gracefuldraining to use the `measureQPS` method instead of looking at the stats from the stats database and additionally increases the concurrency so it no longer fails. Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Austen McClernon <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Andrew Baptist <[email protected]>
Informs: cockroachdb#99185 This commit cherry-picked changes from cockroachdb#107892. Release note: None Fixes: cockroachdb#108254 and cockroachdb#108233 (partially) Release justification: fixes bug with random syntax generation
Informs: cockroachdb#99185 This commit cheery-picked changes from cockroachdb#107892 Release note: None Fixes: cockroachdb#108233 Release justification: fixes bug with random syntax generation
Informs: cockroachdb#99185 This commit cherry-picked changes from cockroachdb#107723 and add fixes for formatting `EXPORT` options. Release note: None
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 78bb7696847e1d8abf5d6a199c6dd3414a568691:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-25741
The text was updated successfully, but these errors were encountered: