roachtest: fix query used to get job status in backup/mixed-version #99865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, we only query job status in mixed-version state (so we should always use `system.jobs`). However, the code added in this commit should continue to work once we start developing 23.2, as we're checking that the cluster version is at least 23.1 before using `crdb_internal.system_jobs`. Epic: none Release note: None
renatolabs
requested review from
srosenberg and
smg260
and removed request for
a team
|
This change is |
srosenberg
approved these changes
Mar 29, 2023
|
TFTR! bors r=srosenberg |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
|
bors r=srosenberg |
|
Build succeeded: |
|
blathers backport 23.1 |
renatolabs
deleted the
rc/mixed-version-backups-roachtest-fix-jobs-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we only query job status in mixed-version state (so we should always use
system.jobs). However, the code added in this commit should continue to work once we start developing 23.2, as we're checking that the cluster version is at least 23.1 before usingcrdb_internal.system_jobs.Epic: none
Release note: None