Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/tests: TestRandomSyntaxGeneration failed #108254

Closed
cockroach-teamcity opened this issue Aug 6, 2023 · 2 comments
Closed

sql/tests: TestRandomSyntaxGeneration failed #108254

cockroach-teamcity opened this issue Aug 6, 2023 · 2 comments
Assignees
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 6, 2023

sql/tests.TestRandomSyntaxGeneration failed with artifacts on release-23.1 @ aad4fd4312460e6689f543eaff85b1bca8cebf91:

    rsg_test.go:832: 1m15s of 5m0s: 182317 executions, 10418 successful
    rsg_test.go:832: 1m20s of 5m0s: 193283 executions, 10937 successful
    rsg_test.go:832: 1m25s of 5m0s: 205815 executions, 11536 successful
    rsg_test.go:832: 1m30s of 5m0s: 217091 executions, 12088 successful
    rsg_test.go:832: 1m35s of 5m0s: 229092 executions, 12685 successful
    rsg_test.go:832: 1m40s of 5m0s: 239923 executions, 13282 successful
    rsg_test.go:832: 1m45s of 5m0s: 252291 executions, 13893 successful
    rsg_test.go:832: 1m50s of 5m0s: 263515 executions, 14462 successful
    rsg_test.go:832: 1m55s of 5m0s: 275985 executions, 15098 successful
    rsg_test.go:832: 2m0s of 5m0s: 287831 executions, 15690 successful
    rsg_test.go:832: 2m5s of 5m0s: 300975 executions, 16276 successful
    rsg_test.go:832: 2m10s of 5m0s: 314293 executions, 16913 successful
    rsg_test.go:832: 2m15s of 5m0s: 327093 executions, 17484 successful
    rsg_test.go:832: 2m20s of 5m0s: 339063 executions, 18048 successful
    rsg_test.go:832: 2m25s of 5m0s: 351331 executions, 18626 successful
    rsg_test.go:832: 2m30s of 5m0s: 363619 executions, 19180 successful
    rsg_test.go:832: 2m35s of 5m0s: 375824 executions, 19786 successful
    rsg_test.go:832: 2m40s of 5m0s: 387814 executions, 20359 successful
    rsg_test.go:832: 2m45s of 5m0s: 400166 executions, 20938 successful
    rsg_test.go:832: 2m50s of 5m0s: 412899 executions, 21524 successful
    rsg_test.go:832: 2m55s of 5m0s: 424610 executions, 22093 successful
    rsg_test.go:832: 3m0s of 5m0s: 436781 executions, 22693 successful
    rsg_test.go:832: 3m5s of 5m0s: 448720 executions, 23244 successful
    rsg_test.go:832: 3m10s of 5m0s: 461336 executions, 23819 successful
    rsg_test.go:832: 3m15s of 5m0s: 473277 executions, 24380 successful
    rsg_test.go:832: 3m20s of 5m0s: 485527 executions, 24972 successful
    rsg_test.go:832: 3m25s of 5m0s: 497939 executions, 25576 successful
    rsg_test.go:832: 3m30s of 5m0s: 509100 executions, 26096 successful
    rsg_test.go:832: 3m35s of 5m0s: 521123 executions, 26666 successful
    rsg_test.go:832: 3m40s of 5m0s: 532867 executions, 27199 successful
    rsg_test.go:832: 3m45s of 5m0s: 545023 executions, 27754 successful
    rsg_test.go:832: 3m50s of 5m0s: 557377 executions, 28322 successful
    rsg_test.go:832: 3m55s of 5m0s: 570801 executions, 28921 successful
    rsg_test.go:832: 4m0s of 5m0s: 583600 executions, 29512 successful
    rsg_test.go:832: 4m5s of 5m0s: 595986 executions, 30084 successful
    rsg_test.go:832: 4m10s of 5m0s: 608388 executions, 30648 successful
    rsg_test.go:832: 4m15s of 5m0s: 620520 executions, 31229 successful
    rsg_test.go:832: 4m20s of 5m0s: 631992 executions, 31770 successful
    rsg_test.go:832: 4m25s of 5m0s: 643802 executions, 32350 successful
    rsg_test.go:832: 4m30s of 5m0s: 655154 executions, 32881 successful
    rsg_test.go:832: 4m35s of 5m0s: 667726 executions, 33492 successful
    rsg_test.go:832: 4m40s of 5m0s: 679127 executions, 34012 successful
    rsg_test.go:832: 4m45s of 5m0s: 691498 executions, 34614 successful
    rsg_test.go:832: 4m50s of 5m0s: 704176 executions, 35164 successful
    rsg_test.go:832: 4m55s of 5m0s: 716561 executions, 35729 successful
    rsg_test.go:868: 728465 executions, 36278 successful
    rsg_test.go:876: cannot parse output of Format: sql="CREATE CHANGEFEED FOR SURVIVE . ident . FAMILY , ISERROR INTO PLACEHOLDER WITH OPTIONS ( BUCKET_COUNT )", formattedSQL="CREATE CHANGEFEED FOR TABLE survive.ident.family, TABLE \"iserror\" INTO 'placeholder' WITH bucket_count": at or near "with": syntax error
    rsg_test.go:304: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/d437d2c847dfedbc4972f231c3331c8e/logTestRandomSyntaxGeneration437488720
--- FAIL: TestRandomSyntaxGeneration (301.98s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-30387

@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 6, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Aug 6, 2023
@chengxiong-ruan
Copy link
Contributor

similarly, this failure on changefeed has been fixed on master with #107892, need to apply the similar change for 23.1 as well.

@annrpom annrpom self-assigned this Aug 7, 2023
annrpom pushed a commit to annrpom/cockroach that referenced this issue Aug 7, 2023
Informs: cockroachdb#99185

This commit cherry-picked changes from cockroachdb#107892.

Release note: None
Fixes: cockroachdb#108254 and cockroachdb#108233 (partially)
Release justification: fixes bug with random syntax generation
@rafiss
Copy link
Collaborator

rafiss commented Aug 9, 2023

resolved by #108314

@rafiss rafiss closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

4 participants