Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: schemachanger: Annotate all tables if ALTER TABLE IF EXISTS on non-existent table #100011

Merged
merged 1 commit into from
Mar 30, 2023
Merged

release-23.1: schemachanger: Annotate all tables if ALTER TABLE IF EXISTS on non-existent table #100011

merged 1 commit into from
Mar 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #99839 on behalf of @Xiang-Gu.

/cc @cockroachdb/release

Previously, if table t does not exist, ALTER TABLE IF EXISTS t will only mark t as non-existent. This is inadequate because for stmt like ALTER TABLE IF EXISTS t ADD FOREIGN KEY REFERENCES t_other we will not touch t_other and the validation logic will later complain that t_other is not fully resolved nor marked as non-existent. This commit fixes it by marking all tables in this ALTER TABLE stmt as non-existent if the t is non-existent, so we can pass the validation.

Fixes issues discovered in #99185
Epic: None

Release justification: bug fix

@Xiang-Gu
schemachanger: Annotate tables if ALTER TABLE IF EXISTS is short-circ…
2dc0229 
…uited

Previously, if table `t` does not exist, `ALTER TABLE IF EXISTS t` will
only mark `t` as non-existent. This is inadequate because for stmt
like `ALTER TABLE IF EXISTS t ADD FOREIGN KEY REFERENCES t_other` we
will not touch `t_other` and the validation logic will later complain
that `t_other` is not fully resolved nor marked as non-existent. This
commit fixes it by marking all tables in this ALTER TABLE stmt as
non-existent if the `t` is non-existent, so we can pass the validation.
@blathers-crl blathers-crl bot requested a review from a team March 30, 2023 04:05
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 30, 2023 04:05
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99839 branch 2 times, most recently from 63619dc to 2dc0229 Compare March 30, 2023 04:05
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss self-requested a review March 30, 2023 04:57
@rafiss rafiss merged commit 11dd026 into release-23.1 Mar 30, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1-99839 branch March 30, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @Xiang-Gu