-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: set lower min range_max_bytes in multitenant_distsql test #99759
roachtest: set lower min range_max_bytes in multitenant_distsql test #99759
Conversation
The multitenant_distsql roachtest relies on a smaller range size than the new default min of range_max_bytes (64MiB) due to performance and resource limitations. We set the COCKROACH_MIN_RANGE_MAX_BYTES to allow the test to use the smaller range. Fixes: cockroachdb#99626 Epic: None Release note: None
@aliher1911 Does this seem sane to you? I think we need to do that same thing you did in #99636 to fix #99626. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @aliher1911, @renatolabs, and @srosenberg)
pkg/cmd/roachtest/tests/multitenant_distsql.go
line 126 at r1 (raw file):
// and test takes too long and too much resources with default range sizes // so make them much smaller. _, err = inst1Conn.Exec(`ALTER TABLE t CONFIGURE ZONE USING range_min_bytes = 1000,range_max_bytes = 100000`)
Just want to note that this is where we set the range_max_bytes in this test.
@mgartner It worked when run roachtests manually, but I'm yet to see it merge and pass nightly. If you want to be on a safe side, we can wait for my PR to merge and run overnight before merging. But I don't see why it could fail. |
This passes the zone config checks when I test with roachtest manually, as well. |
I'd vote for merging this now. In the best case, we get less noise tomorrow. In the worst case, we have to find a new fix. At least we'll have more information. |
TFTR! bors r+ |
Build failed (retrying...): |
Build failed (retrying...): |
Build failed (retrying...): |
Will try again after flaky test fixes are in. bors r- |
Canceled. |
bors r+ |
Build succeeded: |
Sadly this doesn't seem to fix this set of roachtests. The statement to change (The fact that we have separate code in |
The multitenant_distsql roachtest relies on a smaller range size than the new default min of range_max_bytes (64MiB) due to performance and resource limitations. We set the COCKROACH_MIN_RANGE_MAX_BYTES to allow the test to use the smaller range.
Fixes: #99626
Epic: None
Release note: None