Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: disk-stalled/log=true,data=true failed #78008

Closed
cockroach-teamcity opened this issue Mar 17, 2022 · 1 comment
Closed

roachtest: disk-stalled/log=true,data=true failed #78008

cockroach-teamcity opened this issue Mar 17, 2022 · 1 comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 17, 2022

roachtest.disk-stalled/log=true,data=true failed with artifacts on master @ 8179b6f996149ef9e04eb62f9c95ecc992b9f30e:

		Wraps: (3) COMMAND_PROBLEM
		Wraps: (4) Node 1. Command with error:
		  | ``````
		  | set -exuo pipefail;
		  |   thrift_dir="/opt/thrift"
		  |
		  |   if [ ! -f "/usr/bin/thrift" ]; then
		  | 	sudo apt-get update;
		  | 	sudo apt-get install -qy automake bison flex g++ git libboost-all-dev libevent-dev libssl-dev libtool make pkg-config python-setuptools libglib2.0-dev python2 python-six
		  |
		  |     sudo mkdir -p "${thrift_dir}"
		  |     sudo chmod 777 "${thrift_dir}"
		  |     cd "${thrift_dir}"
		  |     curl "https://downloads.apache.org/thrift/0.13.0/thrift-0.13.0.tar.gz" | sudo tar xvz --strip-components 1
		  |     sudo ./configure --prefix=/usr
		  |     sudo make -j$(nproc)
		  |     sudo make install
		  |     (cd "${thrift_dir}/lib/py" && sudo python2 setup.py install)
		  |   fi
		  |
		  |   charybde_dir="/opt/charybdefs"
		  |   nemesis_path="${charybde_dir}/charybdefs-nemesis"
		  |
		  |   if [ ! -f "${nemesis_path}" ]; then
		  |     sudo apt-get install -qy build-essential cmake libfuse-dev fuse
		  |     sudo rm -rf "${charybde_dir}" "${nemesis_path}" /usr/local/bin/charybdefs{,-nemesis}
		  |     sudo mkdir -p "${charybde_dir}"
		  |     sudo chmod 777 "${charybde_dir}"
		  |     # TODO(bilal): Change URL back to scylladb/charybdefs once https://github.com/scylladb/charybdefs/pull/28 is merged.
		  |     git clone --depth 1 "https://github.com/itsbilal/charybdefs.git" "${charybde_dir}"
		  |
		  |     cd "${charybde_dir}"
		  |     thrift -r --gen cpp server.thrift
		  |     cmake CMakeLists.txt
		  |     make -j$(nproc)
		  |
		  |     sudo modprobe fuse
		  |     sudo ln -s "${charybde_dir}/charybdefs" /usr/local/bin/charybdefs
		  |     cat > "${nemesis_path}" <<EOF
		  | #!/bin/bash
		  | cd /opt/charybdefs/cookbook
		  | ./recipes "\$@"
		  | EOF
		  |     chmod +x "${nemesis_path}"
		  | 	sudo ln -s "${nemesis_path}" /usr/local/bin/charybdefs-nemesis
		  | fi
		  |
		  | ``````
		Wraps: (5) exit status 2
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) errors.Cmd (4) *hintdetail.withDetail (5) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/storage

This test on roachdash | Improve this report!

Jira issue: CRDB-13919

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 17, 2022
@blathers-crl blathers-crl bot added the T-storage Storage Team label Mar 17, 2022
nicktrav added a commit to nicktrav/cockroach that referenced this issue Mar 17, 2022
The version of Thrift used in tests that use `charybdefs` has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on `charybdefs` to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches cockroachdb#78006,cockroachdb#78007,cockroachdb#78008,cockroachdb#78010,cockroachdb#78015,cockroachdb#78016.

Release note: None.
craig bot pushed a commit that referenced this issue Mar 17, 2022
77875: sql: use IndexFetchSpec for inverted joiner r=RaduBerinde a=RaduBerinde

#### rowexec: address TODO in inverted joiner

This commit addresses a TODO in the inverted joiner. We now reuse a
buffer for encoding the prefix key. In the general case we still need
to make a copy since we are storing multiple prefix keys; but now we
try to reuse the last copy if the prefix is the same.

We also remove the temporary use of `indexRow` which is confusing here
(it wasn't obvious at first but this code has nothing to do with index
rows and is just using `indexRow` as a temporary buffer).

Release note: None

#### geoindex: minor cleanup around Config

This change changes `IsEmptyConfig`, `IsGeographyConfig`,
`IsGeometryConfig` to methods on the `geoindex.Config` type.

We also switch to passing configs by value which is cleaner and avoids
some allocations.

Release note: None

#### sql: use IndexFetchSpec for inverted joiner

This commit reworks the InvertedJoiner to use an IndexFetchSpec
instead of table and index descriptors.

The "internal schema" now matches the fetched columns (leading to
simplifications in both planning and execution code).

Release note: None

77878: kvstreamer: re-enable streamer by default r=yuzefovich a=yuzefovich

Release note: None

77968: sql: keep experimental_enable_hash_sharded_indexes var as noop r=chengxiong-ruan a=chengxiong-ruan

Fixes #77954

Release justification: needed for session var backward compatibility.
Release note (sql change): experimental_enable_hash_sharded_indexes
used to be set to enable the hash sharded index feature. since we now
enable the feature by default, user don't need to set this var anymore.
But still keeping it as noop for backward compatibility.

77995: opt: add ContainedBy operator (<@) to FoldNullComparisonLeft norm rule r=msirek,mgartner a=michae2

Fixes: #77745

When we originally made the ContainedBy operator (<`@)` distinct from the
Contains operator (`@>)` we forgot to add ContainedBy to the
FoldNullComparisonLeft normalization rule. It was only added to the
FoldNullComparisonRight rule. Correct this.

Release note (bug fix): fix an optimizer bug that prevented expressions
of the form (NULL::STRING[] <@ ARRAY['x']) from being folded to NULL.

78013: roachtest: fix handling of test panics r=erikgrinaker a=tbg

- roachtest: fix handling of test panics
- roachtest: gracefully fail in sst-corruption test


78023: roachprod: update thrift artifact url for use with charybdefs r=tbg a=nicktrav

The version of Thrift used in tests that use `charybdefs` has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on `charybdefs` to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches #78006,#78007,#78008,#78010,#78015,#78016.

Release note: None.

Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Chengxiong Ruan <[email protected]>
Co-authored-by: Michael Erickson <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
Co-authored-by: Nick Travers <[email protected]>
blathers-crl bot pushed a commit that referenced this issue Mar 17, 2022
The version of Thrift used in tests that use `charybdefs` has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on `charybdefs` to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches #78006,#78007,#78008,#78010,#78015,#78016.

Release note: None.
blathers-crl bot pushed a commit that referenced this issue Mar 17, 2022
The version of Thrift used in tests that use `charybdefs` has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on `charybdefs` to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches #78006,#78007,#78008,#78010,#78015,#78016.

Release note: None.
@nicktrav
Copy link
Collaborator

Fixed by #78023.

nicktrav added a commit that referenced this issue Mar 18, 2022
The version of Thrift used in tests that use charybdefs has disappeared
from the Apache artifacts repository that is used currently, which
causes any roachtest that depends on charybdefs to fail due to not being
able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches #78006,#78007,#78008,#78010,#78015,#78016.

Release note: None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team
Projects
None yet
Development

No branches or pull requests

2 participants