Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: update thrift artifact url for use with charybdefs #78023

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

nicktrav
Copy link
Collaborator

@nicktrav nicktrav commented Mar 17, 2022

The version of Thrift used in tests that use charybdefs has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on charybdefs to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches #78006,#78007,#78008,#78010,#78015,#78016.

Release note: None.

@nicktrav nicktrav requested a review from a team March 17, 2022 14:30
@nicktrav nicktrav requested a review from a team as a code owner March 17, 2022 14:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav
Copy link
Collaborator Author

I shall do a manual test run across the failing tests now.

@nicktrav nicktrav requested review from a team and erikgrinaker and removed request for a team March 17, 2022 14:31
The version of Thrift used in tests that use `charybdefs` has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on `charybdefs` to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches cockroachdb#78006,cockroachdb#78007,cockroachdb#78008,cockroachdb#78010,cockroachdb#78015,cockroachdb#78016.

Release note: None.
@nicktrav
Copy link
Collaborator Author

Looks like upgrading the version opened a can of worms due to incompatibilities. I think I found a more stable link to the older artifacts, so I'm going to amend this PR to use that instead.

@nicktrav nicktrav changed the title roachprod: update thrift version to 0.16.0 for charybdefs roachprod: update thrift artifact url for use with charybdefs Mar 17, 2022
@nicktrav
Copy link
Collaborator Author

Roachtesttest test run was successful. TFTR!

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Mar 17, 2022

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Mar 17, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 6c1e2c2 to blathers/backport-release-20.2-78023: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 20.2.x failed. See errors above.


error creating merge commit from 6c1e2c2 to blathers/backport-release-21.1-78023: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants