Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: roachprod: update thrift artifact url for use with charybdefs #78043

Merged
merged 1 commit into from
Mar 21, 2022
Merged

release-22.1: roachprod: update thrift artifact url for use with charybdefs #78043

merged 1 commit into from
Mar 21, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 17, 2022 •
edited by nicktrav
Loading

Backport 1/1 commits from #78023 on behalf of @nicktrav.

/cc @cockroachdb/release

The version of Thrift used in tests that use charybdefs has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on charybdefs to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches #78006,#78007,#78008,#78010,#78015,#78016.

Fixes #78132,#78131,#78123.

Release note: None.

Release justification: Test only. Fixes a flaky test.

@nicktrav
roachprod: update thrift artifact url for use with charybdefs
7de3998 
The version of Thrift used in tests that use `charybdefs` has
disappeared from the Apache artifacts repository that is used currently,
which causes any roachtest that depends on `charybdefs` to fail due to
not being able to fetch the artifact it needs.

Update the artifact URL to pull from the Apache archive instead.

Touches #78006,#78007,#78008,#78010,#78015,#78016.

Release note: None.
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 17, 2022 18:34
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-78023 branch from 3a7cf60 to 7de3998 Compare March 17, 2022 18:34
@blathers-crl blathers-crl bot requested review from erikgrinaker, tbg and a team March 17, 2022 18:34
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 17, 2022 •
edited by nicktrav
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 17, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

jbowens
jbowens approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @tbg)

@nicktrav
Copy link
Collaborator

TFTR!

@nicktrav nicktrav merged commit a8fd39a into release-22.1 Mar 21, 2022
@nicktrav nicktrav deleted the blathers/backport-release-22.1-78023 branch March 21, 2022 20:12
This was referenced Mar 22, 2022
Closed
Closed
@nicktrav nicktrav mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbowens jbowens jbowens approved these changes

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@tbg tbg Awaiting requested review from tbg

Assignees

@nicktrav nicktrav

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @nicktrav @erikgrinaker @jbowens