roachtest: fix handling of test panics #78013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tbg
commented
Mar 17, 2022
tbg
commented
- roachtest: fix handling of test panics
- roachtest: gracefully fail in sst-corruption test
tbg
requested review from
stevendanna,
erikgrinaker and
a team
and removed request for
a team
|
This change is |
erikgrinaker
approved these changes
Mar 17, 2022
Previously, if a test panicked, the test runner would terminate, preventing most of the test suite to be run. Release justification: testing infra fix Release note: None
Prior to this commit, the test would panic ungracefully (at least some of the time). Now it will fail via a call to `t.Fatalf`. This fix isn't strictly necessary since the test harness now handles tests panicking. However, in times of stability probably better not to take any chances, especially since this also affects `release-22.1`. Release note: None
|
bors r=erikgrinaker |
srosenberg
reviewed
Mar 17, 2022
| Owner: OwnerUnitTest, | ||
| Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { | ||
| sl := []int{0} | ||
| // We need to throw the RoachVet linter off our scent since it's pretty |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.