Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: roachtest: fix handling of test panics #78040

Merged
merged 2 commits into from
Mar 18, 2022
Merged

release-22.1: roachtest: fix handling of test panics #78040

merged 2 commits into from
Mar 18, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 17, 2022 •
edited by tbg
Loading

Backport 2/2 commits from #78013 on behalf of @tbg.

/cc @cockroachdb/release

  • roachtest: fix handling of test panics
  • roachtest: gracefully fail in sst-corruption test

Release justification: testing fix

tbg added 2 commits March 17, 2022 07:49
@tbg
roachtest: fix handling of test panics
7553532 
Previously, if a test panicked, the test runner would terminate,
preventing most of the test suite to be run.

Release justification: testing infra fix
Release note: None
@tbg
roachtest: gracefully fail in sst-corruption test
d21485a 
Prior to this commit, the test would panic ungracefully (at least some
of the time). Now it will fail via a call to `t.Fatalf`.

This fix isn't strictly necessary since the test harness now handles
tests panicking. However, in times of stability probably better not
to take any chances, especially since this also affects `release-22.1`.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 17, 2022 18:34
@blathers-crl blathers-crl bot requested review from srosenberg and removed request for a team March 17, 2022 18:34
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-78013 branch from 2d0e74a to d21485a Compare March 17, 2022 18:34
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 17, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 17, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

srosenberg
srosenberg approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tbg tbg merged commit f5b42a4 into release-22.1 Mar 18, 2022
@tbg tbg deleted the blathers/backport-release-22.1-78013 branch March 18, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenberg srosenberg srosenberg approved these changes

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees

@tbg tbg

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @erikgrinaker @srosenberg @tbg