sql: v21.2.6: expected *DArray, found tree.dNull when folding a comparison #77745

cockroach-teamcity · 2022-03-14T02:02:58Z

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/3097249090/?referrer=webhooks_plugin

Panic message:

datum.go:3946: expected *DArray, found tree.dNull
--
*errutil.leafError: expected *DArray, found tree.dNull (1)
datum.go:3946: *withstack.withStack (top exception)
*assert.withAssertionFailure
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/sem/tree/datum.go

Lines 3945 to 3947 in c7cfac5

    
           if !ok { 
        
           	panic(errors.AssertionFailedf("expected *DArray, found %T", e)) 
        
           }

in pkg/sql/sem/tree.MustBeDArray

cockroach/pkg/sql/sem/tree/eval.go

Lines 2566 to 2568 in c7cfac5

    
           Fn: func(ctx *EvalContext, left Datum, right Datum) (Datum, error) { 
        
           	needles := MustBeDArray(left) 
        
           	haystack := MustBeDArray(right)

in pkg/sql/sem/tree.glob..func138

cockroach/pkg/sql/opt/norm/fold_constants_funcs.go

Lines 438 to 440 in c7cfac5

    
           result, err := o.Fn(c.f.evalCtx, lDatum, rDatum) 
        
           if err != nil {

in pkg/sql/opt/norm.(*CustomFuncs).FoldComparison
https://github.com/cockroachdb/cockroach/blob/c7cfac57476f06e3154b2fc38e77982a8bbc64c2/pkg/sql/opt/norm/factory.og.go#L16765-L16767 in pkg/sql/opt/norm.(*Factory).ConstructContainedBy
https://github.com/cockroachdb/cockroach/blob/c7cfac57476f06e3154b2fc38e77982a8bbc64c2/pkg/sql/opt/norm/factory.og.go#L22243-L22245 in pkg/sql/opt/norm.(*Factory).Replace

cockroach/pkg/sql/opt/norm/inline_funcs.go

Lines 92 to 94 in c7cfac5

    
           	} 
        
           	return c.f.Replace(e, replace) 
        
           }

in pkg/sql/opt/norm.(*CustomFuncs).inlineConstants.func1

cockroach/pkg/sql/opt/norm/inline_funcs.go

Lines 94 to 96 in c7cfac5

    
           	} 
        
           	return replace(e) 
        
           }

in pkg/sql/opt/norm.(*CustomFuncs).inlineConstants

cockroach/pkg/sql/opt/norm/inline_funcs.go

Lines 54 to 56 in c7cfac5

    
           newProjections[i] = c.f.ConstructProjectionsItem( 
        
           	c.inlineConstants(item.Element, input, constCols).(opt.ScalarExpr), 
        
           	item.Col,

in pkg/sql/opt/norm.(*CustomFuncs).InlineProjectionConstants
https://github.com/cockroachdb/cockroach/blob/c7cfac57476f06e3154b2fc38e77982a8bbc64c2/pkg/sql/opt/norm/factory.og.go#L1348-L1350 in pkg/sql/opt/norm.(*Factory).ConstructProject

cockroach/pkg/sql/opt/optbuilder/project.go

Lines 60 to 62 in c7cfac5

    
           	return b.factory.ConstructProject(input, projections, passthrough) 
        
           }

in pkg/sql/opt/optbuilder.(*Builder).constructProject

cockroach/pkg/sql/opt/optbuilder/project.go

Lines 35 to 37 in c7cfac5

    
           } else { 
        
           	projectionsScope.expr = b.constructProject( 
        
           		inScope.expr.(memo.RelExpr),

in pkg/sql/opt/optbuilder.(*Builder).constructProjectForScope

cockroach/pkg/sql/opt/optbuilder/mutation_builder.go

Lines 907 to 909 in c7cfac5

    
           mb.b.constructProjectForScope(mb.outScope, projectionsScope) 
        
           mb.outScope = projectionsScope

in pkg/sql/opt/optbuilder.(*mutationBuilder).addCheckConstraintCols

cockroach/pkg/sql/opt/optbuilder/insert.go

Lines 668 to 670 in c7cfac5

    
           // Add any check constraint boolean columns to the input. 
        
           mb.addCheckConstraintCols(false /* isUpdate */)

in pkg/sql/opt/optbuilder.(*mutationBuilder).buildInsert

cockroach/pkg/sql/opt/optbuilder/insert.go

Lines 287 to 289 in c7cfac5

    
           // Build the final insert statement, including any returned expressions. 
        
           mb.buildInsert(returning)

in pkg/sql/opt/optbuilder.(*Builder).buildInsert

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 292 to 294 in c7cfac5

    
           return b.processWiths(stmt.With, inScope, func(inScope *scope) *scope { 
        
           	return b.buildInsert(stmt, inScope) 
        
           })

in pkg/sql/opt/optbuilder.(*Builder).buildStmt.func2

cockroach/pkg/sql/opt/optbuilder/with.go

Lines 110 to 112 in c7cfac5

    
           inScope.atRoot = false 
        
           outScope := buildStmt(inScope) 
        
           outScope.expr = b.buildWiths(outScope.expr, correlatedCTEs)

in pkg/sql/opt/optbuilder.(*Builder).processWiths

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 291 to 293 in c7cfac5

    
           case *tree.Insert: 
        
           	return b.processWiths(stmt.With, inScope, func(inScope *scope) *scope { 
        
           		return b.buildInsert(stmt, inScope)

in pkg/sql/opt/optbuilder.(*Builder).buildStmt

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 240 to 242 in c7cfac5

    
           b.ctes = nil 
        
           outScope = b.buildStmt(stmt, desiredTypes, inScope) 
        
           // Build With operators for any CTEs hoisted to the top level.

in pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 214 to 216 in c7cfac5

    
           // and physical properties. 
        
           outScope := b.buildStmtAtRoot(b.stmt, nil /* desiredTypes */)

in pkg/sql/opt/optbuilder.(*Builder).Build

cockroach/pkg/sql/plan_opt.go

Lines 379 to 381 in c7cfac5

    
           bld.KeepPlaceholders = true 
        
           if err := bld.Build(); err != nil { 
        
           	return nil, err

in pkg/sql.(*optPlanningCtx).buildReusableMemo

cockroach/pkg/sql/plan_opt.go

Lines 122 to 124 in c7cfac5

    
           memo, err := opc.buildReusableMemo(ctx) 
        
           if err != nil {

in pkg/sql.(*planner).prepareUsingOptimizer

cockroach/pkg/sql/conn_executor_prepare.go

Lines 286 to 288 in c7cfac5

    
           // future. 
        
           flags, err := p.prepareUsingOptimizer(ctx) 
        
           if err != nil {

in pkg/sql.(*connExecutor).populatePrepared

cockroach/pkg/sql/conn_executor_prepare.go

Lines 219 to 221 in c7cfac5

    
           p.semaCtx.Annotations = tree.MakeAnnotations(stmt.NumAnnotations) 
        
           flags, err = ex.populatePrepared(ctx, txn, placeholderHints, p) 
        
           return err

in pkg/sql.(*connExecutor).prepare.func1

cockroach/pkg/sql/conn_executor_prepare.go

Lines 225 to 227 in c7cfac5

    
           // Use the existing transaction. 
        
           if err := prepare(ctx, txn); err != nil { 
        
           	return nil, err

in pkg/sql.(*connExecutor).prepare

cockroach/pkg/sql/conn_executor_prepare.go

Lines 110 to 112 in c7cfac5

    
           // Prepare the query. This completes the typing of placeholders. 
        
           prepared, err := ex.prepare(ctx, stmt, placeholderHints, rawTypeHints, origin) 
        
           if err != nil {

in pkg/sql.(*connExecutor).addPreparedStmt

cockroach/pkg/sql/conn_executor_prepare.go

Lines 52 to 54 in c7cfac5

    
           stmt := makeStatement(parseCmd.Statement, ex.generateID()) 
        
           ps, err := ex.addPreparedStmt( 
        
           	ctx,

in pkg/sql.(*connExecutor).execPrepare

cockroach/pkg/sql/conn_executor.go

Lines 1796 to 1798 in c7cfac5

    
           	stmtCtx := withStatement(ctx, ex.curStmtAST) 
        
           	ev, payload = ex.execPrepare(stmtCtx, tcmd) 
        
           case DescribeStmt:

in pkg/sql.(*connExecutor).execCmd

cockroach/pkg/sql/conn_executor.go

Lines 1628 to 1630 in c7cfac5

    
           var err error 
        
           if err = ex.execCmd(ex.Ctx()); err != nil { 
        
           	if errors.IsAny(err, io.EOF, errDrainingComplete) {

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/conn_executor.go

Lines 667 to 669 in c7cfac5

    
           	}() 
        
           	return h.ex.run(ctx, s.pool, reserved, cancel) 
        
           }

in pkg/sql.(*Server).ServeConn

cockroach/pkg/sql/pgwire/conn.go

Lines 647 to 649 in c7cfac5

    
           	reservedOwned = false // We're about to pass ownership away. 
        
           	retErr = sqlServer.ServeConn(ctx, connHandler, reserved, cancelConn) 
        
           }()

in pkg/sql/pgwire.(*conn).processCommandsAsync.func1
/usr/local/go/src/runtime/asm_amd64.s#L1370-L1372 in runtime.goexit

pkg/sql/sem/tree/datum.go in pkg/sql/sem/tree.MustBeDArray at line 3946
pkg/sql/sem/tree/eval.go in pkg/sql/sem/tree.glob..func138 at line 2567
pkg/sql/opt/norm/fold_constants_funcs.go in pkg/sql/opt/norm.(*CustomFuncs).FoldComparison at line 439
pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).ConstructContainedBy at line 16766
pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).Replace at line 22244
pkg/sql/opt/norm/inline_funcs.go in pkg/sql/opt/norm.(*CustomFuncs).inlineConstants.func1 at line 93
pkg/sql/opt/norm/inline_funcs.go in pkg/sql/opt/norm.(*CustomFuncs).inlineConstants at line 95
pkg/sql/opt/norm/inline_funcs.go in pkg/sql/opt/norm.(*CustomFuncs).InlineProjectionConstants at line 55
pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).ConstructProject at line 1349
pkg/sql/opt/optbuilder/project.go in pkg/sql/opt/optbuilder.(*Builder).constructProject at line 61
pkg/sql/opt/optbuilder/project.go in pkg/sql/opt/optbuilder.(*Builder).constructProjectForScope at line 36
pkg/sql/opt/optbuilder/mutation_builder.go in pkg/sql/opt/optbuilder.(*mutationBuilder).addCheckConstraintCols at line 908
pkg/sql/opt/optbuilder/insert.go in pkg/sql/opt/optbuilder.(*mutationBuilder).buildInsert at line 669
pkg/sql/opt/optbuilder/insert.go in pkg/sql/opt/optbuilder.(*Builder).buildInsert at line 288
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmt.func2 at line 293
pkg/sql/opt/optbuilder/with.go in pkg/sql/opt/optbuilder.(*Builder).processWiths at line 111
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmt at line 292
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot at line 241
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).Build at line 215
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).buildReusableMemo at line 380
pkg/sql/plan_opt.go in pkg/sql.(*planner).prepareUsingOptimizer at line 123
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).populatePrepared at line 287
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).prepare.func1 at line 220
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).prepare at line 226
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).addPreparedStmt at line 111
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).execPrepare at line 53
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 1797
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 1629
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 668
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 648
/usr/local/go/src/runtime/asm_amd64.s in runtime.goexit at line 1371

Tag	Value
Cockroach Release	`v21.2.6`
Cockroach SHA:	`c7cfac5`
Platform	linux amd64
Distribution	CCL
Environment	v21.2.6
Command	start-single-node
Go Version	``
# of CPUs
# of Goroutines

Jira issue: CRDB-13748

gz#11753

The text was updated successfully, but these errors were encountered:

moogzy · 2022-03-16T10:54:57Z

Hi Cockroach team,

We upgraded to 21.2.6 and have started to observe this error.

What's the mitigation here? What are we exposed to with this issue (i.e what's the impact to the cluster?)

michae2 · 2022-03-16T17:22:13Z

From the stack trace we can tell that this is caused by a query using the <@ operator which ends up with NULL on the left side when folding constants in the optimizer. (But of course NULL is a legal operand for <@ so I'm a little puzzled.)

It would help to have the query, if we can find it.

None of these cause the error, so it's not something obvious:

SELECT NULL <@ NULL;
SELECT NULL <@ ARRAY[]:::int[];
SELECT NULL <@ ARRAY[1];
SELECT (NULL <@ ARRAY[1]) <@ ARRAY[2];
SELECT a <@ ARRAY[1,2,3] FROM (VALUES (NULL)) AS v(a);

michae2 · 2022-03-16T17:35:05Z

The other two sentry reports show an INSERT and an UPDATE so maybe we're looking for modifications to a table with an array column?

mqdeandrade · 2022-03-16T17:45:41Z

@michae2 for us it happens when inserting null into a nullable ARRAY column. Inserting an empty array doesn't exhibit the behaviour. Before the upgrade, null into a nullable ARRAY column worked without an issue.

michae2 · 2022-03-16T17:49:16Z

Aha, here's one way to hit it:

PREPARE s AS SELECT $1:::INT[] <@ $2:::INT[];
EXECUTE s (NULL, ARRAY[1]);

[email protected]:26257/defaultdb> EXECUTE s (NULL, ARRAY[1]);
ERROR: internal error: expected *DArray, found tree.dNull
SQLSTATE: XX000
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/datum.go:4233: MustBeDArray()
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval.go:2577: func138()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/fold_constants_funcs.go:465: FoldComparison()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:16862: ConstructContainedBy()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:24052: CopyAndReplaceDefault()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:293: func2()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:24859: invokeReplace()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:24848: copyAndReplaceDefaultScalarListExpr()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:23889: CopyAndReplaceDefault()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:293: func2()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:24859: invokeReplace()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:24848: copyAndReplaceDefaultScalarListExpr()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:23548: CopyAndReplaceDefault()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:293: func2()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:24859: invokeReplace()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:252: CopyAndReplace()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.go:295: AssignPlaceholders()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:468: reuseMemo()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:501: buildExecMemo()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:213: makeOptimizerPlan()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1320: makeExecPlan()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1014: dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:685: execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:143: execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1846: func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1850: execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1779: run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:746: ServeConn()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:724: func1()
runtime/asm_amd64.s:1581: goexit()

HINT: You have encountered an unexpected error.

Please check the public issue tracker to check whether this problem is
already tracked. If you cannot find it there, please report the error
with details by creating a new issue.

If you would rather not post publicly, please contact us directly
using the support form.

We appreciate your feedback.

michae2 · 2022-03-16T18:11:14Z

@mqdeandrade I see, thank you, that helps. Do you happen to have the SHOW CREATE TABLE? It looks like this might be related to a check constraint on the table.

michae2 · 2022-03-16T18:23:01Z

Thanks to @moogzy we saw that the table does indeed have a check constraint using <@ so this looks like a repro:

CREATE TABLE t (a STRING[] NULL, CHECK (a <@ ARRAY['x']));
INSERT INTO t VALUES (NULL);

Demonstration:

[email protected]:26257/defaultdb> INSERT INTO t VALUES (NULL);
ERROR: internal error: expected *DArray, found tree.dNull
SQLSTATE: XX000
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/datum.go:3946: MustBeDArray()
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval.go:2567: func138()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/fold_constants_funcs.go:439: FoldComparison()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:16766: ConstructContainedBy()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:22244: Replace()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/inline_funcs.go:93: func1()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/inline_funcs.go:95: inlineConstants()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/inline_funcs.go:55: InlineProjectionConstants()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:1349: ConstructProject()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/project.go:61: constructProject()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/project.go:36: constructProjectForScope()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/mutation_builder.go:908: addCheckConstraintCols()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/insert.go:669: buildInsert()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/insert.go:288: buildInsert()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:293: func2()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/with.go:111: processWiths()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:292: buildStmt()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:241: buildStmtAtRoot()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:215: Build()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:521: buildExecMemo()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:194: makeOptimizerPlan()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1260: makeExecPlan()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:972: dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:709: execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:129: execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1705: func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1707: execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1629: run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:668: ServeConn()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:648: func1()
runtime/asm_amd64.s:1581: goexit()

HINT: You have encountered an unexpected error.

Please check the public issue tracker to check whether this problem is
already tracked. If you cannot find it there, please report the error
with details by creating a new issue.

If you would rather not post publicly, please contact us directly
using the support form.

We appreciate your feedback.

michae2 · 2022-03-16T19:37:50Z

Interesting, this only reproduces for the <@ operator, when the column is first and a constant second, using both array and json. Not the @> operator or other array operators.

CREATE TABLE arraycontainedby (a STRING[], CHECK (a <@ ARRAY['x']));
CREATE TABLE arraycontainedbyrev (a STRING[], CHECK (ARRAY['x'] <@ a));
CREATE TABLE arraycontainedbyboth (a STRING[], CHECK (a <@ a));
CREATE TABLE arraycontains (a STRING[], CHECK (a @> ARRAY['x']));
CREATE TABLE arraycontainsrev (a STRING[], CHECK (ARRAY['x'] @> a));
CREATE TABLE arrayoverlaps (a STRING[], CHECK (a && ARRAY['x']));
CREATE TABLE jsoncontainedby (j JSONB, CHECK (j <@ '["x"]'::JSONB));
CREATE TABLE jsoncontainedbyrev (j JSONB, CHECK ('["x"]'::JSONB <@ j));
CREATE TABLE jsoncontainedbyboth (j JSONB, CHECK (j <@ j));
CREATE TABLE jsoncontains (j JSONB, CHECK (j @> '["x"]'::JSONB));
CREATE TABLE jsoncontainsrev (j JSONB, CHECK ('["x"]'::JSONB @> j));
CREATE TABLE jsonexists (j JSONB, CHECK (j ? 'x'));
CREATE TABLE intgt (i INT, CHECK (i > 0));

INSERT INTO arraycontainedby VALUES (NULL);      -- error
INSERT INTO arraycontainedbyrev VALUES (NULL);
INSERT INTO arraycontainedbyboth VALUES (NULL);
INSERT INTO arraycontains VALUES (NULL);
INSERT INTO arraycontainsrev VALUES (NULL);
INSERT INTO arrayoverlaps VALUES (NULL);
INSERT INTO jsoncontainedby VALUES (NULL);       -- error
INSERT INTO jsoncontainedbyrev VALUES (NULL);
INSERT INTO jsoncontainedbyboth VALUES (NULL);
INSERT INTO jsoncontains VALUES (NULL);
INSERT INTO jsoncontainsrev VALUES (NULL);
INSERT INTO jsonexists VALUES (NULL);
INSERT INTO intgt VALUES (NULL);

This suggests a simple workaround is to change CHECK (a <@ ARRAY[...]) to CHECK (ARRAY[...] @> a) while we figure out the problem.

michae2 · 2022-03-17T05:29:56Z

Here's an even simpler repro:

SELECT NULL::STRING[] <@ ARRAY['x'];

(Apparently type checking has its own constant folding which was hiding this failure to constant fold in the optimizer.)

77875: sql: use IndexFetchSpec for inverted joiner r=RaduBerinde a=RaduBerinde #### rowexec: address TODO in inverted joiner This commit addresses a TODO in the inverted joiner. We now reuse a buffer for encoding the prefix key. In the general case we still need to make a copy since we are storing multiple prefix keys; but now we try to reuse the last copy if the prefix is the same. We also remove the temporary use of `indexRow` which is confusing here (it wasn't obvious at first but this code has nothing to do with index rows and is just using `indexRow` as a temporary buffer). Release note: None #### geoindex: minor cleanup around Config This change changes `IsEmptyConfig`, `IsGeographyConfig`, `IsGeometryConfig` to methods on the `geoindex.Config` type. We also switch to passing configs by value which is cleaner and avoids some allocations. Release note: None #### sql: use IndexFetchSpec for inverted joiner This commit reworks the InvertedJoiner to use an IndexFetchSpec instead of table and index descriptors. The "internal schema" now matches the fetched columns (leading to simplifications in both planning and execution code). Release note: None 77878: kvstreamer: re-enable streamer by default r=yuzefovich a=yuzefovich Release note: None 77968: sql: keep experimental_enable_hash_sharded_indexes var as noop r=chengxiong-ruan a=chengxiong-ruan Fixes #77954 Release justification: needed for session var backward compatibility. Release note (sql change): experimental_enable_hash_sharded_indexes used to be set to enable the hash sharded index feature. since we now enable the feature by default, user don't need to set this var anymore. But still keeping it as noop for backward compatibility. 77995: opt: add ContainedBy operator (<@) to FoldNullComparisonLeft norm rule r=msirek,mgartner a=michae2 Fixes: #77745 When we originally made the ContainedBy operator (<`@)` distinct from the Contains operator (`@>)` we forgot to add ContainedBy to the FoldNullComparisonLeft normalization rule. It was only added to the FoldNullComparisonRight rule. Correct this. Release note (bug fix): fix an optimizer bug that prevented expressions of the form (NULL::STRING[] <@ ARRAY['x']) from being folded to NULL. 78013: roachtest: fix handling of test panics r=erikgrinaker a=tbg - roachtest: fix handling of test panics - roachtest: gracefully fail in sst-corruption test 78023: roachprod: update thrift artifact url for use with charybdefs r=tbg a=nicktrav The version of Thrift used in tests that use `charybdefs` has disappeared from the Apache artifacts repository that is used currently, which causes any roachtest that depends on `charybdefs` to fail due to not being able to fetch the artifact it needs. Update the artifact URL to pull from the Apache archive instead. Touches #78006,#78007,#78008,#78010,#78015,#78016. Release note: None. Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Michael Erickson <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Nick Travers <[email protected]>

Fixes: #77745 When we originally made the ContainedBy operator (<@) distinct from the Contains operator (@>) we forgot to add ContainedBy to the FoldNullComparisonLeft normalization rule. It was only added to the FoldNullComparisonRight rule. Correct this. Release note (bug fix): fix an optimizer bug that prevented expressions of the form (NULL::STRING[] <@ ARRAY['x']) from being folded to NULL.

Fixes: #77745 When we originally made the ContainedBy operator (<@) distinct from the Contains operator (@>) we forgot to add ContainedBy to the FoldNullComparisonLeft normalization rule. It was only added to the FoldNullComparisonRight rule. Correct this. Release note (bug fix): fix an optimizer bug that prevented expressions of the form (NULL::STRING[] <@ ARRAY['x']) from being folded to NULL. Release justification: high priority bug fix.

Fixes: #77745 When we originally made the ContainedBy operator (<@) distinct from the Contains operator (@>) we forgot to add ContainedBy to the FoldNullComparisonLeft normalization rule. It was only added to the FoldNullComparisonRight rule. Correct this. Release note (bug fix): fix an optimizer bug that prevented expressions of the form (NULL::STRING[] <@ ARRAY['x']) from being folded to NULL. This bug was introduced in v21.2.0. Release justification: high priority bug fix.

cockroach-teamcity added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. labels Mar 14, 2022

blathers-crl bot added the T-sql-queries SQL Queries Team label Mar 15, 2022

michae2 added the A-sql-optimizer SQL logical planning and optimizations. label Mar 16, 2022

michae2 self-assigned this Mar 16, 2022

yuzefovich mentioned this issue Mar 17, 2022

sentry: datum.go:3946: expected *DArray, found tree.dNull -- *errutil.leafError: expected *DArray, found tree.dNull (1) datum.go:3946: *withstack.withStack (top exception) *assert.withAssertionFailure (check the extra data payloads) #77957

Closed

michae2 mentioned this issue Mar 17, 2022

opt: add ContainedBy operator (<@) to FoldNullComparisonLeft norm rule #77995

Merged

craig bot closed this as completed in 3765603 Mar 17, 2022

craig bot closed this as completed in #77995 Mar 17, 2022

blathers-crl bot mentioned this issue Mar 17, 2022

release-21.2: opt: add ContainedBy operator (<@) to FoldNullComparisonLeft norm rule #78039

Merged

blathers-crl bot mentioned this issue Mar 17, 2022

release-22.1: opt: add ContainedBy operator (<@) to FoldNullComparisonLeft norm rule #78042

Merged

mgartner added this to SQL Queries Jul 24, 2023

mgartner moved this to Done in SQL Queries Jul 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sql: v21.2.6: expected *DArray, found tree.dNull when folding a comparison #77745

sql: v21.2.6: expected *DArray, found tree.dNull when folding a comparison #77745

cockroach-teamcity commented Mar 14, 2022 •

edited by RoachietheSupportRoach

Loading

moogzy commented Mar 16, 2022

michae2 commented Mar 16, 2022

michae2 commented Mar 16, 2022

mqdeandrade commented Mar 16, 2022

michae2 commented Mar 16, 2022

michae2 commented Mar 16, 2022

michae2 commented Mar 16, 2022 •

edited

Loading

michae2 commented Mar 16, 2022

michae2 commented Mar 17, 2022

sql: v21.2.6: expected *DArray, found tree.dNull when folding a comparison #77745

sql: v21.2.6: expected *DArray, found tree.dNull when folding a comparison #77745

Comments

cockroach-teamcity commented Mar 14, 2022 • edited by RoachietheSupportRoach Loading

moogzy commented Mar 16, 2022

michae2 commented Mar 16, 2022

michae2 commented Mar 16, 2022

mqdeandrade commented Mar 16, 2022

michae2 commented Mar 16, 2022

michae2 commented Mar 16, 2022

michae2 commented Mar 16, 2022 • edited Loading

michae2 commented Mar 16, 2022

michae2 commented Mar 17, 2022

cockroach-teamcity commented Mar 14, 2022 •

edited by RoachietheSupportRoach

Loading

michae2 commented Mar 16, 2022 •

edited

Loading