-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22.1 Acceptance Testing UI Updates #77982
Comments
Hi @maryliag, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This commit introduces ui fixes on the Database page (and other child pages of it): Partially addresses cockroachdb#77982 - Auto Stats circle is no longer cut off - Added the link style to the link on Auto Stats tooltip - Updated tooltip message on reset index stats to add `from the time the index was created or had its stats reset` - Updated the reset stats link when hover to use the correct blue and add underline - Adjusted alignment of summary cards inside Table details Release note: None
This commit introduces ui fixes on Session and Session Details page: - Show all columns by default - Update actions dropdown from Terminate to Cancel - Update Cancel Statement and Cancel Sessions Modal to update from Terminate to Cancel and remove `?` - Update Cancel Statement success message to `Statement` - Update Cancel Query to Cancel Statement - Right align nodes with larger names - Update color and hover on Node link Partially addresses cockroachdb#77982 Release note: None
77684: pkg/server: add pagination fields to TenantRanges/Ranges request/response protos r=rimadeodhar a=abarganier The `(*statusServer).Ranges()` endpoint currently supports pagination under the hood, but this functionality is not accessible via RPC requests. Instead, pagination is only currently available via api_v2. There are multiple callers of the `Ranges()` endpoint outside of api_v2 (e.g. `debug zip`) that could benefit from having this pagination functionality unlocked. Therefore, this change adds `limit` and `offset` fields to the associated request object, and a `next` field to the response object. This allows gRPC callers to leverage the offset pagination already in place. Now that `Ranges()` supports pagination for gRPC clients, we can extend that pagination functionality to the `TenantRanges` endpoint as well. The pagination for `TenantRanges()` will limit the number of results returned *by each node*. This means that a `limit = 100` value for a tenant whose ranges are replicated three times, will return 300 results (100 results for each node containing a Replica). Release note: none Release justification: Low risk, high benefit changes to existing functionality 77871: backupccl: allow SHOW BACKUP FILES/RANGES/SCHEMAS in backup collections r=adityamaru,dt a=msbutler Fixes #77697 Release justification: low risk bug fixes Release note: SHOW BACKUP SCHEMAS can be called with SHOW BACKUP IN syntax. 78050: ui: fix broken links to statement details r=maryliag a=maryliag Previously the statement links on Advanced Debug and Sessions page that would open the Statement Details page were crashing. This commits fixes the correcy path on the Advanced Debug link and removes the link on the Sessions page, since that one would not make sense for active queries. In the future we can add link for past queries. This commits also fixes the position of the Statement on the Sessions table. Fixes #77978 Previous alignment <img width="836" alt="Screen Shot 2022-03-17 at 5 18 11 PM" src="https://user-images.githubusercontent.com/1017486/158897680-9c77db56-f16e-4157-b051-97338bc5674b.png"> Fixed alignment <img width="993" alt="Screen Shot 2022-03-17 at 5 13 54 PM" src="https://user-images.githubusercontent.com/1017486/158897703-55310df1-5b52-4856-94f7-6d30d81acdae.png"> Release note (bug fix): Fix broken links to Statement Details page on Advanced Debug and Sessions page. 78084: ui: ui updates to Database page r=maryliag a=maryliag This commit introduces ui fixes on the Database page (and other child pages of it) Partially addresses #77982 - Auto Stats circle is no longer cut off Before <img width="265" alt="Screen Shot 2022-03-18 at 10 20 26 AM" src="https://user-images.githubusercontent.com/1017486/159035594-ab378c69-657d-4898-90cb-500aeb7775c5.png"> After <img width="288" alt="Screen Shot 2022-03-18 at 10 23 14 AM" src="https://user-images.githubusercontent.com/1017486/159035651-bcf4eb96-4568-4c45-9115-48476233bba3.png"> - Added the link style to the link on Auto Stats tooltip <img width="299" alt="Screen Shot 2022-03-18 at 10 45 17 AM" src="https://user-images.githubusercontent.com/1017486/159035698-3aa337c3-e6cb-42bf-aa60-a9d6ba78d9bf.png"> - Updated tooltip message on reset index stats to add `from the time the index was created or had its stats reset` Before <img width="381" alt="Screen Shot 2022-03-18 at 11 13 38 AM" src="https://user-images.githubusercontent.com/1017486/159035750-1af30635-aebb-47f9-b40a-d4bf9debe67a.png"> After <img width="313" alt="Screen Shot 2022-03-18 at 11 15 03 AM" src="https://user-images.githubusercontent.com/1017486/159035788-b30153dd-1a1b-4aca-b8c0-62fb42614281.png"> - Updated the reset stats link when hover to use the correct blue and add underline <img width="242" alt="Screen Shot 2022-03-18 at 11 35 02 AM" src="https://user-images.githubusercontent.com/1017486/159035996-3d2a0b7c-4ac9-4ec0-a004-424dff4595a4.png"> - Adjusted alignment of summary cards inside Table details Before <img width="357" alt="Screen Shot 2022-03-18 at 11 26 17 AM" src="https://user-images.githubusercontent.com/1017486/159035880-21f75ad2-3c6d-4ece-ad7d-c12500ef25c9.png"> After <img width="443" alt="Screen Shot 2022-03-18 at 11 31 21 AM" src="https://user-images.githubusercontent.com/1017486/159035944-8c19eaae-4fc6-4855-b597-17589fce115e.png"> Release note: None Co-authored-by: Alex Barganier <[email protected]> Co-authored-by: Michael Butler <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]>
This commit introduces ui fixes on the Database page (and other child pages of it): Partially addresses #77982 - Auto Stats circle is no longer cut off - Added the link style to the link on Auto Stats tooltip - Updated tooltip message on reset index stats to add `from the time the index was created or had its stats reset` - Updated the reset stats link when hover to use the correct blue and add underline - Adjusted alignment of summary cards inside Table details Release note: None
This commit introduces fixes to Statements Page: - Update style of link on tooltip for diagnostic status and add space before `When` - Remove word `current` from the Cancel Diagnostics request - Slow loading message only show after a few seconds of page loading - Space between item (seach / filter/ time picker) are now 12px and the size of both dividers are the same (using the heigh of all items) - Update color of alert message on Conditional Diagnostic Request - Change `trace` to `diagnostic bundle` - Update link color/underline on hover for node and app name Partially addresses cockroachdb#77982 Release note: None
78097: ui: ui updates to Sessions page r=maryliag a=maryliag This commit introduces ui fixes on Session and Session Details page: - Show all columns by default - Update actions dropdown from Terminate to Cancel Before <img width="201" alt="Screen Shot 2022-03-18 at 12 45 56 PM" src="https://user-images.githubusercontent.com/1017486/159063901-3441465f-9b18-489f-a708-300a4c69b78b.png"> After <img width="229" alt="Screen Shot 2022-03-18 at 12 51 57 PM" src="https://user-images.githubusercontent.com/1017486/159063946-355f8cda-6c09-4e82-a41e-9808d328b6be.png"> - Update Cancel Statement and Cancel Sessions Modal to update from Terminate to Cancel and remove `?` Before <img width="622" alt="Screen Shot 2022-03-18 at 12 45 41 PM" src="https://user-images.githubusercontent.com/1017486/159064111-99555900-733d-4e1c-b115-e929e473f3ba.png"> <img width="604" alt="Screen Shot 2022-03-18 at 12 45 50 PM" src="https://user-images.githubusercontent.com/1017486/159064139-ae58151e-12f3-4887-8507-eb4ecf665bc4.png"> After <img width="597" alt="Screen Shot 2022-03-18 at 12 58 39 PM" src="https://user-images.githubusercontent.com/1017486/159064308-a5772b4a-c523-4a8b-a2dd-587b2a4d7814.png"> <img width="613" alt="Screen Shot 2022-03-18 at 12 58 58 PM" src="https://user-images.githubusercontent.com/1017486/159064322-71c5910c-de8c-4de0-a4e3-25b49a04ccbe.png"> - Update Cancel Statement success message to `Statement` Before <img width="538" alt="Screen Shot 2022-03-18 at 12 53 00 PM" src="https://user-images.githubusercontent.com/1017486/159064225-6eaca061-86a2-4bb8-bdc2-0cad482dc7fe.png"> After <img width="541" alt="Screen Shot 2022-03-18 at 12 56 53 PM" src="https://user-images.githubusercontent.com/1017486/159064267-b30de8ad-aa0b-442b-94d8-6d04daac08db.png"> - Update Cancel Query to Cancel Statement Before <img width="392" alt="Screen Shot 2022-03-18 at 12 59 39 PM" src="https://user-images.githubusercontent.com/1017486/159064413-6e9b27cc-6b4c-459b-a4d4-e1f31555b30f.png"> After <img width="366" alt="Screen Shot 2022-03-18 at 1 01 06 PM" src="https://user-images.githubusercontent.com/1017486/159063589-57da86fb-2456-4ca8-b843-f285c5a67540.png"> - Right align nodes with larger names Before <img width="546" alt="Screen Shot 2022-03-18 at 1 13 50 PM" src="https://user-images.githubusercontent.com/1017486/159063708-ed07077e-036e-4339-a542-2df99214fb96.png"> After <img width="578" alt="Screen Shot 2022-03-18 at 1 15 30 PM" src="https://user-images.githubusercontent.com/1017486/159063748-0e37aded-b049-4254-adca-122d53a59b81.png"> - Update color and hover on Node link Before <img width="568" alt="Screen Shot 2022-03-18 at 1 02 10 PM" src="https://user-images.githubusercontent.com/1017486/159063640-81619657-b099-4eb9-9d1e-48738269e2a2.png"> After <img width="241" alt="Screen Shot 2022-03-18 at 1 17 23 PM" src="https://user-images.githubusercontent.com/1017486/159063784-2eeaa137-504b-4548-8062-a83c74d4513b.png"> Partially addresses #77982 Release note: None 78106: ui: ui updates to Statements Page r=maryliag a=maryliag This commit introduces fixes to Statements Page: - Update style of link on tooltip for diagnostic status and add space before `When` Before <img width="504" alt="Screen Shot 2022-03-18 at 3 57 22 PM" src="https://user-images.githubusercontent.com/1017486/159090521-b99f2721-5e02-4aee-af93-629292256fa5.png"> After <img width="483" alt="Screen Shot 2022-03-18 at 3 57 13 PM" src="https://user-images.githubusercontent.com/1017486/159090544-84248037-b599-430c-9d79-338c736293b7.png"> - Remove word `current` from the Cancel Diagnostics request Before <img width="334" alt="Screen Shot 2022-03-18 at 3 58 01 PM" src="https://user-images.githubusercontent.com/1017486/159090581-96a5dd16-2e46-42ad-9340-f264d72bacdb.png"> After <img width="229" alt="Screen Shot 2022-03-18 at 3 58 44 PM" src="https://user-images.githubusercontent.com/1017486/159090593-1cf444c9-85c8-484c-a095-c84a2532b91b.png"> - Slow loading message only show after a few seconds of page loading Video: https://www.loom.com/share/dd9f41fc00994a1ea852747e6606afc7 - Space between item (search / filter/ time picker) are now 12px and the size of both dividers are the same (using the heigh of all items) Before <img width="1253" alt="Screen Shot 2022-03-18 at 4 35 29 PM" src="https://user-images.githubusercontent.com/1017486/159090649-0e23f766-63fb-40ae-ae68-04ffa1987ced.png"> After <img width="1156" alt="Screen Shot 2022-03-18 at 6 03 25 PM" src="https://user-images.githubusercontent.com/1017486/159090718-1ab25df0-0da9-43cb-b29b-9c5351f001de.png"> - Update color of alert message on Conditional Diagnostic Request Before <img width="504" alt="Screen Shot 2022-03-18 at 5 08 52 PM" src="https://user-images.githubusercontent.com/1017486/159090753-f1f62533-2392-462d-beaa-f479665bcc30.png"> After <img width="516" alt="Screen Shot 2022-03-18 at 5 16 18 PM" src="https://user-images.githubusercontent.com/1017486/159090767-acef5ea6-23ab-486e-a1c5-d9ada1eb0ffc.png"> - Change `trace` to `diagnostic bundle` Before <img width="343" alt="Screen Shot 2022-03-18 at 5 21 03 PM" src="https://user-images.githubusercontent.com/1017486/159090803-f2a4547e-3792-4133-89b5-a72757c3f1fa.png"> After <img width="374" alt="Screen Shot 2022-03-18 at 5 43 18 PM" src="https://user-images.githubusercontent.com/1017486/159090817-eff5e19f-29da-4d2c-95e2-fceb780d152c.png"> - Update link color/underline on hover for node and app name Before <img width="182" alt="Screen Shot 2022-03-18 at 5 46 34 PM" src="https://user-images.githubusercontent.com/1017486/159090832-06aa3a90-0488-4b4a-a7d4-0430b37da370.png"> After <img width="202" alt="Screen Shot 2022-03-18 at 5 53 04 PM" src="https://user-images.githubusercontent.com/1017486/159090845-1d7b0428-7c79-4f88-a7e2-bb4efa692681.png"> Partially addresses #77982 Release note: None 78122: kvserver: disable merge queue until kvsubscriber has updated r=irfansharif a=irfansharif If we don't have any span configs available, enabling range merges would be extremely dangerous -- we could collapse everything into a single range. We've observed this happen when the kvsubscriber's initial scan overflows its bounded buffer, preventing it from ever getting a snapshot. A future commit will fix the bounded memory issue, but the side-effect pointed out the need for this important safe guard. Informs #77687. Release justification: bug fix Release note: None Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: irfan sharif <[email protected]>
This commit introduces ui fixes on Session and Session Details page: - Show all columns by default - Update actions dropdown from Terminate to Cancel - Update Cancel Statement and Cancel Sessions Modal to update from Terminate to Cancel and remove `?` - Update Cancel Statement success message to `Statement` - Update Cancel Query to Cancel Statement - Right align nodes with larger names - Update color and hover on Node link Partially addresses #77982 Release note: None
This commit introduces fixes to Statements Page: - Update style of link on tooltip for diagnostic status and add space before `When` - Remove word `current` from the Cancel Diagnostics request - Slow loading message only show after a few seconds of page loading - Space between item (seach / filter/ time picker) are now 12px and the size of both dividers are the same (using the heigh of all items) - Update color of alert message on Conditional Diagnostic Request - Change `trace` to `diagnostic bundle` - Update link color/underline on hover for node and app name Partially addresses #77982 Release note: None
This commits makes ui improvements: - Change order of tabs on Statement Details and change Explain Plan to plural - Use one decimal point on Plans Table - Update Text on Statement Diagnostics Modal - Fix radio button selection on Statement Diagnostic Modal Partially Adresses cockroachdb#77982 Fixes cockroachdb#78364 Fixes cockroachdb#78369 Release note: None
76869: backupccl: backup checkpoint files are now versioned and never deleted r=DarrylWong a=DarrylWong This change teaches backup and restore to no longer overwrite or delete any checkpoint files, and instead write a new version side by side with the old, and to read these new versioned checkpoints. To make sure that older backup chains and mixed clusters are not broken by this change, we only write to the progress directory if it is not a pure v22.1 or later cluster. This logic can be removed in a post 22.1 release when we no longer write to the base directory. This change is so we can in the future, no longer require write access for backups. Release Justification: release blocker Release Note enterprise: Checkpoint files are no longer overwritten and now versioned and written side by side in the /progress directory. Temporary checkpoint files are no longer written. 78564: jobs: Rewrite job scheduler query logic. r=miretskiy a=miretskiy Prior to this change, job scheduler would lookup a set of schedules to execute, and it would lock each schedule via `FOR UPDATE` clause. The query was a complext query that also performed joins on `system.job` table. This resulted in a larger read set of rows being locked, and it made transaction restarts more expensive. This PR modifies the querying logic so that the scheduler first obtains a set of potential schedules to execute. Then, each schedule executes under its own transaction, where only a single schedule is locked for update (to guarantee only one scheduler executes this schedule). Release Notes (enterprise change): Job scheduler is more efficient and should no longer lock-up jobs and scheduled jobs tables. Release Justification: Stability improvement for scheduled jobs system. 78959: sql: support SHOW DEFAULT PRIVILEGES IN SCHEMA r=rafiss a=RichardJCai fixes #77256 Release note (sql change): Add support for show default privileges in schema. The SHOW DEFAULT PRIVILEGES clause now supports optionally passing a schema name. SHOW DEFAULT PRIVILEGES [opt_for_role] [opt_schema_name] Example: ``` SHOW DEFAULT PRIVILEGES IN SCHEMA s2 ---- role for_all_roles object_type grantee privilege_type testuser false tables testuser2 DROP testuser false tables testuser2 SELECT testuser false tables testuser2 UPDATE SHOW DEFAULT PRIVILEGES FOR ROLE testuser IN SCHEMA s2 ---- role for_all_roles object_type grantee privilege_type testuser false tables testuser2 DROP testuser false tables testuser2 SELECT testuser false tables testuser2 UPDATE ``` 79142: ui: ui improvements r=maryliag a=maryliag This commits makes ui improvements: - Change order of tabs on Statement Details and change Explain Plan to plural Before <img width="623" alt="Screen Shot 2022-03-31 at 11 45 56 AM" src="https://user-images.githubusercontent.com/1017486/161096229-d9fa1bb5-3ffc-4913-a96d-e1c8f1e2379b.png"> After <img width="587" alt="Screen Shot 2022-03-31 at 10 07 51 AM" src="https://user-images.githubusercontent.com/1017486/161096000-aea6f7fb-3883-4b73-89dd-fe122f89813b.png"> - Use one decimal point on Plans Table Before <img width="269" alt="Screen Shot 2022-03-30 at 4 42 15 PM" src="https://user-images.githubusercontent.com/1017486/161095849-d753f0aa-c582-4276-b0aa-a254020f9419.png"> After <img width="207" alt="Screen Shot 2022-03-30 at 6 28 00 PM" src="https://user-images.githubusercontent.com/1017486/161095872-4f7fccea-3270-4868-b145-52c4ddbb80bb.png"> - Update Text on Statement Diagnostics Modal Before <img width="555" alt="Screen Shot 2022-03-31 at 11 46 49 AM" src="https://user-images.githubusercontent.com/1017486/161096430-2f1d9336-6098-49ae-bfec-1d1c11657fef.png"> After <img width="534" alt="Screen Shot 2022-03-31 at 3 48 48 PM" src="https://user-images.githubusercontent.com/1017486/161137169-0f5566a6-ed8b-4ce4-a217-a44708068d74.png"> - Fix radio button selection on Statement Diagnostic Modal Before <img width="142" alt="Screen Shot 2022-03-31 at 11 49 40 AM" src="https://user-images.githubusercontent.com/1017486/161097037-17f351ba-7470-4ac6-b4a0-0c1a85127a72.png"> After <img width="87" alt="Screen Shot 2022-03-31 at 3 27 26 PM" src="https://user-images.githubusercontent.com/1017486/161134171-555b48ca-28aa-48de-99ff-348b29a30992.png"> Partially Adresses #77982 Fixes #78364 Fixes #78369 Release note: None 79158: release: generate release archive checksums r=mari-crl a=rail Previously, we published release archives without their checksums. Without checksums there was a risk of downloading corrupt files without a way to verify their integrity. This patch adds a new functionality to generate checksums for the release archives and upload them next to the archive files. Fixes #79059 Release note: None Co-authored-by: Darryl <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]> Co-authored-by: richardjcai <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: Rail Aliiev <[email protected]>
This commits makes ui improvements: - Change order of tabs on Statement Details and change Explain Plan to plural - Use one decimal point on Plans Table - Update Text on Statement Diagnostics Modal - Fix radio button selection on Statement Diagnostic Modal Partially Adresses #77982 Fixes #78364 Fixes #78369 Release note: None
@kevin-v-ngo @maryliag I noticed another issue on the CC Serverless > Metrics page. The time picker is in 'UTC' but when I hover over the graphs, the time is is local (EDT). I was going to include this as part of this timeframe clean-up issue #78442 , but feels more like a higher priority bug |
Previously, there was no width assigned to timescale, making it have different size on CC Console. This commit adds the correct width so both DB and CC Console are aligned. Partially addresses: cockroachdb#77982 Release note: None
80473: ui: update width of timescale component r=maryliag a=maryliag Previously, there was no width assigned to timescale, making it have different size on CC Console. This commit adds the correct width so both DB and CC Console are aligned. Partially addresses: #77982 Release note: None Co-authored-by: Marylia Gutierrez <[email protected]>
Previously, there was no width assigned to timescale, making it have different size on CC Console. This commit adds the correct width so both DB and CC Console are aligned. Partially addresses: #77982 Release note: None
Previously, there was no width assigned to timescale, making it have different size on CC Console. This commit adds the correct width so both DB and CC Console are aligned. Partially addresses: #77982 Release note: None
Manually synced with Jira |
Databases/Tables overview pages
Table detail page
…from the time the index was created or had its stats reset.
(screenshot)Index detail page
Statement fingerprint overview page
Waiting
status tooltip (screenshot)diagnostics
link should be white and underlined - the same as on the statement detail page (currently showing up as black text)…When
Cancel diagnostics request
(remove the word 'current') (screenshot)Conditional statement bundle modal
Statement diagnostics history page (screenshot)
x traces
to xdiagnostics bundles
Session overview page
Terminate
toCancel
(screenshot)Terminate
toCancel
?
from the header copyQuery
toStatement
Session detail page
CC Serverless > Metrics page
Jobs
cancel-requested
,pause-requested
, andrevert-failed
statuses on the jobs page #71963)cc @kevin-v-ngo
Jira issue: CRDB-13883
The text was updated successfully, but these errors were encountered: