ui: ui updates to Statements Page #78106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces fixes to Statements Page: - Update style of link on tooltip for diagnostic status and add space before `When` - Remove word `current` from the Cancel Diagnostics request - Slow loading message only show after a few seconds of page loading - Space between item (seach / filter/ time picker) are now 12px and the size of both dividers are the same (using the heigh of all items) - Update color of alert message on Conditional Diagnostic Request - Change `trace` to `diagnostic bundle` - Update link color/underline on hover for node and app name Partially addresses cockroachdb#77982 Release note: None
|
This change is |
Annebirzin
approved these changes
Mar 18, 2022
matthewtodd
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! 2 of 0 LGTMs obtained (waiting on @maryliag)
|
bors r+ |
2 similar comments
|
bors r+ |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces fixes to Statements Page:
add space before
WhenBefore
After
currentfrom the Cancel Diagnostics requestBefore
After
Slow loading message only show after a few seconds of page loading
Video: https://www.loom.com/share/dd9f41fc00994a1ea852747e6606afc7
Space between item (search / filter/ time picker) are now 12px and
the size of both dividers are the same (using the heigh of all items)
Before
After
Before
After
tracetodiagnostic bundleBefore
After
Before
After
Partially addresses #77982
Release note: None