Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: ui: ui updates to Statements Page #78191

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 21, 2022

Backport 1/1 commits from #78106 on behalf of @maryliag.

/cc @cockroachdb/release


This commit introduces fixes to Statements Page:

  • Update style of link on tooltip for diagnostic status and
    add space before When
    Before

Screen Shot 2022-03-18 at 3 57 22 PM

After
Screen Shot 2022-03-18 at 3 57 13 PM

  • Remove word current from the Cancel Diagnostics request
    Before

Screen Shot 2022-03-18 at 3 58 01 PM

After
Screen Shot 2022-03-18 at 3 58 44 PM

Screen Shot 2022-03-18 at 4 35 29 PM

After
Screen Shot 2022-03-18 at 6 03 25 PM

  • Update color of alert message on Conditional Diagnostic Request
    Before

Screen Shot 2022-03-18 at 5 08 52 PM

After
Screen Shot 2022-03-18 at 5 16 18 PM

  • Change trace to diagnostic bundle
    Before

Screen Shot 2022-03-18 at 5 21 03 PM

After
Screen Shot 2022-03-18 at 5 43 18 PM

  • Update link color/underline on hover for node and app name
    Before

Screen Shot 2022-03-18 at 5 46 34 PM

After
Screen Shot 2022-03-18 at 5 53 04 PM

Partially addresses #77982

Release note: None


Release justification: Low risk, high benefit changes

This commit introduces fixes to Statements Page:

- Update style of link on tooltip for diagnostic status and
add space before `When`
- Remove word `current` from the Cancel Diagnostics request
- Slow loading message only show after a few seconds of page loading
- Space between item (seach / filter/ time picker) are now 12px and
the size of both dividers are the same (using the heigh of all items)
- Update color of alert message on Conditional Diagnostic Request
- Change `trace` to `diagnostic bundle`
- Update link color/underline on hover for node and app name

Partially addresses #77982

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-78106 branch from c79d907 to 3bf6fa6 Compare March 21, 2022 17:18
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 21, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 21, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag removed the request for review from Annebirzin March 21, 2022 17:44
Copy link
Contributor

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag maryliag merged commit ee162f2 into release-22.1 Mar 21, 2022
@maryliag maryliag deleted the blathers/backport-release-22.1-78106 branch March 21, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants